Rename alias definitions by both aliased and alias name

[emaste]

Third try to spell 'soname'

[• rafael]

Why do we need both? Why not, for example

def alias_library_path ....

[ruiu]

LGTM with a nit.

ELF/Options.td

73 ↗

(On Diff #36395)

I'd name this alias_Llibrary_path (two extra for --).

(in case we want to define two aliases, say -foo and --foo)

77 ↗

(On Diff #36395)

alias_l__library

[emaste]

In D13397#258935, @rafael wrote:

Why do we need both? Why not, for example

def alias_library_path ....

That was my original thought, but then I noticed that the existing Bdynamic... ones have both. That approach has the nice property that multiple aliases for the same option are grouped together when sorting them alphabetically.

lld/trunk/ELF/Options.td

def whole_archive : Flag<["--"], "whole-archive">,
   HelpText<"Force load of all members in a static library">;
 
 // Aliases
 def alias_Bdynamic_call_shared: Flag<["-"], "call_shared">, Alias<Bdynamic>;
 def alias_Bdynamic_dy: Flag<["-"], "dy">, Alias<Bdynamic>;
 def alias_Bstatic_dn: Flag<["-"], "dn">, Alias<Bstatic>;
 def alias_Bstatic_non_shared: Flag<["-"], "non_shared">, Alias<Bstatic>;
 def alias_Bstatic_static: Flag<["-"], "static">, Alias<Bstatic>;
-def alias_L : Joined<["--"], "library-path=">, Alias<L>;
-def alias_discard_all: Flag<["-"], "x">, Alias<discard_all>;
-def alias_discard_locals: Flag<["-"], "X">, Alias<discard_locals>;
-def alias_entry : Separate<["-"], "e">, Alias<entry>;
-def alias_l : Joined<["--"], "library=">, Alias<l>;
-def alias_soname : Separate<["-"], "h">, Alias<soname>;
-def alias_snoame : Separate<["-"], "soname">, Alias<soname>;
+def alias_L__library_path : Joined<["--"], "library-path=">, Alias<L>;
+def alias_discard_all_x: Flag<["-"], "x">, Alias<discard_all>;
+def alias_discard_locals_X: Flag<["-"], "X">, Alias<discard_locals>;
+def alias_entry_e : Separate<["-"], "e">, Alias<entry>;
+def alias_l__library : Joined<["--"], "library=">, Alias<l>;
+def alias_soname_h : Separate<["-"], "h">, Alias<soname>;
+def alias_soname_soname : Separate<["-"], "soname">, Alias<soname>;
 
 // Options listed below are silently ignored now.
 def O3 : Flag<["-"], "O3">;
 def as_needed : Flag<["--"], "as-needed">;
 def build_id : Flag<["--"], "build-id">;
 def eh_frame_hdr : Flag<["--"], "eh-frame-hdr">;
 def enable_new_dtags : Flag<["--"], "enable-new-dtags">;
 def end_group : Flag<["--"], "end-group">;