[compiler-rt] [sanitizer] Clean buildbot failures for aarch64

[zatrazz]

Summary

Currently aarch64 lacks instrumentation support for variadic arguments
for MSan. This patch sets the UBSan tests that uses it as to require
stable-runtime and sets aarch64/ubsan as an unstable one.

[rengolin]

I assume this takes care of all three XPASS at the moment on some machines but not others.

LGTM. Thanks!

[samsonov]

LGTM

[zatrazz]

This should take care of remaining msan issues on aarch64 buildbots.

[zatrazz]

The vptr-virtual-base tests are also set to require stable-runtime
because aarch64 kernel might sets different permission for the heap
segments and thus invaliding the checks for the false-positive.

[rengolin]

Thanks for investigating it further! We need to know why they're failing, so would be good if you could add a one line comment before the REQUIRES line explaining about the kernel options for vptr.

Please, commit as soon as possible, as the bots are red for almost a week now.

[zatrazz]

The revision r247484 'ubsan: Implement memory permission validation for vtables.' has been reverted by r247921. I will rebase my patch to initial state and push it.

test/ubsan/TestCases/Misc/nonnull-arg.cpp

 // RUN: %clangxx -fsanitize=nonnull-attribute -fno-sanitize-recover=all %s -O3 -o %t
 // RUN: %run %t nc
 // RUN: %run %t nm
 // RUN: %run %t nf
 // RUN: %run %t nv
 // RUN: not %run %t 0c 2>&1 | FileCheck %s --check-prefix=CTOR
 // RUN: not %run %t 0m 2>&1 | FileCheck %s --check-prefix=METHOD
 // RUN: not %run %t 0f 2>&1 | FileCheck %s --check-prefix=FUNC
 // RUN: not %run %t 0v 2>&1 | FileCheck %s --check-prefix=VARIADIC
 //
-// AArch64 lacks var args instrumentation.
-// XFAIL: aarch64
+// AArch64 lacks variadic instrumentation for MSAN.
+// REQUIRES: stable-runtime
 
 class C {
   int *null_;
   int *nonnull_;
 
 public:
   C(int *null, __attribute__((nonnull)) int *nonnull)
       : null_(null), nonnull_(nonnull) {}

test/ubsan/TestCases/TypeCheck/vptr-virtual-base-construction.cpp

 // RUN: %clangxx -frtti -fsanitize=vptr -fno-sanitize-recover=vptr %s -o %t
 // RUN: %run %t
 
-// REQUIRES: cxxabi
+// REQUIRES: stable-runtime, cxxabi
 
 int volatile n;
 
 struct A { virtual ~A() {} };
 struct B: virtual A {};
 struct C: virtual A { ~C() { n = 0; } };
 struct D: virtual B, virtual C {};
 
 int main() { delete new D; }

test/ubsan/TestCases/TypeCheck/vptr-virtual-base.cpp

 // RUN: %clangxx -frtti -fsanitize=vptr -fno-sanitize-recover=vptr -g %s -O3 -o %t
 // RUN: not %run %t 2>&1 | FileCheck %s
 
-// REQUIRES: cxxabi
+// REQUIRES: stable-runtime, cxxabi
 
 struct S { virtual int f() { return 0; } };
 struct T : virtual S {};
 
 struct Foo { virtual int f() { return 0; } };
 
 int main(int argc, char **argv) {
   Foo foo;
   T *t = (T*)&foo;
   S *s = t;
   // CHECK: vptr-virtual-base.cpp:[[@LINE-1]]:10: runtime error: cast to virtual base of address [[PTR:0x[0-9a-f]*]] which does not point to an object of type 'T'
   // CHECK-NEXT: [[PTR]]: note: object is of type 'Foo'
   return s->f();
 }

test/ubsan/lit.common.cfg

 
 if config.host_os == 'Windows':
   # We do not currently support enough of the Microsoft ABI for UBSan to work on
   # Windows.
   config.available_features.remove('cxxabi')
 
 # Allow tests to use REQUIRES=stable-runtime.  For use when you cannot use XFAIL
 # because the test hangs or fails on one configuration and not the other.
-if config.target_arch.startswith('arm') == False:
+if config.target_arch.startswith('arm') == False and config.target_arch != 'aarch64':
   config.available_features.add('stable-runtime')
 
 if config.host_os == 'Linux' and config.target_arch != 'powerpc64' and \
    config.target_arch != 'powerpc64le':
   config.available_features.add('vptr-validation')