Page MenuHomePhabricator

[cmake] Build lldb-server on Darwin, set dep on FreeBSD.
ClosedPublic

Authored by brucem on Sep 17 2015, 12:08 AM.

Details

Summary

This switches the decision as to whether or not to lldb-server should
be built to check the same flag that was added that controls whether
or not it is added as a dependency to the 'lldb' target.

It also sets that flag on FreeBSD to maintain parity with the existing
build configuration / situation on FreeBSD.

Diff Detail

Event Timeline

brucem updated this revision to Diff 34967.Sep 17 2015, 12:08 AM
brucem retitled this revision from to [cmake] Build lldb-server on Darwin, set dep on FreeBSD..
brucem updated this object.
brucem added reviewers: labath, emaste, tfiala.
brucem added a subscriber: lldb-commits.

This should also address https://llvm.org/bugs/show_bug.cgi?id=24843 as reported by tfiala.

labath resigned from this revision.Sep 17 2015, 1:51 AM
labath removed a reviewer: labath.

looks good to me, but i'll let others decide whether they want that

emaste accepted this revision.Sep 17 2015, 8:01 AM
emaste edited edge metadata.

I'm happy with the FreeBSD change. Minor nit, perhaps put in alpha order?

This revision is now accepted and ready to land.Sep 17 2015, 8:01 AM
brucem updated this revision to Diff 35002.Sep 17 2015, 8:31 AM
brucem edited edge metadata.

Put in alpha order as emaste suggested.

tfiala accepted this revision.Sep 17 2015, 8:48 AM
tfiala edited edge metadata.

LGTM, thanks Bruce!

This revision was automatically updated to reflect the committed changes.