[cmake] Build lldb-server on Darwin, set dep on FreeBSD.

[brucem]

Summary

This switches the decision as to whether or not to lldb-server should
be built to check the same flag that was added that controls whether
or not it is added as a dependency to the 'lldb' target.

It also sets that flag on FreeBSD to maintain parity with the existing
build configuration / situation on FreeBSD.

[brucem]

This should also address https://llvm.org/bugs/show_bug.cgi?id=24843 as reported by tfiala.

[labath]

looks good to me, but i'll let others decide whether they want that

[emaste]

I'm happy with the FreeBSD change. Minor nit, perhaps put in alpha order?

[brucem]

Put in alpha order as emaste suggested.

[tfiala]

LGTM, thanks Bruce!

lldb/trunk/cmake/modules/LLDBConfig.cmake

else()
         if (HAVE_NR_PROCESS_VM_READV)
             add_definitions(-DHAVE_NR_PROCESS_VM_READV)
         endif()
     endif()
 endif()
 
 # Figure out if lldb could use lldb-server.  If so, then we'll
 # ensure we build lldb-server when an lldb target is being built.
-if ( ( CMAKE_SYSTEM_NAME MATCHES "Linux" ) OR
-     ( CMAKE_SYSTEM_NAME MATCHES "Darwin" ) )
+if ((CMAKE_SYSTEM_NAME MATCHES "Darwin") OR
+    (CMAKE_SYSTEM_NAME MATCHES "FreeBSD") OR
+    (CMAKE_SYSTEM_NAME MATCHES "Linux"))
     set(LLDB_CAN_USE_LLDB_SERVER 1)
 else()
     set(LLDB_CAN_USE_LLDB_SERVER 0)
 endif()
 
 # Figure out if lldb could use debugserver.  If so, then we'll
 # ensure we build debugserver when we build lldb.
 if ( CMAKE_SYSTEM_NAME MATCHES "Darwin" )
     set(LLDB_CAN_USE_DEBUGSERVER 1)
 else()
     set(LLDB_CAN_USE_DEBUGSERVER 0)
 endif()

lldb/trunk/tools/CMakeLists.txt

 if (CMAKE_SYSTEM_NAME MATCHES "Darwin")
   add_subdirectory(darwin-debug)
   add_subdirectory(debugserver)
 endif()
   add_subdirectory(argdumper)
   add_subdirectory(driver)
 if (NOT __ANDROID_NDK__)
   add_subdirectory(lldb-mi)
 endif()
-if (CMAKE_SYSTEM_NAME MATCHES "FreeBSD" OR CMAKE_SYSTEM_NAME MATCHES "Linux")
+if (LLDB_CAN_USE_LLDB_SERVER)
   add_subdirectory(lldb-server)
 endif()