[LLD][COFF] Corrected error message if a section failed to load

[ikudrin]

Summary

There is no sense to use Name in these lines as it is not initialized yet.

[• rafael]

Is it possible to add a testcase?

[ikudrin]

In D12829#244860, @rafael wrote:

Is it possible to add a testcase?

The first line cannot fire with current sources, it's more like a redundant safety check.
The second line can fire if an obj file is invalid and contains sections with invalid names. I can write a test for this case if it's worth it.

[ikudrin]

Added the test for error message generation.

[ruiu]

LGTM

lld/trunk/test/COFF/invalid-obj.test

4

Does this actually contain the trailing colon?

[ikudrin]

Could you please commit it as I don't have write permissions?

lld/trunk/test/COFF/invalid-obj.test

4

The full message is "getSectionName failed: #1: Invalid data was encountered while parsing the file", but the last part comes from the other place, so I decided to not add it here to make the test less fragile.

[ruiu]

Submitted as r247531. Thanks!

lld/trunk/COFF/InputFiles.cpp

 void ObjectFile::initializeChunks() {
   uint32_t NumSections = COFFObj->getNumberOfSections();
   Chunks.reserve(NumSections);
   SparseChunks.resize(NumSections + 1);
   for (uint32_t I = 1; I < NumSections + 1; ++I) {
     const coff_section *Sec;
     StringRef Name;
     std::error_code EC = COFFObj->getSection(I, Sec);
-    error(EC, Twine("getSection failed: ") + Name);
+    error(EC, Twine("getSection failed: #") + Twine(I));
     EC = COFFObj->getSectionName(Sec, Name);
-    error(EC, Twine("getSectionName failed: ") + Name);
+    error(EC, Twine("getSectionName failed: #") + Twine(I));
     if (Name == ".sxdata") {
       SXData = Sec;
       continue;
     }
     if (Name == ".drectve") {
       ArrayRef<uint8_t> Data;
       COFFObj->getSectionContents(Sec, Data);
       Directives = std::string((const char *)Data.data(), Data.size());

lld/trunk/test/COFF/invalid-obj.test

+# RUN: yaml2obj %s > %t.obj
+# RUN: not lld-link %t.obj 2>&1 | FileCheck %s
+
+# CHECK: getSectionName failed: #1:
+
+---
+header:
+  Machine:         IMAGE_FILE_MACHINE_AMD64
+  Characteristics: [  ]
+sections:
+  - Name:            '/1'
+    Characteristics: [  ]
+    SectionData:     00
+symbols: