Page MenuHomePhabricator

ikudrin (Igor Kudrin)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 6 2015, 10:51 PM (280 w, 3 d)

Recent Activity

Fri, Jan 15

ikudrin added a comment to D94668: [debug-info] [NFC] add isa support for MCStreamer.

Is it possible to encapsulate the target-specific logic into some derived classes from {{MCStreamer}} so that {{MCStreamer}} itself and DWARF emitter classes work through a common interface and have no target-specific adjustments?

Fri, Jan 15, 5:18 AM · Restricted Project
ikudrin added a comment to D94670: [DebugInfo][NFC] add a new DIE type to represent label + offset.

I suppose that you describe how .dwsect pseudo-op works. That is quite interesting, why they designed the feature to work that way. Is it recommended to reference debug sections through the label minus the length field size (4 or 12) or they provide some means to simplify the calculation? How an assembler output of their own compiler looks like?

Fri, Jan 15, 5:18 AM · Restricted Project
ikudrin committed rG78036360573c: [libcxx testing] Fix UB in tests for std::lock_guard (authored by ikudrin).
[libcxx testing] Fix UB in tests for std::lock_guard
Fri, Jan 15, 1:12 AM
ikudrin closed D94656: [libcxx testing] Fix UB in tests for std::lock_guard.
Fri, Jan 15, 1:12 AM · Restricted Project

Thu, Jan 14

ikudrin updated the diff for D94656: [libcxx testing] Fix UB in tests for std::lock_guard.

Trying to force CI to run.

Thu, Jan 14, 6:47 PM · Restricted Project
ikudrin added a project to D94656: [libcxx testing] Fix UB in tests for std::lock_guard: Restricted Project.
Thu, Jan 14, 5:23 PM · Restricted Project
ikudrin updated the diff for D94656: [libcxx testing] Fix UB in tests for std::lock_guard.
  • Updated as suggested. Thanks, @ldionne!
Thu, Jan 14, 8:04 AM · Restricted Project
ikudrin added inline comments to D94670: [DebugInfo][NFC] add a new DIE type to represent label + offset.
Thu, Jan 14, 7:31 AM · Restricted Project
ikudrin added a comment to D94656: [libcxx testing] Fix UB in tests for std::lock_guard.

The current code violates the C++ standard, which says (in different sections, depending on the version):

Thu, Jan 14, 4:31 AM · Restricted Project
ikudrin requested review of D94656: [libcxx testing] Fix UB in tests for std::lock_guard.
Thu, Jan 14, 12:16 AM · Restricted Project

Dec 20 2020

ikudrin added inline comments to D90507: [Driver] Add DWARF64 flag: -gdwarf64.
Dec 20 2020, 9:05 PM · Restricted Project

Nov 18 2020

ikudrin added inline comments to D90507: [Driver] Add DWARF64 flag: -gdwarf64.
Nov 18 2020, 9:46 PM · Restricted Project

Nov 16 2020

ikudrin added a comment to D90507: [Driver] Add DWARF64 flag: -gdwarf64.

It looks like lld/test/COFF/lto-new-pass-manager.ll.obj was added to the patch by accident and should be removed.

Nov 16 2020, 8:19 PM · Restricted Project

Nov 13 2020

ikudrin added a comment to D91404: RFC: [ELF] Add --dwarf32-before-dwarf64 to place DWARF32 input sections before DWARF64.

Well, this is a bit different from my original idea but is an overall good heuristic for many of the debug sections. It works for .debug_info, which is one of the biggest sections; it does not work for .debug_line, though, which is not that big as .debug_info, but potentially might become problematic in the (distant) future; it also does not work for .debug_abbrev, .debug_addr, .debug_ranges, and some others, which are usually not that big. However, the patch should be extended to support .debug_str, which can be even larger than .debug_info.

Nov 13 2020, 5:33 AM · Restricted Project

Nov 6 2020

ikudrin added a comment to D87011: [DebugInfo] Add the -dwarf64 switch to llc and other internal tools (4/19)..

At least in LLD, it's not quite as simple as being added after the user's code: if a library appears on the link line it will be included in the output order as soon as it is determined it is needed. Thus if you have have three modules 1.o, 2.o, and 3.o, with 3.o in an archive 3.a and 1.o requiring 3.o, you end up with an output order of 1.o 3.o 2.o if the input order was 1.o 3.a 2.o or 3.a 1.o 2.o or an output order of 1.o 2.o 3.o if the input order was 1.o 2.o 3.a. In fact, with use of the --undefined linker switch, you can even force 3.o to appear first.

I accept using --undefined or rearranging the command-line order is less than ideal, but I'm really not convinced LLD should have any place in parsing the DWARF to determine output order. Furthermore, it's not even a reliable solution - if the objects built with DWARF32 (potentially all of which might have come from libraries) are large enough, no amount of reordering will fix the behaviour. I think users who need DWARF64 in their libraries are just going to have to request DWARF64 versions of the libraries, if the --undefined and reordering command line options are insufficient.

Nov 6 2020, 3:09 AM · debug-info, Restricted Project
ikudrin added a comment to D87011: [DebugInfo] Add the -dwarf64 switch to llc and other internal tools (4/19)..

I wouldn't expect LLD to need to do anything specific for DWARF64 support. It should generally speaking be treating the sections as opaque, in my opinion, and treat them no differently to other sections. If a user is mixing DWARF32 and DWARF64, then I'd say it's on their heads if relocations can't reach (just the same as it is if they're using DWARF32 but really need DWARF64). Any interactions LLD does have with the contents of the DWARF sections should be controlled via the DebugInfo library, and therefore if that library works for DWARF64, LLD doesn't need any special handling.

Nov 6 2020, 1:32 AM · debug-info, Restricted Project

Nov 5 2020

ikudrin added a comment to D90507: [Driver] Add DWARF64 flag: -gdwarf64.
  1. The patch needs tests to check the added functionality.
  2. DWARF64 can be generated only for a limited number of targets. There should be diagnostics for invalid switch combinations to prevent misuse. @MaskRay mentioned that in the patch for llc, D87011#2254749, but that makes a lot more sense for user-level tools.
Nov 5 2020, 9:40 PM · Restricted Project
ikudrin added a comment to D87011: [DebugInfo] Add the -dwarf64 switch to llc and other internal tools (4/19)..

I suppose that it would be helpful to arrange debugging information sections so that DWARF64 comes after DWARF32, otherwise, some 32-bit relocations in the 32-bit info could not be resolved. But that idea might be a bit controversial because usually debugging information is expected to have the same order as the sections it refers to.

Nov 5 2020, 7:21 PM · debug-info, Restricted Project

Nov 4 2020

ikudrin added a comment to D87011: [DebugInfo] Add the -dwarf64 switch to llc and other internal tools (4/19)..

To generate 64-bit debugging info, there should be enough to pass the switch through CLANG, right. Apart from that, we will probably need some compatibility checks so that using the switch in unsupported cases prints out diagnostics. There are also some improvements on the LLD side which are better to be done to support extremely large debugging information. Not all our tools fully support DWARF64 yet, etc.

Nov 4 2020, 9:07 PM · debug-info, Restricted Project

Oct 28 2020

ikudrin added a comment to D87011: [DebugInfo] Add the -dwarf64 switch to llc and other internal tools (4/19)..

The switch is implemented only internally in LLVM. There is still some work to be done to enable producing 64-bit debugging info in clang, but I strayed a bit for another task. Hope to come back later this year.

Oct 28 2020, 7:48 PM · debug-info, Restricted Project

Oct 27 2020

ikudrin added a comment to D87011: [DebugInfo] Add the -dwarf64 switch to llc and other internal tools (4/19)..

@ikudrin To clarify this will emit R_X86_64_64 bit relocations for .debug_info on 64 bit platform, correct?

Oct 27 2020, 10:16 PM · debug-info, Restricted Project

Oct 23 2020

ikudrin added a comment to D88877: [ELF] Drop --whole-archive before processing dependent libraries..

I am still concerned that we go down this route (workaround in the linker rather than teach the user to add --no-whole-archive just because of convenience adding logic in the linker). Among --push-state pushed states, --as-needed and -Bstatic may be states users want to keep for the dependent libraries.

Oct 23 2020, 8:53 PM · Restricted Project, lld

Oct 22 2020

ikudrin updated the diff for D88877: [ELF] Drop --whole-archive before processing dependent libraries..
Oct 22 2020, 11:46 PM · Restricted Project, lld

Oct 21 2020

ikudrin added inline comments to D88877: [ELF] Drop --whole-archive before processing dependent libraries..
Oct 21 2020, 8:03 AM · Restricted Project, lld
ikudrin updated the diff for D88877: [ELF] Drop --whole-archive before processing dependent libraries..

I think I agree that build systems might not easily be able to arrange for appending options to the end of the linker command line. Therefore, for the "dependent libraries" feature (I changed the name in https://reviews.llvm.org/D60274 because autolinking was too general) it would be reasonable to reset any temporal options that the build system would otherwise have to handle by appending an argument to the very end of the command line (e.g. --whole-archives). Where appropriate we can create new order-independent options to apply the options that are reset to the dependent libraries. This seems like an improvement over what we have now.

Oct 21 2020, 8:03 AM · Restricted Project, lld

Oct 19 2020

ikudrin committed rG1329944c221c: [LTO][Legacy] Eliminate an unused member of llvm::LTOModule. NFC. (authored by ikudrin).
[LTO][Legacy] Eliminate an unused member of llvm::LTOModule. NFC.
Oct 19 2020, 11:35 PM
ikudrin closed D89472: [LTO][Legacy] Eliminate an unused member of llvm::LTOModule. NFC..
Oct 19 2020, 11:35 PM · Restricted Project

Oct 16 2020

ikudrin added a comment to D88877: [ELF] Drop --whole-archive before processing dependent libraries..

Hmm, that starts looking like a discussion for the mailing list, but I guess that all interested people are already here and the conversation will be better preserved for further references if being linked to the review.

Oct 16 2020, 3:03 AM · Restricted Project, lld

Oct 15 2020

ikudrin added reviewers for D89472: [LTO][Legacy] Eliminate an unused member of llvm::LTOModule. NFC.: pcc, steven_wu.
Oct 15 2020, 8:54 PM · Restricted Project
ikudrin requested review of D89472: [LTO][Legacy] Eliminate an unused member of llvm::LTOModule. NFC..
Oct 15 2020, 7:58 AM · Restricted Project
ikudrin added inline comments to D88877: [ELF] Drop --whole-archive before processing dependent libraries..
Oct 15 2020, 12:50 AM · Restricted Project, lld
ikudrin updated the diff for D88877: [ELF] Drop --whole-archive before processing dependent libraries..
Oct 15 2020, 12:49 AM · Restricted Project, lld

Oct 14 2020

ikudrin added a comment to D88877: [ELF] Drop --whole-archive before processing dependent libraries..

Firstly, is this a real problem?

Oct 14 2020, 11:14 PM · Restricted Project, lld
ikudrin added a comment to D88877: [ELF] Drop --whole-archive before processing dependent libraries..

Gently ping. Is there anything I can improve in the fix so that it is accepted?

Oct 14 2020, 8:42 AM · Restricted Project, lld

Oct 8 2020

ikudrin added a comment to D88944: [ELF] Skip repeated libraries..

I've made some tests and speculatively estimate the saving up to several seconds for a relatively large library (about 100000 symbols) which is referenced several hundred times. For me, that is noticeable.

Oct 8 2020, 6:59 AM · lld, Restricted Project

Oct 6 2020

ikudrin added a comment to D88944: [ELF] Skip repeated libraries..

I am skeptical about the change.

  • The duplicated libraries are usually indicator of user errors or build system brittleness.
Oct 6 2020, 11:59 PM · lld, Restricted Project
ikudrin updated the diff for D88877: [ELF] Drop --whole-archive before processing dependent libraries..
  • Simplified the comment.
Oct 6 2020, 11:26 PM · Restricted Project, lld
ikudrin requested review of D88944: [ELF] Skip repeated libraries..
Oct 6 2020, 10:04 PM · lld, Restricted Project
ikudrin updated the diff for D88877: [ELF] Drop --whole-archive before processing dependent libraries..
  • Fixed the comment.
Oct 6 2020, 9:45 PM · Restricted Project, lld
ikudrin added inline comments to D88877: [ELF] Drop --whole-archive before processing dependent libraries..
Oct 6 2020, 9:39 PM · Restricted Project, lld
ikudrin requested review of D88877: [ELF] Drop --whole-archive before processing dependent libraries..
Oct 6 2020, 2:12 AM · Restricted Project, lld

Sep 21 2020

ikudrin committed rG474d527c28f4: [clang] Fix a misleading variable name. NFC. (authored by ikudrin).
[clang] Fix a misleading variable name. NFC.
Sep 21 2020, 9:00 AM
ikudrin closed D88021: [clang] Fix a misleading variable name. NFC..
Sep 21 2020, 9:00 AM · Restricted Project, Restricted Project
ikudrin requested review of D88021: [clang] Fix a misleading variable name. NFC..
Sep 21 2020, 5:53 AM · Restricted Project, Restricted Project

Sep 16 2020

ikudrin committed rG027d47d1c7ce: [DebugInfo] Simplify DIEInteger::SizeOf(). (authored by ikudrin).
[DebugInfo] Simplify DIEInteger::SizeOf().
Sep 16 2020, 10:48 PM
ikudrin closed D85293: [DebugInfo] Simplify DIEInteger::SizeOf()..
Sep 16 2020, 10:48 PM · debug-info, Restricted Project
ikudrin added inline comments to D85293: [DebugInfo] Simplify DIEInteger::SizeOf()..
Sep 16 2020, 6:58 PM · debug-info, Restricted Project
ikudrin updated the diff for D85293: [DebugInfo] Simplify DIEInteger::SizeOf()..

D87008 added creating a test AsmPrinter to the CodeGen unit tests, so it is now possible to fix the DIEHashTest.MemberBlock so that it provides an instance to the tested class.

Sep 16 2020, 6:46 AM · debug-info, Restricted Project

Sep 14 2020

ikudrin committed rGa845ebd6333d: [DebugInfo] Make offsets of dwarf units 64-bit (19/19). (authored by ikudrin).
[DebugInfo] Make offsets of dwarf units 64-bit (19/19).
Sep 14 2020, 10:26 PM
ikudrin committed rG8c19ac23bdef: [DebugInfo] Make the offset of string pool entries 64-bit (18/19). (authored by ikudrin).
[DebugInfo] Make the offset of string pool entries 64-bit (18/19).
Sep 14 2020, 10:26 PM
ikudrin committed rG7e1e4e81cbca: [DebugInfo] Fix emitting DWARF64 .debug_macro[.dwo] sections (17/19). (authored by ikudrin).
[DebugInfo] Fix emitting DWARF64 .debug_macro[.dwo] sections (17/19).
Sep 14 2020, 10:26 PM
ikudrin committed rGa93dd26d8ced: [DebugInfo] Fix emitting DWARF64 .debug_names sections (16/19). (authored by ikudrin).
[DebugInfo] Fix emitting DWARF64 .debug_names sections (16/19).
Sep 14 2020, 10:26 PM
ikudrin committed rG00ce54689d30: [DebugInfo] Fix emitting DWARF64 .debug_addr sections (15/19). (authored by ikudrin).
[DebugInfo] Fix emitting DWARF64 .debug_addr sections (15/19).
Sep 14 2020, 10:26 PM
ikudrin closed D87026: [DebugInfo] Make offsets of dwarf units 64-bit (19/19)..
Sep 14 2020, 10:26 PM · debug-info, Restricted Project
ikudrin committed rG3158d3dd4b7e: [DebugInfo] Fix emitting DWARF64 .debug_loclists sections (14/19). (authored by ikudrin).
[DebugInfo] Fix emitting DWARF64 .debug_loclists sections (14/19).
Sep 14 2020, 10:26 PM
ikudrin closed D87025: [DebugInfo] Make the offset of string pool entries 64-bit (18/19)..
Sep 14 2020, 10:26 PM · debug-info, Restricted Project
ikudrin committed rGf9b242fe24f7: [DebugInfo] Fix emitting DWARF64 .debug_rnglists sections (13/19). (authored by ikudrin).
[DebugInfo] Fix emitting DWARF64 .debug_rnglists sections (13/19).
Sep 14 2020, 10:25 PM
ikudrin closed D87024: [DebugInfo] Fix emitting DWARF64 .debug_macro[.dwo] sections (17/19)..
Sep 14 2020, 10:25 PM · debug-info, Restricted Project
ikudrin committed rG03b09c6b68bb: [DebugInfo] Fix emitting pre-v5 name lookup tables in the DWARF64 format… (authored by ikudrin).
[DebugInfo] Fix emitting pre-v5 name lookup tables in the DWARF64 format…
Sep 14 2020, 10:25 PM
ikudrin closed D87023: [DebugInfo] Fix emitting DWARF64 .debug_names sections (16/19)..
Sep 14 2020, 10:25 PM · debug-info, Restricted Project
ikudrin committed rGb118030f3fa6: [DebugInfo] Fix emitting DWARF64 .debug_aranges sections (11/19). (authored by ikudrin).
[DebugInfo] Fix emitting DWARF64 .debug_aranges sections (11/19).
Sep 14 2020, 10:25 PM
ikudrin closed D87022: [DebugInfo] Fix emitting DWARF64 .debug_addr sections (15/19)..
Sep 14 2020, 10:25 PM · debug-info, Restricted Project
ikudrin committed rG18f23b3ecc6d: [DebugInfo] Fix emitting DWARF64 type units (10/19). (authored by ikudrin).
[DebugInfo] Fix emitting DWARF64 type units (10/19).
Sep 14 2020, 10:25 PM
ikudrin closed D87020: [DebugInfo] Fix emitting DWARF64 .debug_loclists sections (14/19)..
Sep 14 2020, 10:25 PM · debug-info, Restricted Project
ikudrin closed D87019: [DebugInfo] Fix emitting DWARF64 .debug_rnglists sections (13/19)..
Sep 14 2020, 10:25 PM · debug-info, Restricted Project
ikudrin committed rG924dc5807690: [DebugInfo] Fix emitting DWARF64 DWO compilation units and string offset tables… (authored by ikudrin).
[DebugInfo] Fix emitting DWARF64 DWO compilation units and string offset tables…
Sep 14 2020, 10:25 PM
ikudrin committed rG383d34c077ae: [DebugInfo] Fix emitting DWARF64 .debug_str_offsets sections (8/19). (authored by ikudrin).
[DebugInfo] Fix emitting DWARF64 .debug_str_offsets sections (8/19).
Sep 14 2020, 10:25 PM
ikudrin closed D87013: [DebugInfo] Fix emitting pre-v5 name lookup tables in the DWARF64 format (12/19)..
Sep 14 2020, 10:25 PM · debug-info, Restricted Project
ikudrin closed D87012: [DebugInfo] Fix emitting DWARF64 .debug_aranges sections (11/19)..
Sep 14 2020, 10:25 PM · debug-info, Restricted Project
ikudrin committed rG26f1f1883134: [DebugInfo] Fix emitting the DW_AT_location attribute for 64-bit DWARFv3 (7/19). (authored by ikudrin).
[DebugInfo] Fix emitting the DW_AT_location attribute for 64-bit DWARFv3 (7/19).
Sep 14 2020, 10:25 PM
ikudrin closed D87021: [DebugInfo] Fix emitting DWARF64 type units (10/19)..
Sep 14 2020, 10:25 PM · debug-info, Restricted Project
ikudrin committed rGcae7c1eb781d: [DebugInfo] Use a common method to determine a suitable form for section offsts… (authored by ikudrin).
[DebugInfo] Use a common method to determine a suitable form for section offsts…
Sep 14 2020, 10:25 PM
ikudrin committed rG5dd1c5918898: [DebugInfo] Fix emitting DWARF64 compilation units (5/19). (authored by ikudrin).
[DebugInfo] Fix emitting DWARF64 compilation units (5/19).
Sep 14 2020, 10:25 PM
ikudrin closed D87018: [DebugInfo] Fix emitting DWARF64 DWO compilation units and string offset tables (9/19)..
Sep 14 2020, 10:25 PM · debug-info, Restricted Project
ikudrin closed D87017: [DebugInfo] Fix emitting DWARF64 .debug_str_offsets sections (8/19)..
Sep 14 2020, 10:25 PM · debug-info, Restricted Project
ikudrin committed rG982b31fad298: [DebugInfo] Add the -dwarf64 switch to llc and other internal tools (4/19). (authored by ikudrin).
[DebugInfo] Add the -dwarf64 switch to llc and other internal tools (4/19).
Sep 14 2020, 10:24 PM
ikudrin closed D87016: [DebugInfo] Fix emitting the DW_AT_location attribute for 64-bit DWARFv3 (7/19)..
Sep 14 2020, 10:24 PM · debug-info, Restricted Project
ikudrin committed rGa8058c6f8d1d: [DebugInfo] Fix DIE value emitters to be compatible with DWARF64 (2/19). (authored by ikudrin).
[DebugInfo] Fix DIE value emitters to be compatible with DWARF64 (2/19).
Sep 14 2020, 10:24 PM
ikudrin committed rGc3c501f5d791: [DebugInfo] Add new emitting methods for values which depend on the DWARF… (authored by ikudrin).
[DebugInfo] Add new emitting methods for values which depend on the DWARF…
Sep 14 2020, 10:24 PM
ikudrin closed D87015: [DebugInfo] Use a common method to determine a suitable form for section offsts (6/19)..
Sep 14 2020, 10:24 PM · debug-info, Restricted Project
ikudrin committed rG380e746bcca8: [DebugInfo] Fix methods of AsmPrinter to emit values corresponding to the DWARF… (authored by ikudrin).
[DebugInfo] Fix methods of AsmPrinter to emit values corresponding to the DWARF…
Sep 14 2020, 10:24 PM
ikudrin closed D87014: [DebugInfo] Fix emitting DWARF64 compilation units (5/19)..
Sep 14 2020, 10:24 PM · debug-info, Restricted Project
ikudrin closed D87011: [DebugInfo] Add the -dwarf64 switch to llc and other internal tools (4/19)..
Sep 14 2020, 10:24 PM · debug-info, Restricted Project
ikudrin closed D87010: [DebugInfo] Add new emitting methods for values which depend on the DWARF format (3/19)..
Sep 14 2020, 10:24 PM · debug-info, Restricted Project
ikudrin closed D87009: [DebugInfo] Fix DIE value emitters to be compatible with DWARF64 (2/19)..
Sep 14 2020, 10:24 PM · debug-info, Restricted Project
ikudrin closed D87008: [DebugInfo] Fix methods of AsmPrinter to emit values corresponding to the DWARF format (1/19)..
Sep 14 2020, 10:24 PM · debug-info, Restricted Project
ikudrin added inline comments to D87008: [DebugInfo] Fix methods of AsmPrinter to emit values corresponding to the DWARF format (1/19)..
Sep 14 2020, 12:53 AM · debug-info, Restricted Project

Sep 11 2020

ikudrin added inline comments to D87026: [DebugInfo] Make offsets of dwarf units 64-bit (19/19)..
Sep 11 2020, 5:40 AM · debug-info, Restricted Project
ikudrin added inline comments to D87008: [DebugInfo] Fix methods of AsmPrinter to emit values corresponding to the DWARF format (1/19)..
Sep 11 2020, 4:52 AM · debug-info, Restricted Project
ikudrin added a comment to D87021: [DebugInfo] Fix emitting DWARF64 type units (10/19)..

The test sources were based on some simple code, but then they were cleared as much as I could.

You mean the IR was modified after compilation? Or that the original C source was simplified as much as possible?

Sep 11 2020, 4:22 AM · debug-info, Restricted Project
ikudrin added a comment to D87009: [DebugInfo] Fix DIE value emitters to be compatible with DWARF64 (2/19)..

Let's take, for example, DIEExpr. As far as I can find, with DW_FORM_sec_offset it is used only in the DebugInfo/DWARF unit tests, in dwarfgen::DIE::addStrOffsetsBaseAttribute(). If we took the approach with end-to-end functional testing, this class would not be updated. And the path is not simple to track, by the way.

API only intended for unit tests would be tested/updated with unit tests.

Sep 11 2020, 4:01 AM · debug-info, Restricted Project

Sep 10 2020

ikudrin added a comment to D87008: [DebugInfo] Fix methods of AsmPrinter to emit values corresponding to the DWARF format (1/19)..

Ping (for this and other not yet accepted revisions in the stack).

Sep 10 2020, 1:00 AM · debug-info, Restricted Project

Sep 4 2020

ikudrin updated the diff for D87018: [DebugInfo] Fix emitting DWARF64 DWO compilation units and string offset tables (9/19)..
  • Relaxed checking in the test. The line is a bit longer than I suggested because the test has to validate emitting the abbr_offset field.
Sep 4 2020, 6:50 AM · debug-info, Restricted Project
ikudrin added inline comments to D87018: [DebugInfo] Fix emitting DWARF64 DWO compilation units and string offset tables (9/19)..
Sep 4 2020, 3:09 AM · debug-info, Restricted Project
ikudrin added inline comments to D87018: [DebugInfo] Fix emitting DWARF64 DWO compilation units and string offset tables (9/19)..
Sep 4 2020, 2:19 AM · debug-info, Restricted Project
ikudrin updated the diff for D87019: [DebugInfo] Fix emitting DWARF64 .debug_rnglists sections (13/19)..
  • Updated the test as suggested. Thanks!
Sep 4 2020, 12:03 AM · debug-info, Restricted Project

Sep 3 2020

ikudrin added a comment to D87009: [DebugInfo] Fix DIE value emitters to be compatible with DWARF64 (2/19)..

That would require to update a particular method several times and potentially would leave it in a partially updated state because some code paths are hard to reach.

Could you explain this in more detail?

Sep 3 2020, 6:22 PM · debug-info, Restricted Project
ikudrin added inline comments to D87011: [DebugInfo] Add the -dwarf64 switch to llc and other internal tools (4/19)..
Sep 3 2020, 9:20 AM · debug-info, Restricted Project
ikudrin added inline comments to D87026: [DebugInfo] Make offsets of dwarf units 64-bit (19/19)..
Sep 3 2020, 8:00 AM · debug-info, Restricted Project
ikudrin updated the diff for D87026: [DebugInfo] Make offsets of dwarf units 64-bit (19/19)..
  • Added reporting a fatal error if the generated debug info exceeds the limits supported by the format.
Sep 3 2020, 8:00 AM · debug-info, Restricted Project