createUniqueFile() is documented to create the file in the temporary directory unless it's supplied an absolute path. Make sure the output filepath supplied to createUniqueFile() in HTMLDiagnostics::ReportDiag() is absolute.

[dirty]

Summary

Make sure the output filepath supplied to createUniqueFile() in HTMLDiagnostics::ReportDiag() is absolute.

[dirty]

Ping?

[akyrtzi]

+ Anna

[vsk]

Could you handle the error code coming out of make_absolute? It looks like it calls current_path(), which can fail in interesting ways.

[dirty]

Are you suggesting I change the code to something like the following:

if (std::error_code EC =
    llvm::sys::fs::make_absolute(Model)) {
    llvm::errs() << "warning: could not make '" << Model
                 << "' absolute: " << EC.message() << '\n';
  return;
}

[vsk]

Yes, that looks good.

[dirty]

• Update patch with feedback from vsk: better handle errors from make_absolute().

Updating D12774: createUniqueFile() is documented to create the file in the temporary directory unless it's supplied an absolute path.

Make sure the output filepath supplied to createUniqueFile() in HTMLDiagnostics::ReportDiag() is absolute.

[dirty]

Should I go ahead and commit this change?

[vsk]

LGTM, thanks.

cfe/trunk/lib/StaticAnalyzer/Core/HTMLDiagnostics.cpp

void HTMLDiagnostics::ReportDiag(const PathDiagnostic& D,
   }
 
   // Create a path for the target HTML file.
   int FD;
   SmallString<128> Model, ResultPath;
 
   if (!AnalyzerOpts.shouldWriteStableReportFilename()) {
       llvm::sys::path::append(Model, Directory, "report-%%%%%%.html");
-
+      if (std::error_code EC =
+          llvm::sys::fs::make_absolute(Model)) {
+          llvm::errs() << "warning: could not make '" << Model
+                       << "' absolute: " << EC.message() << '\n';
+        return;
+      }
       if (std::error_code EC =
           llvm::sys::fs::createUniqueFile(Model, FD, ResultPath)) {
           llvm::errs() << "warning: could not create file in '" << Directory
                        << "': " << EC.message() << '\n';
           return;
       }
 
   } else {