This is an archive of the discontinued LLVM Phabricator instance.

Clean up building & linking of Process/elf-core.
ClosedPublic

Authored by brucem on Sep 10 2015, 7:42 AM.

Details

Summary
  • cmake/LLDBDependencies.cmake: elf-core is already included globally in LLDB_USED_LIBS, so it doesn't need to be re-added on individual platforms.
  • lib/Makefile: elf-core is linked on each platform, so move it to the global list of used libraries.
  • source/Plugins/Makefile: elf-core is built on each platform, so move it to the global list of things to build.

Diff Detail

Event Timeline

brucem updated this revision to Diff 34445.Sep 10 2015, 7:42 AM
brucem retitled this revision from to Clean up building & linking of Process/elf-core..
brucem updated this object.
brucem added reviewers: clayborg, labath.
brucem added a subscriber: lldb-commits.
clayborg accepted this revision.Sep 10 2015, 10:48 AM
clayborg edited edge metadata.
This revision is now accepted and ready to land.Sep 10 2015, 10:48 AM
emaste accepted this revision.Sep 10 2015, 4:40 PM
emaste added a reviewer: emaste.
emaste added a subscriber: emaste.

LGTM too

This revision was automatically updated to reflect the committed changes.