Relax restrictions on gold unit tests (run X86 tests if no PPC target)

[thanm]

Summary

permits running of gold unit tests when targeting only x86

[thanm]

FYI -- this is the first patch I've submitted to LLVM, so please bear with me as I learn the procedures (if I'm making any mistakes, please let me know). Thanks --NM

[pcc]

I think the right thing to do here is to split test/tools/gold into two directories (X86 and PowerPC) with a separate lit.local.cfg in each. See for example how the test/LTO directory is set up.

[thanm]

split test/tools/gold into two directories

That sounds like a good suggestion. I'll see about revising the patch...

[thanm]

Split test/tools/gold into PowerPC and X86 subdirectories.

[• rafael]

LGTM

[• rafael]

Sorry for the delay.

I don't seem to be able to apply this:

$ git apply -p0 ~/Downloads/D12322.diff
error: test/tools/gold/PowerPC/lit.local.cfg: No such file or directory
error: test/tools/gold/X86/lit.local.cfg: No such file or directory

$ patch -p0 < ~/Downloads/D12322.diff

Index: test/tools/gold/PowerPC/lit.local.cfg

===================================================================

--- test/tools/gold/PowerPC/lit.local.cfg

+++ test/tools/gold/PowerPC/lit.local.cfg

Can you try emailing a git produced patch directly. Phabricator has
the bad habit of mangling patches.

Cheers,
Rafael

[thanm]

Committed previously as r246328, reviewed/committed by rafael, closing manually.

test/tools/gold/PowerPC/lit.local.cfg

 if (not 'ld_plugin' in  config.available_features or
-    not 'X86' in config.root.targets or
     not 'PowerPC' in config.root.targets):
    config.unsupported = True

test/tools/gold/X86/lit.local.cfg

 if (not 'ld_plugin' in  config.available_features or
-    not 'X86' in config.root.targets or
-    not 'PowerPC' in config.root.targets):
+    not 'X86' in config.root.targets):
    config.unsupported = True