This is an archive of the discontinued LLVM Phabricator instance.

[format] Use int8_t as the underlying type of all enums in FormatStyle
ClosedPublic

Authored by kwk on Mar 3 2022, 2:58 AM.

Details

Summary

It was requested here (https://reviews.llvm.org/D120398#3353053) to make
the underlying type of all enums in FormatStyle an int8_t.

Originally the type was changed in https://reviews.llvm.org/D93758.

Diff Detail

Event Timeline

kwk created this revision.Mar 3 2022, 2:58 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 3 2022, 2:58 AM
kwk requested review of this revision.Mar 3 2022, 2:58 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 3 2022, 2:58 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
owenpan accepted this revision.Mar 3 2022, 3:07 AM
This revision is now accepted and ready to land.Mar 3 2022, 3:07 AM
HazardyKnusperkeks added a project: Restricted Project.Mar 3 2022, 3:48 AM

Please use the clang-format tag.

kwk added a comment.Mar 3 2022, 3:54 AM

Please use the clang-format tag.

Yes, sorry that I forgot it again. And thank you for approving. Shall I wait for the others to approve this or land the patch?

Please use the clang-format tag.

Yes, sorry that I forgot it again. And thank you for approving. Shall I wait for the others to approve this or land the patch?

I myself give patches always some time. Others commit nearly as soon as possible.
I would say you can land it, but maybe wait a day, to see if someone might object.

kwk updated this revision to Diff 416970.Mar 21 2022, 8:45 AM

Rebased

kwk updated this revision to Diff 417044.Mar 21 2022, 12:07 PM

Fixup my work after interruption by screaming children wanting dinner ;)

This is how I've tested this patch:

ninja clang-format && ninja FormatTests && ./tools/clang/unittests/Format/FormatTests
kwk added a comment.Mar 21 2022, 12:10 PM

@HazardyKnusperkeks @owenpan can you please have a quick look again. All I did was rebasing my changes and in the meantime I was interrupted... This patch has been sitting for some time and I'd like to land it as soon one of you approves it.

curdeius accepted this revision.Mar 21 2022, 1:16 PM