This is an archive of the discontinued LLVM Phabricator instance.

[clang][tests] Fix ve-toolchain tests with CLANG_DEFAULT_UNWINDLIB
ClosedPublic

Authored by tbaeder on Feb 27 2022, 10:49 PM.

Details

Summary

Otherwise, the

// DEF-SAME: "[[RESOURCE_DIR]]/lib/linux/libclang_rt.builtins-ve.a" "-lc"

line ends up getting a -lgcc_s inserted in between and the output doesn't match anymore.
Also fix a -stdlib=c++ now that I'm already looking at it.

Diff Detail

Event Timeline

tbaeder requested review of this revision.Feb 27 2022, 10:49 PM
tbaeder created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 27 2022, 10:49 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript

The failing tests seem all omp related and not about this change.

simoll accepted this revision.Feb 28 2022, 5:22 AM

LGTM. For the record, this is related to the issues with the -fuse-ld option in that a cmake flag globally overrides a toolchain default: https://reviews.llvm.org/D115045.

This revision is now accepted and ready to land.Feb 28 2022, 5:22 AM
This revision was landed with ongoing or failed builds.Feb 28 2022, 5:56 AM
This revision was automatically updated to reflect the committed changes.