This is an archive of the discontinued LLVM Phabricator instance.

[sanitizer][sancov] Use pc-1 for s390x
ClosedPublic

Authored by MaskRay on Feb 23 2022, 12:49 PM.

Details

Summary

The stack trace addresses may be odd (normally addresses should be even), but
seems a good compromise when the instruction length (2,4,6) cannot be detected
easily.

Diff Detail

Event Timeline

MaskRay requested review of this revision.Feb 23 2022, 12:49 PM
MaskRay created this revision.
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptFeb 23 2022, 12:49 PM
Herald added subscribers: llvm-commits, Restricted Project. · View Herald Transcript
uweigand accepted this revision.Feb 23 2022, 12:54 PM

See inline comment. Otherwise LGTM. Thanks for the quick fix.

compiler-rt/test/tsan/test.h
73

Comment doesn't match the code any more.

This revision is now accepted and ready to land.Feb 23 2022, 12:54 PM
This revision was landed with ongoing or failed builds.Feb 23 2022, 1:35 PM
This revision was automatically updated to reflect the committed changes.