This is an archive of the discontinued LLVM Phabricator instance.

CodeGen: Introduce CodeGenModule::CreateMetadataIdentifierForType.
ClosedPublic

Authored by pcc on Aug 14 2015, 12:02 PM.

Details

Diff Detail

Event Timeline

pcc updated this revision to Diff 32173.Aug 14 2015, 12:02 PM
pcc retitled this revision from to CodeGen: Introduce CodeGenModule::CreateMetadataIdentifierForType..
pcc updated this object.
pcc added a reviewer: rsmith.
pcc added subscribers: cfe-commits, Prazek.
Prazek added inline comments.Aug 17 2015, 9:01 PM
lib/CodeGen/CodeGenModule.cpp
3677

question: so You are storing distinct and normal mdnodes here. Is it faster to grap normal node from this map than to just create new one using get?

pcc added inline comments.Aug 17 2015, 9:21 PM
lib/CodeGen/CodeGenModule.cpp
3677

Quite possibly (the latter involves string comparisons and possibly memory allocation) but they should both have the same complexity so it doesn't matter much.

rsmith accepted this revision.Sep 8 2015, 12:52 PM
rsmith edited edge metadata.

This seems fine to me.

This revision is now accepted and ready to land.Sep 8 2015, 12:52 PM
This revision was automatically updated to reflect the committed changes.