This is an archive of the discontinued LLVM Phabricator instance.

[Sanitizers][test] XFAIL long double tests on Solaris/sparc
ClosedPublic

Authored by ro on Feb 4 2022, 9:44 AM.

Details

Summary

As reported in Issue #41838, clang doesn't correctly implement long double on 32-bit Solaris/SPARC: the psABI requires this to be an 128-bit type. Four sanitizer tests currently FAIL for this reason.

While there is a WIP patch to fix clang (D89130), it isn't complete yet and I've hit so many brick walls while trying to finish it that I'm unsure if I ever will.

This patch therefore XFAILs those tests in the meantime.

Tested on sparcv9-sun-solaris2.11.

There's one issue, though: when running a 1-stage build with gcc (which doesn't have this bug), two of the tests XPASS. I'd like to XFAIL them only for clang and see several tests using a clang keyword with XFAIL, but this doesn't work in compiler-rt and I haven't yet found how to do this.

Diff Detail

Event Timeline

ro created this revision.Feb 4 2022, 9:44 AM
ro requested review of this revision.Feb 4 2022, 9:44 AM
Herald added a subscriber: Restricted Project. · View Herald TranscriptFeb 4 2022, 9:44 AM
vitalybuka accepted this revision.Feb 8 2022, 12:56 PM
This revision is now accepted and ready to land.Feb 8 2022, 12:56 PM
This revision was landed with ongoing or failed builds.Feb 9 2022, 12:20 AM
This revision was automatically updated to reflect the committed changes.