Page MenuHomePhabricator

ro (Rainer Orth)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 1 2016, 4:12 AM (229 w, 3 d)

Recent Activity

Today

ro updated the diff for D91605: [sanitizers] Implement GetTls on Solaris.
  • Move declarations to new sanitizer_solaris.h.
  • Augment check_linker_flag do reject unknown -z options that GNU ld noisily accepts.
Mon, Nov 23, 6:42 AM · Restricted Project, Restricted Project, Restricted Project
ro added inline comments to D91605: [sanitizers] Implement GetTls on Solaris.
Mon, Nov 23, 6:39 AM · Restricted Project, Restricted Project, Restricted Project

Fri, Nov 20

ro committed rG03d593dd7e6d: [sanitizers][test] Test sanitizer_common and ubsan_minimal on Solaris (authored by ro).
[sanitizers][test] Test sanitizer_common and ubsan_minimal on Solaris
Fri, Nov 20, 5:07 AM
ro closed D91606: [sanitizers][test] Test sanitizer_common and ubsan_minimal on Solaris.
Fri, Nov 20, 5:07 AM · Restricted Project
ro updated the diff for D91606: [sanitizers][test] Test sanitizer_common and ubsan_minimal on Solaris.

getpass.cpp changed to UNSUPPORTED.

Fri, Nov 20, 5:03 AM · Restricted Project
ro added inline comments to D91606: [sanitizers][test] Test sanitizer_common and ubsan_minimal on Solaris.
Fri, Nov 20, 5:02 AM · Restricted Project
ro committed rG0f69cbe2694a: [sanitizer_common][test] Disable CombinedAllocator32Compact etc. on… (authored by ro).
[sanitizer_common][test] Disable CombinedAllocator32Compact etc. on…
Fri, Nov 20, 4:03 AM
ro closed D91622: [sanitizer_common][test] Disable CombinedAllocator32Compact etc. on Solaris/sparcv9.
Fri, Nov 20, 4:02 AM · Restricted Project
ro updated the diff for D91622: [sanitizer_common][test] Disable CombinedAllocator32Compact etc. on Solaris/sparcv9.
  • Switch disablement to SKIP_ON_* form.
  • Add FIXME comment.
Fri, Nov 20, 3:59 AM · Restricted Project
ro committed rGce6524d127d4: [sanitizer_common][test] Disable FastUnwindTest.* on SPARC (authored by ro).
[sanitizer_common][test] Disable FastUnwindTest.* on SPARC
Fri, Nov 20, 3:53 AM
ro closed D91618: [sanitizer_common][test] Disable FastUnwindTest.* on SPARC.
Fri, Nov 20, 3:52 AM · Restricted Project
ro updated the diff for D91618: [sanitizer_common][test] Disable FastUnwindTest.* on SPARC.

Only disable actually failing tests using the SKIP_ON_* form.

Fri, Nov 20, 2:46 AM · Restricted Project
ro added inline comments to D91618: [sanitizer_common][test] Disable FastUnwindTest.* on SPARC.
Fri, Nov 20, 2:42 AM · Restricted Project
ro added inline comments to D91605: [sanitizers] Implement GetTls on Solaris.
Fri, Nov 20, 1:52 AM · Restricted Project, Restricted Project, Restricted Project

Thu, Nov 19

ro added inline comments to D91605: [sanitizers] Implement GetTls on Solaris.
Thu, Nov 19, 2:26 AM · Restricted Project, Restricted Project, Restricted Project
ro added a comment to D91617: [sanitizer_common][test] Disable CompactRingBuffer.int64 on Solaris/sparcv9.

Very interesting, thank you for the explanation.
It looks like this can be fixed by applying sign extension to the masked address?

Thu, Nov 19, 2:07 AM · Restricted Project

Wed, Nov 18

ro added inline comments to D91606: [sanitizers][test] Test sanitizer_common and ubsan_minimal on Solaris.
Wed, Nov 18, 7:15 AM · Restricted Project
ro added a comment to D91617: [sanitizer_common][test] Disable CompactRingBuffer.int64 on Solaris/sparcv9.

Does it mean CompactRingBuffer is broken, or just the test?

Wed, Nov 18, 6:58 AM · Restricted Project
ro added inline comments to D91618: [sanitizer_common][test] Disable FastUnwindTest.* on SPARC.
Wed, Nov 18, 6:38 AM · Restricted Project
ro added inline comments to D91620: [compiler-rt][test] Heed COMPILER_RT_DEBUG when compiling unittests.
Wed, Nov 18, 6:04 AM · Restricted Project
ro added a comment to D91622: [sanitizer_common][test] Disable CombinedAllocator32Compact etc. on Solaris/sparcv9.

Have you tried to change kAddressSpaceSize above?

Wed, Nov 18, 5:37 AM · Restricted Project
ro added inline comments to D91605: [sanitizers] Implement GetTls on Solaris.
Wed, Nov 18, 12:40 AM · Restricted Project, Restricted Project, Restricted Project

Tue, Nov 17

ro requested review of D91622: [sanitizer_common][test] Disable CombinedAllocator32Compact etc. on Solaris/sparcv9.
Tue, Nov 17, 5:12 AM · Restricted Project
ro requested review of D91620: [compiler-rt][test] Heed COMPILER_RT_DEBUG when compiling unittests.
Tue, Nov 17, 4:57 AM · Restricted Project
ro requested review of D91618: [sanitizer_common][test] Disable FastUnwindTest.* on SPARC.
Tue, Nov 17, 4:49 AM · Restricted Project
ro requested review of D91617: [sanitizer_common][test] Disable CompactRingBuffer.int64 on Solaris/sparcv9.
Tue, Nov 17, 4:42 AM · Restricted Project
ro requested review of D91615: [sanitizer_common] Don't try to unmap unaligned memory.
Tue, Nov 17, 4:35 AM · Restricted Project
ro requested review of D91608: [sanitizer_common][test] Enable tests on SPARC.
Tue, Nov 17, 3:23 AM · Restricted Project
ro requested review of D91607: [clang][Sparc] Fix __builtin_extract_return_addr etc..
Tue, Nov 17, 3:12 AM · Restricted Project
ro requested review of D91606: [sanitizers][test] Test sanitizer_common and ubsan_minimal on Solaris.
Tue, Nov 17, 2:58 AM · Restricted Project
ro requested review of D91605: [sanitizers] Implement GetTls on Solaris.
Tue, Nov 17, 2:28 AM · Restricted Project, Restricted Project, Restricted Project

Fri, Nov 13

ro added a comment to D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux.
Fri, Nov 13, 5:48 AM · Restricted Project
ro added a comment to D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux.
Fri, Nov 13, 5:42 AM · Restricted Project
ro added a comment to D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux.
In D90524#2393320, @ro wrote:

Ping. It would be nice to get this finally merged so that the testsuite noise finally goes down on the sparc64 Linux worker.

Please be a little more patient: one ping a week is considered appropriate, but after only two days is a bit over the top.

The problem is that LLVM is a very fast moving target and when waiting long for changes to be merged, one constantly runs
into the risk of having to rebase patches.

Fri, Nov 13, 4:39 AM · Restricted Project
ro abandoned D85582: [clang][Driver] Search lib32 on Linux/sparc64 with -m32.

Superceded by D90524.

Fri, Nov 13, 4:37 AM · Restricted Project
ro resigned from D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux.
In D90524#2393319, @ro wrote:

I think it should be good for merging now. I addressed all remarks. I'm still convinced that "workaround" is the proper term though.

Quite the contrary: the comment you cited

// FIXME: This is a bit of a hack. We should really unify this code for
// reasoning about oslibdir spellings with the lib dir spellings in the
// GCCInstallationDetector, but that is a more significant refactoring.

pretty clearly is about how/where support for that layout is implemented in the clang Driver code, not about the layout itself.

I don't understand that argument. I call it "workaround", the source comment calls it "hack". It's clearly not to stay forever as it's an ugly
workaround, but until a proper fix comes around, I would like to add "sparc" here as well so the testsuite failures drop from over
400 to just below 70.

Fri, Nov 13, 4:36 AM · Restricted Project
ro added a comment to D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux.

Ping. It would be nice to get this finally merged so that the testsuite noise finally goes down on the sparc64 Linux worker.

Fri, Nov 13, 1:51 AM · Restricted Project
ro added a comment to D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux.

I think it should be good for merging now. I addressed all remarks. I'm still convinced that "workaround" is the proper term though.

Fri, Nov 13, 1:50 AM · Restricted Project

Mon, Nov 9

ro added a comment to D90549: [Driver] Switch CHECK-DEBIAN-SPARC tests to use debian_multiarch_tree.

As I'd mentioned in D90524, I believe both patches should be merged into one. Otherwise, no matter in which order you commit them, the buildbots might show failures otherwise.

Mon, Nov 9, 5:39 AM · Restricted Project
ro added a comment to D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux.

As it happens, I'd arrived at exactly the same patch when I tried a build on a Debian/sparc64 system in the GCC compile farm (gcc202), submitted as D85582.

Mon, Nov 9, 5:36 AM · Restricted Project

Oct 14 2020

ro committed rG3b956a58f3c5: Reland "[Support][unittests] Enforce alignment in ConvertUTFTest" (authored by ro).
Reland "[Support][unittests] Enforce alignment in ConvertUTFTest"
Oct 14 2020, 3:03 AM
ro closed D88824: [Support][unittests] Enforce alignment in ConvertUTFTest.
Oct 14 2020, 3:03 AM · Restricted Project

Oct 13 2020

ro updated the diff for D88824: [Support][unittests] Enforce alignment in ConvertUTFTest.

Align the last affected instance.

Oct 13 2020, 2:21 AM · Restricted Project
ro added a comment to D88824: [Support][unittests] Enforce alignment in ConvertUTFTest.
In D88824#2325457, @rnk wrote:

I may have been the one that picked ArrayRef<char> as the parameter type here, and I think what I was thinking is: "files are full of bytes, the caller is most likely to have a bag of bytes that they want to hand to the re-encoding routine, so it should accept bytes, and I'll pick some arbitrary byte-like character type here". For example, MemoryBuffer gives you back a StringRef for the file contents, and you should be able to just plug that in here. MemoryBuffer probably happens to return aligned file contents in practice, but it doesn't advertise any alignment guarantee. So maybe the best fix is to underalign the UTF16 typedef, if that's possible. This is a serialization routine, after all: it should be really generous about what it accepts.

Oct 13 2020, 2:20 AM · Restricted Project

Oct 9 2020

ro requested review of D89130: [WIP][Sparc] Fix long double on 32-bit Solaris/SPARC.
Oct 9 2020, 7:03 AM · Restricted Project, Restricted Project, Restricted Project

Oct 8 2020

ro added a comment to D85630: [cmake] Don't build with -O3 -fPIC on Solaris/sparcv9.

What about reverting this now that you have found this is an issue with the Sun linker?

Oct 8 2020, 1:44 AM · Restricted Project
ro added a comment to D88824: [Support][unittests] Enforce alignment in ConvertUTFTest.

Why are we trying to enforce alignment like this in the first place? Writing an API that expects an overaligned ArrayRef<char> is just asking for trouble. There should be two possibilities:

Oct 8 2020, 1:39 AM · Restricted Project
ro added a comment to D88824: [Support][unittests] Enforce alignment in ConvertUTFTest.

This breaks tests on Windows: http://45.33.8.238/win/25377/step_11.txt

PTAL, and if it takes a while to fix please revert while you investigate.

Oct 8 2020, 1:36 AM · Restricted Project

Oct 7 2020

ro committed rG53b3873cf428: [Support][unittests] Enforce alignment in ConvertUTFTest (authored by ro).
[Support][unittests] Enforce alignment in ConvertUTFTest
Oct 7 2020, 12:09 AM
ro closed D88824: [Support][unittests] Enforce alignment in ConvertUTFTest.
Oct 7 2020, 12:09 AM · Restricted Project

Oct 6 2020

ro updated the diff for D88824: [Support][unittests] Enforce alignment in ConvertUTFTest.

Use alignas.

Oct 6 2020, 1:29 PM · Restricted Project
ro added inline comments to D88824: [Support][unittests] Enforce alignment in ConvertUTFTest.
Oct 6 2020, 1:28 PM · Restricted Project

Oct 5 2020

ro added inline comments to D88824: [Support][unittests] Enforce alignment in ConvertUTFTest.
Oct 5 2020, 6:43 AM · Restricted Project
ro updated the diff for D88824: [Support][unittests] Enforce alignment in ConvertUTFTest.

Add assertion.
Run clang-format.

Oct 5 2020, 6:07 AM · Restricted Project
ro requested review of D88826: [builtins] Work around long double return bug on Solaris/sparcv9.
Oct 5 2020, 5:06 AM · Restricted Project
ro requested review of D88824: [Support][unittests] Enforce alignment in ConvertUTFTest.
Oct 5 2020, 4:25 AM · Restricted Project

Sep 30 2020

ro committed rG8a1084a94863: [asan][test] XFAIL Posix/no_asan_gen_globals.c on Solaris (authored by ro).
[asan][test] XFAIL Posix/no_asan_gen_globals.c on Solaris
Sep 30 2020, 1:59 PM
ro closed D88218: [asan][test] XFAIL Posix/no_asan_gen_globals.c on Solaris.
Sep 30 2020, 1:59 PM · Restricted Project
ro added a comment to D88218: [asan][test] XFAIL Posix/no_asan_gen_globals.c on Solaris.

Ping? It's been almost a week.

Sep 30 2020, 11:00 AM · Restricted Project
ro committed rG73fb9698c057: [asan][test] Several Posix/unpoison-alternate-stack.cpp fixes (authored by ro).
[asan][test] Several Posix/unpoison-alternate-stack.cpp fixes
Sep 30 2020, 9:57 AM
ro closed D88501: [asan][test] Several Posix/unpoison-alternate-stack.cpp fixes.
Sep 30 2020, 9:57 AM · Restricted Project
ro committed rGdc261d23d07c: [sanitizers] Fix internal__exit on Solaris (authored by ro).
[sanitizers] Fix internal__exit on Solaris
Sep 30 2020, 7:31 AM
ro closed D88404: [sanitizers] Fix internal__exit on Solaris.
Sep 30 2020, 7:31 AM · Restricted Project
ro added inline comments to D88501: [asan][test] Several Posix/unpoison-alternate-stack.cpp fixes.
Sep 30 2020, 7:03 AM · Restricted Project
ro added a comment to D88470: [clangd] Extract options struct for ClangdLSPServer. NFC.

This patch broke builds with gcc, e.g. Builder clang-solaris11-amd64 Build #6724:

[23/122] Building CXX object tools/clang/tools/extra/clangd/tool/CMakeFiles/clangd.dir/ClangdMain.cpp.o
FAILED: tools/clang/tools/extra/clangd/tool/CMakeFiles/clangd.dir/ClangdMain.cpp.o 
/usr/gcc/9/bin/c++  -DGTEST_HAS_RTTI=0 -D_DEBUG -D_FILE_OFFSET_BITS=64 -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Itools/clang/tools/extra/clangd/tool -I/opt/llvm-buildbot/home/solaris11-amd64/clang-solaris11-amd64/llvm/clang-tools-extra/clangd/tool -Itools/clang/tools/extra/clangd/../clang-tidy -I/opt/llvm-buildbot/home/solaris11-amd64/clang-solaris11-amd64/llvm/clang/include -Itools/clang/include -Iinclude -I/opt/llvm-buildbot/home/solaris11-amd64/clang-solaris11-amd64/llvm/llvm/include -I/opt/llvm-buildbot/home/solaris11-amd64/clang-solaris11-amd64/llvm/llvm/include/llvm/Support/Solaris -I/opt/llvm-buildbot/home/solaris11-amd64/clang-solaris11-amd64/llvm/clang-tools-extra/clangd/tool/.. -Itools/clang/tools/extra/clangd/tool/.. -Itools/clang/tools/extra/clangd -fPIC -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-maybe-uninitialized -Wno-class-memaccess -Wno-redundant-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -fdiagnostics-color -ffunction-sections -fdata-sections -fno-common -Woverloaded-virtual -fno-strict-aliasing -O3     -fno-exceptions -fno-rtti -UNDEBUG -std=c++14 -MD -MT tools/clang/tools/extra/clangd/tool/CMakeFiles/clangd.dir/ClangdMain.cpp.o -MF tools/clang/tools/extra/clangd/tool/CMakeFiles/clangd.dir/ClangdMain.cpp.o.d -o tools/clang/tools/extra/clangd/tool/CMakeFiles/clangd.dir/ClangdMain.cpp.o -c /opt/llvm-buildbot/home/solaris11-amd64/clang-solaris11-amd64/llvm/clang-tools-extra/clangd/tool/ClangdMain.cpp
In file included from /opt/llvm-buildbot/home/solaris11-amd64/clang-solaris11-amd64/llvm/clang-tools-extra/clangd/tool/ClangdMain.cpp:9:
/opt/llvm-buildbot/home/solaris11-amd64/clang-solaris11-amd64/llvm/clang-tools-extra/clangd/tool/../ClangdLSPServer.h:47:36: error: declaration of ‘llvm::Optional<clang::clangd::OffsetEncoding> clang::clangd::ClangdLSPServer::Options::OffsetEncoding’ changes meaning of ‘OffsetEncoding’ [-fpermissive]
   47 |     llvm::Optional<OffsetEncoding> OffsetEncoding;
      |                                    ^~~~~~~~~~~~~~
In file included from /opt/llvm-buildbot/home/solaris11-amd64/clang-solaris11-amd64/llvm/clang-tools-extra/clangd/tool/../Headers.h:12,
                 from /opt/llvm-buildbot/home/solaris11-amd64/clang-solaris11-amd64/llvm/clang-tools-extra/clangd/tool/../CodeComplete.h:19,
                 from /opt/llvm-buildbot/home/solaris11-amd64/clang-solaris11-amd64/llvm/clang-tools-extra/clangd/tool/../ClangdServer.h:13,
                 from /opt/llvm-buildbot/home/solaris11-amd64/clang-solaris11-amd64/llvm/clang-tools-extra/clangd/tool/../ClangdLSPServer.h:12,
                 from /opt/llvm-buildbot/home/solaris11-amd64/clang-solaris11-amd64/llvm/clang-tools-extra/clangd/tool/ClangdMain.cpp:9:
/opt/llvm-buildbot/home/solaris11-amd64/clang-solaris11-amd64/llvm/clang-tools-extra/clangd/tool/../Protocol.h:370:12: note: ‘OffsetEncoding’ declared here as ‘enum class clang::clangd::OffsetEncoding’
  370 | enum class OffsetEncoding {
      |            ^~~~~~~~~~~~~~
Sep 30 2020, 2:12 AM · Restricted Project

Sep 29 2020

ro requested review of D88501: [asan][test] Several Posix/unpoison-alternate-stack.cpp fixes.
Sep 29 2020, 10:10 AM · Restricted Project

Sep 28 2020

ro requested review of D88404: [sanitizers] Fix internal__exit on Solaris.
Sep 28 2020, 4:58 AM · Restricted Project

Sep 24 2020

ro requested review of D88218: [asan][test] XFAIL Posix/no_asan_gen_globals.c on Solaris.
Sep 24 2020, 4:59 AM · Restricted Project
ro committed rG15c9af5618c8: [asan][test] Disable malloc-no-intercept.c on Solaris (authored by ro).
[asan][test] Disable malloc-no-intercept.c on Solaris
Sep 24 2020, 3:00 AM
ro closed D87898: [asan][test] Disable malloc-no-intercept.c on Solaris.
Sep 24 2020, 2:59 AM · Restricted Project
ro added inline comments to D87898: [asan][test] Disable malloc-no-intercept.c on Solaris.
Sep 24 2020, 2:57 AM · Restricted Project

Sep 20 2020

ro committed rG26947d7b6380: [tools][remarks-shlib] Don't build libRemarks.so without PIC (authored by ro).
[tools][remarks-shlib] Don't build libRemarks.so without PIC
Sep 20 2020, 3:41 AM
ro closed D85626: [tools][remarks-shlib] Don't build libRemarks.so without PIC.
Sep 20 2020, 3:41 AM · Restricted Project
ro added inline comments to D85626: [tools][remarks-shlib] Don't build libRemarks.so without PIC.
Sep 20 2020, 3:39 AM · Restricted Project

Sep 18 2020

ro added inline comments to D85626: [tools][remarks-shlib] Don't build libRemarks.so without PIC.
Sep 18 2020, 7:17 AM · Restricted Project
ro updated the diff for D85626: [tools][remarks-shlib] Don't build libRemarks.so without PIC.

Wrap whole file in if(LLVM_ENABLE_PIC).

Sep 18 2020, 7:08 AM · Restricted Project
ro requested review of D87898: [asan][test] Disable malloc-no-intercept.c on Solaris.
Sep 18 2020, 5:21 AM · Restricted Project

Sep 17 2020

ro abandoned D87825: [ASTMatchers] Define clang::ast_matchers::decompositionDecl.

Just found this had already been fixed in commit f0546173fa4bdde03ecb21a174fcaa8a6490adbd.

Sep 17 2020, 4:31 AM · Restricted Project
ro added a comment to D87588: [ASTMatchers] extract public matchers from const-analysis into own patch.

As described in D87825, this patch broke Debug builds on sparcv9-sun-solaris2.11 and amd64-pc-solaris2.11.

Sep 17 2020, 4:08 AM · Restricted Project
ro requested review of D87825: [ASTMatchers] Define clang::ast_matchers::decompositionDecl.
Sep 17 2020, 4:07 AM · Restricted Project
ro committed rGa9cbe5cf30e3: [X86] Fix stack alignment on 32-bit Solaris/x86 (authored by ro).
[X86] Fix stack alignment on 32-bit Solaris/x86
Sep 17 2020, 2:18 AM
ro closed D87615: [X86] Fix stack alignment on 32-bit Solaris/x86.
Sep 17 2020, 2:18 AM · Restricted Project, Restricted Project, Restricted Project
ro added a comment to D87615: [X86] Fix stack alignment on 32-bit Solaris/x86.

This patch avoid the issue by defaulting to -mstackrealign, just like gcc.

This sentence from the description should be removed.

Sep 17 2020, 2:10 AM · Restricted Project, Restricted Project, Restricted Project
ro added a comment to D87615: [X86] Fix stack alignment on 32-bit Solaris/x86.

I'm still curious about the source of the vptr diff, but that's a minor question, otherwise. LGTM

Sep 17 2020, 2:08 AM · Restricted Project, Restricted Project, Restricted Project

Sep 16 2020

ro added a comment to D87615: [X86] Fix stack alignment on 32-bit Solaris/x86.

Also, it would be nice to have some regression test coverage; add a Solaris RUN line to llvm/test/CodeGen/X86/stack-align2.ll ?

Sep 16 2020, 4:02 AM · Restricted Project, Restricted Project, Restricted Project
ro updated the diff for D87615: [X86] Fix stack alignment on 32-bit Solaris/x86.
  • Rely on stackAlignment default for 32-bit Solaris/x86
  • Handle Solaris in llvm/test/CodeGen/X86/stack-align2.ll
Sep 16 2020, 4:00 AM · Restricted Project, Restricted Project, Restricted Project

Sep 15 2020

ro updated the diff for D87615: [X86] Fix stack alignment on 32-bit Solaris/x86.

Allow for whitespace differences in vptr.cpp.

Sep 15 2020, 2:31 AM · Restricted Project, Restricted Project, Restricted Project
ro updated subscribers of D87615: [X86] Fix stack alignment on 32-bit Solaris/x86.
In D87615#2273427, @ro wrote:
Sep 15 2020, 2:28 AM · Restricted Project, Restricted Project, Restricted Project
ro updated the diff for D87615: [X86] Fix stack alignment on 32-bit Solaris/x86.

Tested on amd64-pc-solaris2.11. However, compared to the -mstackrealign version
there's one regression that I still need to investigate:

UBSan-Standalone-i386 :: TestCases/TypeCheck/vptr.cpp
Sep 15 2020, 1:42 AM · Restricted Project, Restricted Project, Restricted Project
ro added a comment to D87615: [X86] Fix stack alignment on 32-bit Solaris/x86.

That claim of 16-byte alignment on Solaris is half-wrong: it's definitely wrong on Solaris, but seems to be true on Illumos.

Sep 15 2020, 1:35 AM · Restricted Project, Restricted Project, Restricted Project
ro added a comment to D87615: [X86] Fix stack alignment on 32-bit Solaris/x86.
Sep 15 2020, 1:27 AM · Restricted Project, Restricted Project, Restricted Project

Sep 14 2020

ro added a comment to D87615: [X86] Fix stack alignment on 32-bit Solaris/x86.

Would it be possible to add some tests?

Sep 14 2020, 8:37 AM · Restricted Project, Restricted Project, Restricted Project
ro requested review of D87615: [X86] Fix stack alignment on 32-bit Solaris/x86.
Sep 14 2020, 7:55 AM · Restricted Project, Restricted Project, Restricted Project

Sep 11 2020

ro committed rG76e85ae268f8: [clang][Sparc] Default to -mcpu=v9 for Sparc V8 on Solaris (authored by ro).
[clang][Sparc] Default to -mcpu=v9 for Sparc V8 on Solaris
Sep 11 2020, 12:54 AM
ro closed D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris.
Sep 11 2020, 12:54 AM · Restricted Project, Restricted Project

Sep 10 2020

ro added a comment to D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris.

Ping? It's been a week and AFAICT there's nothing left for me to do.

Sep 10 2020, 4:25 PM · Restricted Project, Restricted Project

Sep 4 2020

ro added a comment to D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris.

Is there anything left to do to get approval? Thanks.

Sep 4 2020, 2:06 AM · Restricted Project, Restricted Project

Sep 3 2020

ro updated the diff for D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris.

Add FIXME for SparcV8 MaxAtomicInlineWidth.

Sep 3 2020, 1:45 AM · Restricted Project, Restricted Project

Sep 2 2020

ro added inline comments to D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris.
Sep 2 2020, 12:00 PM · Restricted Project, Restricted Project
ro added a comment to D85415: [Sparc] Don't use SunStyleELFSectionSwitchSyntax.

I've now discovered that not only the sparc assembler output requires GNU as, but the same is true for x86:

  • as is invoked without -m64/-m32, thus chokes on amd64 insns since it default to 32-bit mode
  • Even if adding -Wa,-m64, assembly fails:
Assembler: main.c
	"/var/tmp/main-faae1e.s", line 24 : Syntax error
	Near line: "	.section	".note.GNU-stack","",@progbits"
  • There must be no double quotes around the section name.
  • Without the quotes, the section name is no valid identifier: - isn't allowed.
  • On top of that, Solaris doesn't care about those .note sections: to achieve non-executable stacks, you need e.g. ld -z sx=nxstack (Solaris 11.4) or ld -z nxstack (Solaris 11.3).
Sep 2 2020, 4:00 AM · Restricted Project