This is an archive of the discontinued LLVM Phabricator instance.

Small fixes to platform packet documentation
ClosedPublic

Authored by jasonmolenda on Feb 2 2022, 12:52 PM.

Details

Summary

I have a standalone implementation of the lldb platform packets for Darwin systems, and in the process of updating it to match the fixes from Michał in https://reviews.llvm.org/D107475 , I found a few places where the documentation needed to be updated to match lldb/gdb's actual behavior.

Diff Detail

Event Timeline

jasonmolenda created this revision.Feb 2 2022, 12:52 PM
jasonmolenda requested review of this revision.Feb 2 2022, 12:52 PM

FWIW I started updating my implementation by reading through all the changes to the docs, and implementing them. Then I went back and looked at the patches and found some small changes that were made but without documentation being updated, or the documentation not being specific about expected details.

This revision was not accepted when it landed; it landed in state Needs Review.Feb 7 2022, 11:52 PM
This revision was automatically updated to reflect the committed changes.