This is an archive of the discontinued LLVM Phabricator instance.

[libunwind][cmake] Create `LIBUNWIND_INSTALL_INCLUDE_DIR` CACHE PATH
ClosedPublic

Authored by Ericson2314 on Jan 8 2022, 4:12 PM.

Details

Summary

This is created on analogy with the other CACHE PATHs in this package,
and other *_INSTALL_INCLUDE_DIR in other packages.

The branching is adjusted to deduplicate some existing code, and
likewise avoid having to define this new variable more than once.

This will be used for D99484.

Diff Detail

Event Timeline

Ericson2314 created this revision.Jan 8 2022, 4:12 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 8 2022, 4:12 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Ericson2314 requested review of this revision.Jan 8 2022, 4:12 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 8 2022, 4:12 PM
Ericson2314 edited the summary of this revision. (Show Details)Jan 8 2022, 5:10 PM

Fix issue with header

compnerd accepted this revision.Jan 10 2022, 8:44 AM
compnerd added a subscriber: compnerd.
compnerd added inline comments.
libunwind/CMakeLists.txt
165

A newline before this would be nice.

168

Perhaps it makes sense to use CMAKE_INSTALL_INCLUDEDIR and CMAKE_INSTALL_BINDIR to initialize the values? That will allow the standard configuration paths to fold into this. We could make these "advanced" and encourage users to prefer those (but retain these for the runtimes build configuration).

This revision is now accepted and ready to land.Jan 10 2022, 8:44 AM
Ericson2314 added inline comments.Jan 10 2022, 1:29 PM
libunwind/CMakeLists.txt
168

I was saving that for the original D99484. I've been told baby step patches is the norm, so baby steps it is!

Add requested blank line

Ericson2314 marked an inline comment as done.Jan 10 2022, 1:30 PM
This revision was landed with ongoing or failed builds.Jan 10 2022, 1:32 PM
This revision was automatically updated to reflect the committed changes.