I checked this patch on my own build on RHEL 6. Regressions were OK.
Please check it in if it's OK, because I don't have SVN write access.
Paths
| Differential D11548
[LLVM] Fix Clang-tidy llvm-namespace-comment warnings AbandonedPublic Authored by Eugene.Zelenko on Jul 27 2015, 6:26 PM.
Details
Summary I checked this patch on my own build on RHEL 6. Regressions were OK. Please check it in if it's OK, because I don't have SVN write access.
Diff Detail Event TimelineEugene.Zelenko retitled this revision from to [LLVM] Fix Clang-tidy llvm-namespace-comment warnings. Eugene.Zelenko updated this object. Comment Actions I'm not sure this kind of clean-up is worth the effort. Some of these are kind of nice as consistency improvements, but many seem redundant; for example a short namespace such as 'object' in include/llvm/ExecutionEngine/RuntimeDyld.h which only contains two declarations probably doesn't need a comment. Same goes for http://reviews.llvm.org/D11549. Comment Actions I think it's better to place comments consistently independently from number of declarations in namespace. At least Clang-tidy llvm-namespace-comment will be happy and will not complain on same part of code in future. Comment Actions Apparently, the check is not completely aligned with the preferences of the I already submitted a cleanup patch for this check once (r240270), but had
Revision Contents
Diff 30770 llvm-svn.src/include/llvm/ADT/APInt.h
llvm-svn.src/include/llvm/ADT/ArrayRef.h
llvm-svn.src/include/llvm/ADT/DenseMap.h
llvm-svn.src/include/llvm/ADT/DenseSet.h
llvm-svn.src/include/llvm/ADT/None.h
llvm-svn.src/include/llvm/ADT/Optional.h
llvm-svn.src/include/llvm/ADT/PointerUnion.h
llvm-svn.src/include/llvm/ADT/STLExtras.h
llvm-svn.src/include/llvm/ADT/SetVector.h
llvm-svn.src/include/llvm/ADT/SmallPtrSet.h
llvm-svn.src/include/llvm/ADT/SmallString.h
llvm-svn.src/include/llvm/ADT/SmallVector.h
llvm-svn.src/include/llvm/ADT/StringExtras.h
llvm-svn.src/include/llvm/ADT/StringMap.h
llvm-svn.src/include/llvm/ADT/StringRef.h
llvm-svn.src/include/llvm/ADT/StringSet.h
llvm-svn.src/include/llvm/ADT/Triple.h
llvm-svn.src/include/llvm/ADT/Twine.h
llvm-svn.src/include/llvm/ADT/ilist.h
llvm-svn.src/include/llvm/ADT/ilist_node.h
llvm-svn.src/include/llvm/ADT/iterator.h
llvm-svn.src/include/llvm/ADT/iterator_range.h
llvm-svn.src/include/llvm/Bitcode/BitCodes.h
llvm-svn.src/include/llvm/Bitcode/BitstreamReader.h
llvm-svn.src/include/llvm/DebugInfo/DIContext.h
llvm-svn.src/include/llvm/ExecutionEngine/ExecutionEngine.h
llvm-svn.src/include/llvm/ExecutionEngine/MCJIT.h
llvm-svn.src/include/llvm/ExecutionEngine/RTDyldMemoryManager.h
llvm-svn.src/include/llvm/ExecutionEngine/RuntimeDyld.h
llvm-svn.src/include/llvm/ExecutionEngine/SectionMemoryManager.h
llvm-svn.src/include/llvm/IR/Argument.h
llvm-svn.src/include/llvm/IR/Attributes.h
llvm-svn.src/include/llvm/IR/BasicBlock.h
llvm-svn.src/include/llvm/IR/CallingConv.h
llvm-svn.src/include/llvm/IR/Comdat.h
llvm-svn.src/include/llvm/IR/Constant.h
llvm-svn.src/include/llvm/IR/Constants.h
llvm-svn.src/include/llvm/IR/DataLayout.h
llvm-svn.src/include/llvm/IR/DerivedTypes.h
llvm-svn.src/include/llvm/IR/Function.h
llvm-svn.src/include/llvm/IR/GlobalAlias.h
llvm-svn.src/include/llvm/IR/GlobalObject.h
llvm-svn.src/include/llvm/IR/GlobalValue.h
llvm-svn.src/include/llvm/IR/GlobalVariable.h
llvm-svn.src/include/llvm/IR/InstrTypes.h
llvm-svn.src/include/llvm/IR/Instruction.h
llvm-svn.src/include/llvm/IR/Instructions.h
llvm-svn.src/include/llvm/IR/Intrinsics.h
llvm-svn.src/include/llvm/IR/LLVMContext.h
llvm-svn.src/include/llvm/IR/LegacyPassManager.h
llvm-svn.src/include/llvm/IR/Metadata.h
llvm-svn.src/include/llvm/IR/Module.h
llvm-svn.src/include/llvm/IR/OperandTraits.h
llvm-svn.src/include/llvm/IR/SymbolTableListTraits.h
llvm-svn.src/include/llvm/IR/Type.h
llvm-svn.src/include/llvm/IR/Use.h
llvm-svn.src/include/llvm/IR/User.h
llvm-svn.src/include/llvm/IR/Value.h
llvm-svn.src/include/llvm/IR/ValueHandle.h
llvm-svn.src/include/llvm/IR/ValueSymbolTable.h
llvm-svn.src/include/llvm/InitializePasses.h
llvm-svn.src/include/llvm/Object/Binary.h
llvm-svn.src/include/llvm/Object/ELFObjectFile.h
llvm-svn.src/include/llvm/Object/Error.h
llvm-svn.src/include/llvm/Object/MachO.h
llvm-svn.src/include/llvm/Object/RelocVisitor.h
llvm-svn.src/include/llvm/Object/SymbolicFile.h
llvm-svn.src/include/llvm/Option/OptSpecifier.h
llvm-svn.src/include/llvm/Pass.h
llvm-svn.src/include/llvm/PassAnalysisSupport.h
llvm-svn.src/include/llvm/PassInfo.h
llvm-svn.src/include/llvm/PassRegistry.h
llvm-svn.src/include/llvm/PassSupport.h
llvm-svn.src/include/llvm/Support/Atomic.h
llvm-svn.src/include/llvm/Support/Casting.h
llvm-svn.src/include/llvm/Support/CodeGen.h
llvm-svn.src/include/llvm/Support/DataStream.h
llvm-svn.src/include/llvm/Support/Debug.h
llvm-svn.src/include/llvm/Support/DynamicLibrary.h
llvm-svn.src/include/llvm/Support/ErrorHandling.h
llvm-svn.src/include/llvm/Support/FileSystem.h
llvm-svn.src/include/llvm/Support/FileUtilities.h
llvm-svn.src/include/llvm/Support/FormattedStream.h
llvm-svn.src/include/llvm/Support/Host.h
llvm-svn.src/include/llvm/Support/MD5.h
llvm-svn.src/include/llvm/Support/ManagedStatic.h
llvm-svn.src/include/llvm/Support/MathExtras.h
llvm-svn.src/include/llvm/Support/Memory.h
llvm-svn.src/include/llvm/Support/MemoryObject.h
llvm-svn.src/include/llvm/Support/Mutex.h
llvm-svn.src/include/llvm/Support/Program.h
llvm-svn.src/include/llvm/Support/RWMutex.h
llvm-svn.src/include/llvm/Support/Regex.h
llvm-svn.src/include/llvm/Support/Registry.h
llvm-svn.src/include/llvm/Support/Signals.h
llvm-svn.src/include/llvm/Support/SourceMgr.h
llvm-svn.src/include/llvm/Support/StreamingMemoryObject.h
llvm-svn.src/include/llvm/Support/TargetSelect.h
llvm-svn.src/include/llvm/Support/Threading.h
llvm-svn.src/include/llvm/Support/TimeValue.h
llvm-svn.src/include/llvm/Support/Timer.h
llvm-svn.src/include/llvm/Support/UniqueLock.h
llvm-svn.src/include/llvm/Support/Valgrind.h
llvm-svn.src/include/llvm/Support/raw_os_ostream.h
llvm-svn.src/include/llvm/Support/raw_ostream.h
llvm-svn.src/include/llvm/Support/type_traits.h
llvm-svn.src/include/llvm/Target/TargetMachine.h
llvm-svn.src/include/llvm/Target/TargetOptions.h
|