This is an archive of the discontinued LLVM Phabricator instance.

[lldb] Split TestCxxChar8_t
ClosedPublic

Authored by JDevlieghere on Nov 30 2021, 1:18 PM.

Details

Summary

Split TestCxxChar8_t into two parts: one that check reading variables without a process and another part with. This allows us to skip the former on Apple Silicon, where lack of support for chained fix-ups causes the test to fail.

Diff Detail

Event Timeline

JDevlieghere requested review of this revision.Nov 30 2021, 1:18 PM
JDevlieghere created this revision.
JDevlieghere added inline comments.
lldb/test/API/lang/cpp/char8_t/TestCxxChar8_t.py
22

The name of this helper method is terribly confusing. I had to look at the source to realize it is meant to specify that it's the make_target helper function of run_to_breakpoint. Something for a subsequent patch.

shafik added a subscriber: shafik.Nov 30 2021, 4:05 PM

I recently ran into this, thanks for fixing the test.

jingham requested changes to this revision.Dec 1 2021, 4:51 PM

Seems fine to me to break this into running and not running cases, but you should use the right lldbutil method for the running case.

lldb/test/API/lang/cpp/char8_t/TestCxxChar8_t.py
40–43

You don't need to do this in three steps, do you? Can't you just use lldbutil.run_to_source_breakpoint? That will catch errors in running & hitting the breakpoint which you don't check here.

This revision now requires changes to proceed.Dec 1 2021, 4:51 PM
JDevlieghere marked an inline comment as done.Dec 1 2021, 4:53 PM
JDevlieghere added inline comments.
lldb/test/API/lang/cpp/char8_t/TestCxxChar8_t.py
40–43

Yes, that would work here, but not for the test above. I'll update the patch.

JDevlieghere marked an inline comment as done.

Address Jim's comment

jingham accepted this revision.Dec 1 2021, 4:56 PM

LGTM

This revision is now accepted and ready to land.Dec 1 2021, 4:56 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptDec 1 2021, 4:59 PM
labath added a comment.Dec 6 2021, 1:48 AM

Looks good. Thanks for fixing this up.