This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Improve CMake include directory search.
ClosedPublic

Authored by Mordante on Nov 19 2021, 7:46 AM.

Details

Reviewers
ldionne
Group Reviewers
Restricted Project
Commits
rGcc9fdedba7c9: [libc++] Improve CMake include directory search.
Summary

This patch has been tested in D70631, but it should be reviewed
separately.

Diff Detail

Event Timeline

Mordante created this revision.Nov 19 2021, 7:46 AM
Mordante requested review of this revision.Nov 19 2021, 7:46 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 19 2021, 7:46 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne added inline comments.Nov 19 2021, 7:50 AM
libcxx/src/CMakeLists.txt
200

What are these useful for?

Mordante added inline comments.Nov 19 2021, 10:06 AM
libcxx/src/CMakeLists.txt
200

Basically it's based on the comment https://reviews.llvm.org/D70631#inline-1071881. In that original version I used the blunt tool of include_directories(${CMAKE_CURRENT_SOURCE_DIR}). Without this the ryu related headers can't be found.

ldionne accepted this revision.Nov 19 2021, 2:46 PM
ldionne added inline comments.
libcxx/src/CMakeLists.txt
200

Thanks!

This revision is now accepted and ready to land.Nov 19 2021, 2:46 PM
This revision was automatically updated to reflect the committed changes.