This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Disallow running the libc++ benchmarks in standalone builds
ClosedPublic

Authored by ldionne on Nov 9 2021, 11:46 AM.

Details

Summary

We are trying to remove duplication of third-party code in
https://reviews.llvm.org/D112012, which will move the Google
Benchmark code outside of the libcxx/ directory. That breaks
running the benchmarks in the Standalone build. Since we have
deprecated the Standalone build anyway, this patch just removes
support for the benchmark in Standalone mode until we remove that
mode entirely.

Diff Detail

Event Timeline

ldionne created this revision.Nov 9 2021, 11:46 AM
ldionne requested review of this revision.Nov 9 2021, 11:46 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 9 2021, 11:46 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Mordante accepted this revision as: Mordante.Nov 9 2021, 12:29 PM
Mordante added a subscriber: Mordante.

Good the know this will soon stop working.
LGTM!

ldionne accepted this revision.Nov 11 2021, 11:13 AM

Shipping despite the CI failure since this is a known issue and I've fixed it since then.

This revision is now accepted and ready to land.Nov 11 2021, 11:13 AM
This revision was landed with ongoing or failed builds.Nov 11 2021, 11:13 AM
This revision was automatically updated to reflect the committed changes.