This is an archive of the discontinued LLVM Phabricator instance.

Fix building with cmake 2.8.4 or greater under cygwin hosts
ClosedPublic

Authored by martell on Jul 20 2015, 12:15 AM.

Details

Summary

As of cmake 2.8.4 the cygwin target no longer defines WIN32
The -z option must still be avoided however for cygwin targets

Diff Detail

Repository
rL LLVM

Event Timeline

martell updated this revision to Diff 30133.Jul 20 2015, 12:15 AM
martell retitled this revision from to Fix building with cmake 2.8.4 or greater under cygwin hosts.
martell updated this object.
martell added a reviewer: yaron.keren.
martell added a subscriber: llvm-commits.

Hi Chapuni, does this Cygwin change makes sense to you?

yaron.keren added inline comments.Jul 22 2015, 1:38 PM
cmake/modules/HandleLLVMOptions.cmake
135

Shouldn't be a"OR" after "CYGWIN" ?

hans added a subscriber: hans.Jul 22 2015, 2:54 PM
martell updated this revision to Diff 30447.Jul 22 2015, 10:13 PM
martell edited edge metadata.

Very strange on the one I'm using I do have the OR after.
My bad thanks yaron :)

yaron.keren accepted this revision.Jul 23 2015, 1:32 AM
yaron.keren edited edge metadata.
This revision is now accepted and ready to land.Jul 23 2015, 1:32 AM

Hans do you want this for 3.7 ?

hans added a comment.Jul 23 2015, 9:15 AM

Hans do you want this for 3.7 ?

Yes, that seems like a good idea. I've merged it in r243023.