This is an archive of the discontinued LLVM Phabricator instance.

Fix building with cmake 2.8.4 or greater under cygwin hosts
ClosedPublic

Authored by martell on Jul 20 2015, 12:15 AM.

Reviewers

yaron.keren
chapuni

Summary

As of cmake 2.8.4 the cygwin target no longer defines WIN32
The -z option must still be avoided however for cygwin targets

martell retitled this revision from to Fix building with cmake 2.8.4 or greater under cygwin hosts.

martell updated this object.

martell added a reviewer: yaron.keren.

martell added a subscriber: llvm-commits.

Hi Chapuni, does this Cygwin change makes sense to you?

ping?

cmake/modules/HandleLLVMOptions.cmake
135	Shouldn't be a"OR" after "CYGWIN" ?

Very strange on the one I'm using I do have the OR after.
My bad thanks yaron :)

yaron.keren edited edge metadata.

This revision is now accepted and ready to land.Jul 23 2015, 1:32 AM

r242993

Hans do you want this for 3.7 ?

In D11347#210652, @martell wrote:

Hans do you want this for 3.7 ?

Yes, that seems like a good idea. I've merged it in r243023.

Path

Size

cmake/

modules/

2 lines

Context not available.

	# Pass -Wl,-z,defs. This makes sure all symbols are defined. Otherwise a DSO	# Pass -Wl,-z,defs. This makes sure all symbols are defined. Otherwise a DSO
	# build might work on ELF but fail on MachO/COFF.	# build might work on ELF but fail on MachO/COFF.
	if(NOT (${CMAKE_SYSTEM_NAME} MATCHES "Darwin" OR WIN32 OR	if(NOT (${CMAKE_SYSTEM_NAME} MATCHES "Darwin" OR WIN32 OR CYGWIN OR
	${CMAKE_SYSTEM_NAME} MATCHES "FreeBSD") AND	${CMAKE_SYSTEM_NAME} MATCHES "FreeBSD") AND
		yaron.kerenUnsubmitted Not Done Reply Inline Actions Shouldn't be a"OR" after "CYGWIN" ? yaron.keren: Shouldn't be a"OR" after "CYGWIN" ?
	NOT LLVM_USE_SANITIZER)	NOT LLVM_USE_SANITIZER)
	set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} -Wl,-z,defs")	set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} -Wl,-z,defs")
Context not available.