This is an archive of the discontinued LLVM Phabricator instance.

[Release] Allow release testers to disable certain components
ClosedPublic

Authored by rengolin on Jul 18 2015, 3:15 AM.

Details

Summary

Not all components build correctly on all targets and the release
script had no way to disable them other than editing the script locally.

This change provides a way to disable the test-suite, compiler-rt and
the libraries, as well as allowing you to re-run on the same directory
without checking out all sources again.

Diff Detail

Event Timeline

rengolin updated this revision to Diff 30078.Jul 18 2015, 3:15 AM
rengolin retitled this revision from to [Release] Allow release testers to disable certain components.
rengolin updated this object.
rengolin added reviewers: hans, tstellarAMD.
rengolin set the repository for this revision to rL LLVM.
rengolin added a subscriber: llvm-commits.
hans added inline comments.Jul 20 2015, 9:15 AM
utils/release/test-release.sh
22

Could we move this down to where the optional projects are added? It would be easier to follow if they were close to each other in the source.

246

Doesn't -no-checkout cover this use case?

rengolin added inline comments.Jul 22 2015, 11:04 AM
utils/release/test-release.sh
22

good point

246

To a point, yes. But I'd argue that this is a better solution that replaces -no-checkout, which avoids the whole validate+checkout+symlink.

My reasoning is that -no-checkout exists so that you can either use an external source tree, or continue from a failed previous attempt.

For the former, with this solution you still control the links to the other projects (via -no-rt, etc), and also checkout the missing projects you haven't used.

For the latter, if the failure is in SVN or symlinks, -no-checkout won't work, as it's all or nothing.

rengolin updated this revision to Diff 30370.Jul 22 2015, 11:06 AM
rengolin removed rL LLVM as the repository for this revision.

Moving $projects initialisation further down.

hans accepted this revision.Jul 22 2015, 11:17 AM
hans edited edge metadata.

lgtm

This revision is now accepted and ready to land.Jul 22 2015, 11:17 AM
rengolin closed this revision.Jul 22 2015, 11:22 AM

Thanks! Committed in r242919.