This is an archive of the discontinued LLVM Phabricator instance.

[LNT] Add support for storing hash of test binaries.
ClosedPublic

Authored by kristof.beyls on Jul 15 2015, 11:15 AM.
Tokens
"Like" token, awarded by cmatthews.

Details

Summary
This commit adds support for storing hashes of the test binaries as a
new sample type. The idea is that when the hash function of the same
test is the same as on a previous run, the analyses can assume that
the binary didn't change in a meaningful way.

None of the analyses in LNT have been adapted yet to take advantage of
this extra information.

The hash value is stored as a new sample type.  Since the hash value
in many cases should not be handled the same as other sample types,
like execution time or compilation time, a distinction needs to be
made. This patch changes terminology in LNT and calls sample types
that have a meaningful order, like execution time and compilation
time, "metic fields". The hash function of a binary - as one hash
value cannot be said to be "better" than another hash value - is not
considered a "metric field".

Diff Detail

Repository
rL LLVM

Event Timeline

kristof.beyls retitled this revision from to [LNT] Add support for storing hash of test binaries..
kristof.beyls updated this object.
kristof.beyls added a reviewer: cmatthews.
kristof.beyls added a subscriber: llvm-commits.
cmatthews accepted this revision.Jul 15 2015, 1:01 PM
cmatthews edited edge metadata.

Wow, this is wonderful. Thanks Kristof! LGTM.

I only tested this on sqlite, BTW.

This revision is now accepted and ready to land.Jul 15 2015, 1:01 PM

I can't say much about the python code, but I very much welcome this change. :)

--renato

This revision was automatically updated to reflect the committed changes.