Introduce __libunwind_config.h to avoid cross repository circular
dependency with libcxxabi.
Details
Diff Detail
Event Timeline
Hmm. Looks like there will need to be some cleanup in libcxx/cmake/Modules/HandleLibCXXABI.cmake before this can happen.
Right now the C++ ABI headers get installed as part of the libc++ build, and we adjust that as necessary for each ABI library we support, but there isn't any support to vary it by unwinder (and really the whole thing is a hack).
May you further elaborate your idea? I don't quite understand why should we install the headers of libunwind for libcxx?
Hi Logan,
Is this replacing or complementing the libc++abi definitions?
I was expecting some changes in the CMake files of the projects describing the lack of dependency, or is that done automatically?
cheers,
--renato
Actually, I don't think there's an issue here from the libc++ side of things; we already don't install any of the libunwind headers (though libcxxrt does, so maybe we should?).
My concern was: https://github.com/llvm-mirror/libcxx/blob/master/cmake/Modules/HandleLibCXXABI.cmake#L92
We install libc++abi headers there, and for libcxxrt we also install the unwind headers there. Since this isn't already broken, presumably libunwind is already properly separated to not need them there.
Still, as Renato says, we should be installing the libunwind headers somewhere. Since we don't do any of that yet though, I think it's reasonable to save that for a different patch.