This is an archive of the discontinued LLVM Phabricator instance.

Differential D112034

[lldb/test] Update test/API/functionalities/load_lazy to macOS 12
ClosedPublic

Authored by vsk on Oct 18 2021, 2:41 PM.

Details

Reviewers
JDevlieghere
kastiglione
kledzik
Commits
rG5e004b03f72a: [lldb/test] Update test/API/functionalities/load_lazy to macOS 12
Summary

In macOS 12, dyld switched to using chained fixups. As a result, all symbols
are bound at launch and there are no lazy pointers any more. Since we wish to
import/dlopen() a dylib with missing symbols, we need to use a weak import.
This applies to all macOS 12-aligned OS releases, e.g. iOS 15, etc.

rdar://81295101

Diff Detail

Event Timeline

vsk requested review of this revision.Oct 18 2021, 2:41 PM
vsk created this revision.
Harbormaster completed remote builds in B129430: Diff 380523.Oct 18 2021, 2:43 PM
JDevlieghere accepted this revision.Oct 18 2021, 5:46 PM

LGTM

This revision is now accepted and ready to land.Oct 18 2021, 5:46 PM
Closed by commit rG5e004b03f72a: [lldb/test] Update test/API/functionalities/load_lazy to macOS 12 (authored by vsk). · Explain WhyOct 19 2021, 1:25 PM
This revision was automatically updated to reflect the committed changes.
vsk added a commit: rG5e004b03f72a: [lldb/test] Update test/API/functionalities/load_lazy to macOS 12.
Herald added a project: Restricted Project. · View Herald TranscriptOct 19 2021, 1:25 PM

Revision Contents

PathSize
lldb/
test/
API/
functionalities/
load_lazy/
13 lines

Diff 380769

lldb/test/API/functionalities/load_lazy/Makefile

CXX_SOURCES := main.cpp CXX_SOURCES := main.cpp
USE_LIBDL := 1 USE_LIBDL := 1
all: t2_0 t2_1 t1 a.out all: t2_0 t2_1 t1 a.out
include Makefile.rules include Makefile.rules
ifeq "$(OS)" "Darwin"
# In macOS 12, dyld switched to using chained fixups. As a result, all
# symbols are bound at launch and there are no lazy pointers any more.
# Since we wish to import/dlopen() a dylib with missing symbols, we need
# to use a weak import. This applies to all macOS 12-aligned OS releases,
# e.g. iOS 15, etc.
LINKFLAGS := "-Wl,-weak-lt2_0"
else
LINKFLAGS := "-lt2_0"
endif
t1: t2_0 t1: t2_0
$(MAKE) VPATH=$(SRCDIR) -f $(MAKEFILE_RULES) \ $(MAKE) VPATH=$(SRCDIR) -f $(MAKEFILE_RULES) \
DYLIB_ONLY=YES DYLIB_C_SOURCES=t1.c DYLIB_NAME=t1 LD_EXTRAS="-L. -lt2_0" DYLIB_ONLY=YES DYLIB_C_SOURCES=t1.c DYLIB_NAME=t1 LD_EXTRAS="-L. $(LINKFLAGS)"
t2_0: t2_0:
$(MAKE) VPATH=$(SRCDIR) -f $(MAKEFILE_RULES) \ $(MAKE) VPATH=$(SRCDIR) -f $(MAKEFILE_RULES) \
DYLIB_ONLY=YES DYLIB_C_SOURCES=t2_0.c DYLIB_NAME=t2_0 DYLIB_ONLY=YES DYLIB_C_SOURCES=t2_0.c DYLIB_NAME=t2_0
t2_1: t2_1:
$(MAKE) VPATH=$(SRCDIR) -f $(MAKEFILE_RULES) \ $(MAKE) VPATH=$(SRCDIR) -f $(MAKEFILE_RULES) \
DYLIB_ONLY=YES DYLIB_C_SOURCES=t2_1.c DYLIB_NAME=t2_1 DYLIB_ONLY=YES DYLIB_C_SOURCES=t2_1.c DYLIB_NAME=t2_1