Page MenuHomePhabricator

kastiglione (Dave Lee)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 14 2015, 10:30 PM (267 w, 3 d)

Recent Activity

Thu, Sep 24

kastiglione added a comment to D88257: [lldb/docs] Remove manual codesigning documentation.

I agree it's nice to have somewhere, but git history should be fine. I should elaborate on motivations, 1. ensure everyone is using the script so that any issues are surfaced, 2. prevent missteps in the manual process, which may also be bit rotting if everyone is using the script.

Thu, Sep 24, 1:55 PM · Restricted Project
kastiglione requested review of D88257: [lldb/docs] Remove manual codesigning documentation.
Thu, Sep 24, 1:03 PM · Restricted Project
kastiglione added inline comments to D88129: Add "break delete --disabled" to delete all currently disabled breakpoints.
Thu, Sep 24, 10:44 AM · Restricted Project
kastiglione committed rGada1e2ffa117: [lldb/examples] Add missing declaration in heap.py (authored by kastiglione).
[lldb/examples] Add missing declaration in heap.py
Thu, Sep 24, 8:46 AM
kastiglione closed D88158: [lldb/examples] Add missing declaration in heap.py.
Thu, Sep 24, 8:45 AM · Restricted Project

Wed, Sep 23

kastiglione added inline comments to D88129: Add "break delete --disabled" to delete all currently disabled breakpoints.
Wed, Sep 23, 4:03 PM · Restricted Project
kastiglione added inline comments to D88129: Add "break delete --disabled" to delete all currently disabled breakpoints.
Wed, Sep 23, 2:55 PM · Restricted Project
kastiglione accepted D88181: Utility: ignore OS version on non-Darwin targets in `ArchSpec`.

sgtm

Wed, Sep 23, 2:38 PM · Restricted Project
kastiglione added inline comments to D88129: Add "break delete --disabled" to delete all currently disabled breakpoints.
Wed, Sep 23, 12:16 PM · Restricted Project
kastiglione accepted D88129: Add "break delete --disabled" to delete all currently disabled breakpoints.

Nice improvement!

Wed, Sep 23, 11:02 AM · Restricted Project
kastiglione requested review of D88158: [lldb/examples] Add missing declaration in heap.py.
Wed, Sep 23, 9:13 AM · Restricted Project
kastiglione committed rG9abd1e8f4e5d: [lldb] Remove lldb-perf remenant (authored by kastiglione).
[lldb] Remove lldb-perf remenant
Wed, Sep 23, 8:24 AM
kastiglione closed D88119: [lldb] Remove lldb-perf remenant.
Wed, Sep 23, 8:24 AM · Restricted Project

Tue, Sep 22

kastiglione added inline comments to D88123: Add the ability to write 'target stop-hooks' in Python.
Tue, Sep 22, 6:57 PM · Restricted Project
kastiglione requested review of D88119: [lldb] Remove lldb-perf remenant.
Tue, Sep 22, 4:12 PM · Restricted Project

Mon, Sep 21

kastiglione added a comment to D87868: [RFC] When calling the process mmap try to call all found instead of just the first one.

Should lldb avoid calling asan (or any other sanitizer's) mmap? If so, maybe this function can be sanitizer aware and ignore those symbols.

Mon, Sep 21, 3:18 PM · Restricted Project
kastiglione committed rGb36bdfe5ca0c: [cmake] Centralize LLVM_ENABLE_WARNINGS option (authored by kastiglione).
[cmake] Centralize LLVM_ENABLE_WARNINGS option
Mon, Sep 21, 10:23 AM
kastiglione closed D87243: [cmake] Centralize LLVM_ENABLE_WARNINGS option.
Mon, Sep 21, 10:23 AM · Restricted Project, Restricted Project, Restricted Project
kastiglione committed rG3b3b9ba1c7d8: [lldb/Commands] Fix outdated `breakpoint command add` help string (authored by kastiglione).
[lldb/Commands] Fix outdated `breakpoint command add` help string
Mon, Sep 21, 10:16 AM
kastiglione closed D87807: [lldb/Commands] Fix outdated `breakpoint command add` help string.
Mon, Sep 21, 10:15 AM · Restricted Project

Wed, Sep 16

kastiglione added inline comments to D87807: [lldb/Commands] Fix outdated `breakpoint command add` help string.
Wed, Sep 16, 7:30 PM · Restricted Project
kastiglione added inline comments to D87807: [lldb/Commands] Fix outdated `breakpoint command add` help string.
Wed, Sep 16, 4:45 PM · Restricted Project
kastiglione requested review of D87807: [lldb/Commands] Fix outdated `breakpoint command add` help string.
Wed, Sep 16, 4:45 PM · Restricted Project

Tue, Sep 15

kastiglione committed rG757ac4ccfb8b: [lldb] Reword CompilerType docstring to not say "generic type" (authored by kastiglione).
[lldb] Reword CompilerType docstring to not say "generic type"
Tue, Sep 15, 10:15 PM
kastiglione closed D87633: [lldb] Reword CompilerType docstring to not say "generic type".
Tue, Sep 15, 10:15 PM · Restricted Project

Mon, Sep 14

kastiglione requested review of D87633: [lldb] Reword CompilerType docstring to not say "generic type".
Mon, Sep 14, 1:57 PM · Restricted Project

Sun, Sep 13

kastiglione committed rG6e42cadf106c: [docs] Document LLVM_EXTERNALIZE_DEBUGINFO CMake option (authored by kastiglione).
[docs] Document LLVM_EXTERNALIZE_DEBUGINFO CMake option
Sun, Sep 13, 9:40 PM
kastiglione closed D87591: [docs] Document LLVM_EXTERNALIZE_DEBUGINFO CMake option.
Sun, Sep 13, 9:39 PM · Restricted Project
kastiglione requested review of D87591: [docs] Document LLVM_EXTERNALIZE_DEBUGINFO CMake option.
Sun, Sep 13, 4:56 PM · Restricted Project

Thu, Sep 10

kastiglione added a comment to D87243: [cmake] Centralize LLVM_ENABLE_WARNINGS option.

for context this caused standalone swift-lldb builds to have warnings disabled via -w

Thu, Sep 10, 9:58 AM · Restricted Project, Restricted Project, Restricted Project
kastiglione added a comment to D87243: [cmake] Centralize LLVM_ENABLE_WARNINGS option.

@compnerd Saleem, what do you think? (see also my reply to you)

Thu, Sep 10, 9:58 AM · Restricted Project, Restricted Project, Restricted Project

Wed, Sep 9

kastiglione committed rG55dd731b291c: [debugserver] Extract function for default launch flavor (authored by kastiglione).
[debugserver] Extract function for default launch flavor
Wed, Sep 9, 11:36 AM
kastiglione closed D87327: [debugserver] Extract function for default launch flavor.
Wed, Sep 9, 11:35 AM · Restricted Project
kastiglione added a comment to D87327: [debugserver] Extract function for default launch flavor.

@teemperor I'm not sure what these build errors mean, for example https://reviews.llvm.org/B70998. Also there's the linux build failure, but that's not relevant for debugserver, right?

Wed, Sep 9, 11:10 AM · Restricted Project
kastiglione committed rG447ba60a224f: [lldb/Docs] Correct LLDB_ENABLE_TESTS to LLDB_INCLUDE_TESTS (authored by kastiglione).
[lldb/Docs] Correct LLDB_ENABLE_TESTS to LLDB_INCLUDE_TESTS
Wed, Sep 9, 11:09 AM
kastiglione closed D87345: [lldb/Docs] Correct LLDB_ENABLE_TESTS to LLDB_INCLUDE_TESTS.
Wed, Sep 9, 11:09 AM · Restricted Project

Tue, Sep 8

kastiglione requested review of D87345: [lldb/Docs] Correct LLDB_ENABLE_TESTS to LLDB_INCLUDE_TESTS.
Tue, Sep 8, 10:54 PM · Restricted Project
kastiglione updated the diff for D87243: [cmake] Centralize LLVM_ENABLE_WARNINGS option.

Add LLVM_ENABLE_WARNINGS to LLVMConfig.cmake.in

Tue, Sep 8, 3:40 PM · Restricted Project, Restricted Project, Restricted Project
kastiglione added a comment to D87243: [cmake] Centralize LLVM_ENABLE_WARNINGS option.

If another project defines LLVM_ENABLE_WARNINGS before loading HandleLLVMOptions, it seems correct to me that the first one is used. This change ensures the default value of ON is setup at the last possible opportunity, before LLVM_ENABLE_WARNINGS is read and acted on.

Tue, Sep 8, 2:15 PM · Restricted Project, Restricted Project, Restricted Project
kastiglione updated the diff for D87327: [debugserver] Extract function for default launch flavor.

clang-format

Tue, Sep 8, 2:04 PM · Restricted Project
kastiglione added a comment to D87327: [debugserver] Extract function for default launch flavor.

Follow up to 8aeb212887024a615ca02437cd12fa055bd54b6f

Tue, Sep 8, 1:52 PM · Restricted Project
kastiglione requested review of D87327: [debugserver] Extract function for default launch flavor.
Tue, Sep 8, 1:50 PM · Restricted Project
kastiglione added a comment to D87243: [cmake] Centralize LLVM_ENABLE_WARNINGS option.

If an LLVM install disabled LLVM_ENABLE_WARNINGS, should other builds inherit that? I would think no, but is there a precedent for that that to be the case?

Tue, Sep 8, 11:44 AM · Restricted Project, Restricted Project, Restricted Project

Mon, Sep 7

kastiglione added a comment to D87243: [cmake] Centralize LLVM_ENABLE_WARNINGS option.

The LLVM_ENABLE_WARNINGS variable is read only within HandleLLVMOptions.cmake. Outside declarations/defaults have effect only when HandleLLVMOptions is loaded, one way or another.

Mon, Sep 7, 10:40 AM · Restricted Project, Restricted Project, Restricted Project
kastiglione added a comment to D87243: [cmake] Centralize LLVM_ENABLE_WARNINGS option.

@lebedev.ri clang/CMakeLists.txt contains include(HandleLLVMOptions) for its standalone build, I think this covers the issue you're pointing out

Mon, Sep 7, 10:21 AM · Restricted Project, Restricted Project, Restricted Project
kastiglione updated the summary of D87243: [cmake] Centralize LLVM_ENABLE_WARNINGS option.
Mon, Sep 7, 10:11 AM · Restricted Project, Restricted Project, Restricted Project
kastiglione requested review of D87243: [cmake] Centralize LLVM_ENABLE_WARNINGS option.
Mon, Sep 7, 10:00 AM · Restricted Project, Restricted Project, Restricted Project

Thu, Sep 3

kastiglione added a comment to D86996: [lldb] Add -l/--language option to script command.

Given the expr status quo, I'd stick with that.

Thu, Sep 3, 10:04 AM · Restricted Project, Restricted Project

Wed, Sep 2

kastiglione added inline comments to D86996: [lldb] Add -l/--language option to script command.
Wed, Sep 2, 11:36 AM · Restricted Project, Restricted Project

Tue, Sep 1

kastiglione added inline comments to D86996: [lldb] Add -l/--language option to script command.
Tue, Sep 1, 8:31 PM · Restricted Project, Restricted Project
kastiglione added inline comments to D86996: [lldb] Add -l/--language option to script command.
Tue, Sep 1, 7:28 PM · Restricted Project, Restricted Project

Aug 27 2020

kastiglione accepted D86722: [lldb] Make lldb-argdumper a dependency of liblldb.
Aug 27 2020, 9:15 AM · Restricted Project

Aug 26 2020

kastiglione added inline comments to D86667: [lldb/Target] Add custom interpreter option to `platform shell`.
Aug 26 2020, 8:15 PM · Restricted Project

Aug 25 2020

kastiglione committed rG66c48802918d: Remove unused/misnamed SetObjectModificationTime (authored by kastiglione).
Remove unused/misnamed SetObjectModificationTime
Aug 25 2020, 2:58 PM
kastiglione closed D86493: [lldb][NFC] Remove unused/misnamed SetObjectModificationTime.
Aug 25 2020, 2:58 PM · Restricted Project
kastiglione added a comment to D86493: [lldb][NFC] Remove unused/misnamed SetObjectModificationTime.

Sometimes these odd leaf APIs are used by custom downstream variants of LLDB

Aug 25 2020, 10:36 AM · Restricted Project

Aug 24 2020

kastiglione added inline comments to D86497: [lldb] Add reproducer verifier.
Aug 24 2020, 5:29 PM · Restricted Project, Restricted Project
kastiglione retitled D86493: [lldb][NFC] Remove unused/misnamed SetObjectModificationTime from Remove unused/misnamed SetObjectModificationTime to [lldb][NFC] Remove unused/misnamed SetObjectModificationTime.
Aug 24 2020, 4:36 PM · Restricted Project
kastiglione requested review of D86493: [lldb][NFC] Remove unused/misnamed SetObjectModificationTime.
Aug 24 2020, 4:04 PM · Restricted Project

Dec 12 2019

kastiglione committed rG710d052c56c6: Move typedef keyword out of macro; Remove _ prefixes (authored by kastiglione).
Move typedef keyword out of macro; Remove _ prefixes
Dec 12 2019, 2:58 PM
kastiglione committed rGf47480963e80: Mark indexstore enum flag types with flag_enum attribute (authored by kastiglione).
Mark indexstore enum flag types with flag_enum attribute
Dec 12 2019, 2:58 PM
kastiglione committed rGa591786fa7a2: Use sized enums or fallback to typedef (authored by kastiglione).
Use sized enums or fallback to typedef
Dec 12 2019, 2:58 PM
kastiglione committed rGb6c53ad05344: Mark indexstore callbacks with noescape attribute (authored by kastiglione).
Mark indexstore callbacks with noescape attribute
Dec 12 2019, 1:20 PM

Oct 25 2019

kastiglione added a comment to D69422: [lldb][Docs] Add extra lldb aliases to gdb->lldb map.

I wonder if it is time to take the gdb commands out and just make this a task -> lldb commands table?

Oct 25 2019, 10:53 AM · Restricted Project
kastiglione added a comment to D69422: [lldb][Docs] Add extra lldb aliases to gdb->lldb map.

fwiw I have a python command called abbrev that takes a command and shows you the alias you can use instead.

Oct 25 2019, 9:38 AM · Restricted Project
kastiglione added a comment to D69422: [lldb][Docs] Add extra lldb aliases to gdb->lldb map.

Thanks. I thought this was reasonable since the documentation shows many uses of lldb aliases already.

Oct 25 2019, 9:29 AM · Restricted Project

Oct 24 2019

kastiglione created D69422: [lldb][Docs] Add extra lldb aliases to gdb->lldb map.
Oct 24 2019, 10:27 PM · Restricted Project

Oct 10 2019

kastiglione committed rL374423: Request commit access for kastiglione.
Request commit access for kastiglione
Oct 10 2019, 12:10 PM

Jul 9 2019

kastiglione committed rG90148db02a5b: [Docs] Replace SVN revisions with lldb versions (authored by kastiglione).
[Docs] Replace SVN revisions with lldb versions
Jul 9 2019, 2:25 PM
kastiglione committed rL365559: [Docs] Replace SVN revisions with lldb versions.
[Docs] Replace SVN revisions with lldb versions
Jul 9 2019, 2:25 PM
kastiglione closed D61778: [Docs] Replace SVN revisions with lldb versions.
Jul 9 2019, 2:25 PM · Restricted Project, Restricted Project

May 9 2019

kastiglione updated the summary of D61778: [Docs] Replace SVN revisions with lldb versions.
May 9 2019, 11:54 PM · Restricted Project, Restricted Project
kastiglione created D61778: [Docs] Replace SVN revisions with lldb versions.
May 9 2019, 11:54 PM · Restricted Project, Restricted Project

Apr 4 2019

kastiglione added a comment to D60252: [dwarfdump] Make -arch accept alternative spellings.

Sounds good @aprantl

Apr 4 2019, 8:57 AM · Restricted Project
kastiglione abandoned D60252: [dwarfdump] Make -arch accept alternative spellings.
Apr 4 2019, 8:55 AM · Restricted Project

Apr 3 2019

kastiglione updated the diff for D60252: [dwarfdump] Make -arch accept alternative spellings.

Remove unintended changes.

Apr 3 2019, 11:34 PM · Restricted Project
kastiglione created D60252: [dwarfdump] Make -arch accept alternative spellings.
Apr 3 2019, 11:31 PM · Restricted Project

Mar 10 2019

kastiglione committed rG0affb5822f12: Quiet command regex instructions during batch execution (authored by kastiglione).
Quiet command regex instructions during batch execution
Mar 10 2019, 4:17 PM
kastiglione added a comment to D48752: Quiet command regex instructions during batch execution.

Thanks for reviewing @clayborg.

Mar 10 2019, 4:17 PM · Restricted Project
kastiglione committed rL355793: Quiet command regex instructions during batch execution.
Quiet command regex instructions during batch execution
Mar 10 2019, 4:17 PM
kastiglione committed rLLDB355793: Quiet command regex instructions during batch execution.
Quiet command regex instructions during batch execution
Mar 10 2019, 4:17 PM
kastiglione closed D48752: Quiet command regex instructions during batch execution.
Mar 10 2019, 4:17 PM · Restricted Project
kastiglione added a comment to D59101: [SBAPI] Log from record macro.

I'm getting build failures that appear to be caused by this patch. I'm compiling on macOS with Xcode 10.1. The failures are uses of LLDB_RECORD_DUMMY(), passing a callback function pointer as one of the args. This results in errors like:

Mar 10 2019, 3:25 PM · Restricted Project

Feb 27 2019

kastiglione added a comment to D48752: Quiet command regex instructions during batch execution.

@clayborg this has been updated the approach you suggested, adding an interactive parameter.

Feb 27 2019, 11:10 AM · Restricted Project

Feb 16 2019

kastiglione updated the diff for D48752: Quiet command regex instructions during batch execution.

Add interactive parameter

Feb 16 2019, 12:18 AM · Restricted Project

Feb 15 2019

kastiglione added a comment to D48798: llvm-nm: Observe -no-llvm-bc for archive members.

Thanks @compnerd!

Feb 15 2019, 11:00 PM · Restricted Project
kastiglione committed rG5fc9edf6bb59: llvm-nm: Observe -no-llvm-bc for archive members (authored by kastiglione).
llvm-nm: Observe -no-llvm-bc for archive members
Feb 15 2019, 11:00 PM
kastiglione committed rL354196: llvm-nm: Observe -no-llvm-bc for archive members.
llvm-nm: Observe -no-llvm-bc for archive members
Feb 15 2019, 10:59 PM
kastiglione closed D48798: llvm-nm: Observe -no-llvm-bc for archive members.
Feb 15 2019, 10:59 PM · Restricted Project

Jan 18 2019

kastiglione added a comment to D48798: llvm-nm: Observe -no-llvm-bc for archive members.

@pcc I have this fix related to -no-llvm-bc (D4371). I'm looking for a reviewer: could you review, or could you suggest someone? Thanks.

Jan 18 2019, 2:22 PM · Restricted Project

Nov 27 2018

kastiglione added a comment to D48798: llvm-nm: Observe -no-llvm-bc for archive members.

@compnerd would you be willing to accept?

Nov 27 2018, 8:22 PM · Restricted Project
kastiglione updated the summary of D48798: llvm-nm: Observe -no-llvm-bc for archive members.
Nov 27 2018, 7:11 PM · Restricted Project
kastiglione added a comment to D48752: Quiet command regex instructions during batch execution.

@jingham If you're still willing to review this change to command regex, it is updated per our previous discussion, thanks.

Nov 27 2018, 7:04 PM · Restricted Project

Nov 4 2018

kastiglione added a comment to D49776: Update framework-header-fix to force system sed.

@keith I screwed up and committed without amending the commit message to attribute you as the author :( – I'm sorry

Nov 4 2018, 8:02 AM
kastiglione committed rLLDB346099: Update framework-header-fix to force system sed.
Update framework-header-fix to force system sed
Nov 4 2018, 8:00 AM
kastiglione committed rL346099: Update framework-header-fix to force system sed.
Update framework-header-fix to force system sed
Nov 4 2018, 7:59 AM
kastiglione closed D49776: Update framework-header-fix to force system sed.
Nov 4 2018, 7:59 AM

Nov 3 2018

kastiglione added a comment to D48752: Quiet command regex instructions during batch execution.

There are other commands that print instructions in the same way that command regex does, should they be updated in this change too?

Nov 3 2018, 12:59 AM · Restricted Project
kastiglione updated the diff for D48752: Quiet command regex instructions during batch execution.

Added IOHandlerActivatedInteractively

Nov 3 2018, 12:42 AM · Restricted Project
kastiglione added a comment to D48798: llvm-nm: Observe -no-llvm-bc for archive members.

@smeenai or @compnerd – much late follow up, but either of you willing to accept?

Nov 3 2018, 12:00 AM · Restricted Project