Page MenuHomePhabricator

kastiglione (Dave Lee)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 14 2015, 10:30 PM (295 w, 3 d)

Recent Activity

Tue, Apr 6

kastiglione added a comment to rGdc8d63de5d5e: [lldb] Format Plugins/Language/ObjC/Cocoa.cpp (NFC).

For reformat commits, what are your thoughts on adding the shas in .git-blame-ignore-revs?

Tue, Apr 6, 3:38 PM
kastiglione added a comment to D99825: [cmake] Enable -Werror=return-type for clang.

Generally we try pretty hard to be -Werror clean for clang at least (& some folks do so for gcc too)

Tue, Apr 6, 2:42 PM · Restricted Project
kastiglione added a comment to D96715: [lldb] Decouple IsMasterPlan and OkayToDiscard (NFC).

friendly ping @jingham

Tue, Apr 6, 11:30 AM · Restricted Project
kastiglione added a comment to D99825: [cmake] Enable -Werror=return-type for clang.
  1. I've updated the summary to include wording from the original diff D98224 which points out that -Werror=return-type is used in libcxx, libcxxabi, and libunwind.
  2. Warnings have a spectrum of severity, -Wreturn-type is one of the most severe, but turning on -Werror for more mundane warnings would be a deal breaker for some projects. I think it's more reasonable to turn errors on individually, rather than require a codebase to be all or nothing.
  3. There are already other -Werror=... in this same file, so there is precedent.
Tue, Apr 6, 11:00 AM · Restricted Project
kastiglione updated the summary of D99825: [cmake] Enable -Werror=return-type for clang.
Tue, Apr 6, 10:55 AM · Restricted Project

Sun, Apr 4

kastiglione committed rGd1a1798e51a3: [lldb] Replace unneeded use of Foundation with ObjectiveC in tests (NFC) (authored by kastiglione).
[lldb] Replace unneeded use of Foundation with ObjectiveC in tests (NFC)
Sun, Apr 4, 8:05 PM
kastiglione closed D99867: [lldb] Replace unneeded use of Foundation with ObjectiveC in tests (NFC).
Sun, Apr 4, 8:05 PM · Restricted Project
kastiglione committed rG10ed479d7303: [lldb] Import ObjectiveC module instead of Foundation in test (authored by kastiglione).
[lldb] Import ObjectiveC module instead of Foundation in test
Sun, Apr 4, 8:05 PM
kastiglione closed D99859: [lldb] Import ObjectiveC module instead of Foundation in test (NFC).
Sun, Apr 4, 8:04 PM · Restricted Project
kastiglione added inline comments to D99867: [lldb] Replace unneeded use of Foundation with ObjectiveC in tests (NFC).
Sun, Apr 4, 4:09 PM · Restricted Project
kastiglione updated the diff for D99867: [lldb] Replace unneeded use of Foundation with ObjectiveC in tests (NFC).

fix lldb/test/API/commands/frame/recognizer/main.m

Sun, Apr 4, 4:08 PM · Restricted Project
kastiglione requested review of D99867: [lldb] Replace unneeded use of Foundation with ObjectiveC in tests (NFC).
Sun, Apr 4, 2:58 PM · Restricted Project
kastiglione retitled D99859: [lldb] Import ObjectiveC module instead of Foundation in test (NFC) from [lldb] Import ObjectiveC module instead of Foundation in test to [lldb] Import ObjectiveC module instead of Foundation in test (NFC).
Sun, Apr 4, 2:51 PM · Restricted Project
kastiglione requested review of D99859: [lldb] Import ObjectiveC module instead of Foundation in test (NFC).
Sun, Apr 4, 8:31 AM · Restricted Project

Fri, Apr 2

kastiglione requested review of D99825: [cmake] Enable -Werror=return-type for clang.
Fri, Apr 2, 5:58 PM · Restricted Project

Thu, Apr 1

kastiglione committed rG0c653d4c3d14: [lldb] Update test.rst with a paragraph about pdb (authored by kastiglione).
[lldb] Update test.rst with a paragraph about pdb
Thu, Apr 1, 9:53 AM
kastiglione closed D99744: [lldb] Update test.rst with a paragraph about pdb.
Thu, Apr 1, 9:53 AM · Restricted Project
kastiglione updated the diff for D99744: [lldb] Update test.rst with a paragraph about pdb.

s/lldb alias/pdb alias

Thu, Apr 1, 9:47 AM · Restricted Project
kastiglione added inline comments to D99744: [lldb] Update test.rst with a paragraph about pdb.
Thu, Apr 1, 9:43 AM · Restricted Project
kastiglione updated the diff for D99744: [lldb] Update test.rst with a paragraph about pdb.

Indent source block

Thu, Apr 1, 9:43 AM · Restricted Project
kastiglione requested review of D99744: [lldb] Update test.rst with a paragraph about pdb.
Thu, Apr 1, 9:31 AM · Restricted Project

Wed, Mar 31

kastiglione added inline comments to D99693: Update the linkage name of coro-split functions where applicable.
Wed, Mar 31, 5:07 PM · Restricted Project

Mon, Mar 29

kastiglione committed rG50a6aa6c0f6d: [llvm][utils] Fix handling of llvm::None (authored by kastiglione).
[llvm][utils] Fix handling of llvm::None
Mon, Mar 29, 5:44 PM

Mon, Mar 22

kastiglione accepted D99077: [ASTImporter] Fix import of ObjCPropertyDecl that share the same name.

nice fix!

Mon, Mar 22, 8:08 AM · Restricted Project

Fri, Mar 19

kastiglione accepted D98879: [lldb/PlatformPOSIX] Change LoadImage default to RTLD_LAZY.

🚢

Fri, Mar 19, 2:53 PM · Restricted Project
kastiglione added inline comments to D98879: [lldb/PlatformPOSIX] Change LoadImage default to RTLD_LAZY.
Fri, Mar 19, 1:17 PM · Restricted Project

Tue, Mar 16

kastiglione added inline comments to D98653: [lldb] Refactor variable paths to support languages with non-pointer "this" (NFC).
Tue, Mar 16, 11:22 AM · Restricted Project

Mon, Mar 15

kastiglione added inline comments to D98653: [lldb] Refactor variable paths to support languages with non-pointer "this" (NFC).
Mon, Mar 15, 3:03 PM · Restricted Project
kastiglione retitled D98653: [lldb] Refactor variable paths to support languages with non-pointer "this" (NFC) from [lldb] Refactor to support non-pointer instance variables (NFC) to [lldb] Refactor variable paths to support languages with non-pointer "this" (NFC).
Mon, Mar 15, 1:07 PM · Restricted Project
kastiglione updated the summary of D98653: [lldb] Refactor variable paths to support languages with non-pointer "this" (NFC).
Mon, Mar 15, 12:57 PM · Restricted Project
kastiglione requested review of D98653: [lldb] Refactor variable paths to support languages with non-pointer "this" (NFC).
Mon, Mar 15, 12:51 PM · Restricted Project

Mar 12 2021

kastiglione committed rGf3b07f9c5d97: [lldb] Remove unused StackFrame::TrackGlobalVariable (authored by kastiglione).
[lldb] Remove unused StackFrame::TrackGlobalVariable
Mar 12 2021, 8:51 AM

Mar 10 2021

kastiglione added a comment to D98224: [cmake] Enable -Werror=return-type.

@xbolva00 yes I plan to do that. I'll quickly check into the gcc situation first, and but may just re-enable it for clang.

Mar 10 2021, 3:11 PM · Restricted Project
kastiglione added a comment to D98224: [cmake] Enable -Werror=return-type.

Reverted because some versions of gcc can emit -Wreturn-type warnings on functions that have exhaustive switches over enums. A fix is to use llvm_unreachable but that's not currently done everywhere (and also seems like a poor/unnecessary practice).

Mar 10 2021, 2:50 PM · Restricted Project
kastiglione added a reverting change for rGce94a161651d: [cmake] Enable -Werror=return-type: rG683e89722aa0: Revert "[cmake] Enable -Werror=return-type".
Mar 10 2021, 2:47 PM
kastiglione committed rG683e89722aa0: Revert "[cmake] Enable -Werror=return-type" (authored by kastiglione).
Revert "[cmake] Enable -Werror=return-type"
Mar 10 2021, 2:47 PM
kastiglione added a reverting change for D98224: [cmake] Enable -Werror=return-type: rG683e89722aa0: Revert "[cmake] Enable -Werror=return-type".
Mar 10 2021, 2:47 PM · Restricted Project
kastiglione committed rGdaf36998694f: [lldb] Ignore linkage diagnostic for LLDBSwigPythonBreakpointCallbackFunction… (authored by kastiglione).
[lldb] Ignore linkage diagnostic for LLDBSwigPythonBreakpointCallbackFunction…
Mar 10 2021, 2:16 PM
kastiglione closed D98368: [lldb] Ignore linkage diagnostic for LLDBSwigPythonBreakpointCallbackFunction (NFC).
Mar 10 2021, 2:16 PM · Restricted Project
kastiglione requested review of D98368: [lldb] Ignore linkage diagnostic for LLDBSwigPythonBreakpointCallbackFunction (NFC).
Mar 10 2021, 12:51 PM · Restricted Project
kastiglione committed rG354d10530d26: [lldb] Fix PushPlan to set subplan to private (authored by kastiglione).
[lldb] Fix PushPlan to set subplan to private
Mar 10 2021, 11:06 AM
kastiglione closed D96916: [lldb] Fix PushPlan to set subplan to private.
Mar 10 2021, 11:06 AM · Restricted Project
kastiglione added a comment to D96916: [lldb] Fix PushPlan to set subplan to private.

Jim previously approved this offline.

Mar 10 2021, 11:04 AM · Restricted Project

Mar 9 2021

kastiglione committed rGce94a161651d: [cmake] Enable -Werror=return-type (authored by kastiglione).
[cmake] Enable -Werror=return-type
Mar 9 2021, 1:51 PM
kastiglione closed D98224: [cmake] Enable -Werror=return-type.
Mar 9 2021, 1:51 PM · Restricted Project
kastiglione added a comment to rGa2a55def354d: Move llvm/Analysis/ObjCARCUtil.h to IR to fix layering..

thanks. I reverted my module change 736afe465f4216f55372a907d7288910f9de6bea

Mar 9 2021, 9:37 AM
kastiglione added a reverting change for rGf1b690598eec: [build][modules] Fix ObjCARCUtil.h modularization: rG736afe465f42: Revert "[build][modules] Fix ObjCARCUtil.h modularization".
Mar 9 2021, 9:37 AM
kastiglione committed rG736afe465f42: Revert "[build][modules] Fix ObjCARCUtil.h modularization" (authored by kastiglione).
Revert "[build][modules] Fix ObjCARCUtil.h modularization"
Mar 9 2021, 9:37 AM

Mar 8 2021

kastiglione committed rG1200f85818d1: [lldb] Remove duplicated ThreadPlanStepOverBreakpoint comment (authored by kastiglione).
[lldb] Remove duplicated ThreadPlanStepOverBreakpoint comment
Mar 8 2021, 10:35 PM
kastiglione requested review of D98224: [cmake] Enable -Werror=return-type.
Mar 8 2021, 5:06 PM · Restricted Project
kastiglione added a comment to rGa2a55def354d: Move llvm/Analysis/ObjCARCUtil.h to IR to fix layering..

I pushed f1b690598eeca0568e39134f28e0a59c1c1f3598 as a fix or temporary fix.

Mar 8 2021, 3:52 PM
kastiglione committed rGf1b690598eec: [build][modules] Fix ObjCARCUtil.h modularization (authored by kastiglione).
[build][modules] Fix ObjCARCUtil.h modularization
Mar 8 2021, 3:52 PM

Mar 7 2021

kastiglione added a comment to D70638: [Diagnostic] add a warning which warns about misleading indentation.

@Tyker Hi, I noticed a case that isn't caught by -Wmisleading-indentation. In code that uses two space indents, there's a corner case that isn't caught when the preceding if uses curly braces. I've noticed a couple instances of this in lldb.

Mar 7 2021, 12:00 PM · Restricted Project

Mar 4 2021

kastiglione committed rGe7361c8eccb7: [lldb] Rename QueueFundamentalPlan to QueueBasePlan (NFC) (authored by kastiglione).
[lldb] Rename QueueFundamentalPlan to QueueBasePlan (NFC)
Mar 4 2021, 9:48 PM
kastiglione closed D97985: [lldb] Rename QueueFundamentalPlan to QueueBasePlan (NFC).
Mar 4 2021, 9:48 PM · Restricted Project
kastiglione requested review of D97985: [lldb] Rename QueueFundamentalPlan to QueueBasePlan (NFC).
Mar 4 2021, 2:56 PM · Restricted Project

Feb 26 2021

kastiglione added inline comments to D97525: [llvm][utils] Support dereferencing llvm::Optional lldb formatter.
Feb 26 2021, 8:13 AM · Restricted Project
kastiglione committed rGa01a406bba8a: [llvm][utils] Fix innocuous off by one in lldb formatters (authored by kastiglione).
[llvm][utils] Fix innocuous off by one in lldb formatters
Feb 26 2021, 8:11 AM
kastiglione committed rG8d1b6afcea6c: [llvm][utils] Rename lldb dict variables to internal_dict (authored by kastiglione).
[llvm][utils] Rename lldb dict variables to internal_dict
Feb 26 2021, 7:47 AM
kastiglione added a comment to D97525: [llvm][utils] Support dereferencing llvm::Optional lldb formatter.

internal_dict renames done in 8d1b6afcea6c30db7728d966d9281ab373eaa9e1

Feb 26 2021, 7:47 AM · Restricted Project
kastiglione committed rG408456f53ecc: [llvm][utils] Support dereferencing llvm::Optional lldb formatter (authored by kastiglione).
[llvm][utils] Support dereferencing llvm::Optional lldb formatter
Feb 26 2021, 7:44 AM
kastiglione closed D97525: [llvm][utils] Support dereferencing llvm::Optional lldb formatter.
Feb 26 2021, 7:43 AM · Restricted Project
kastiglione updated the diff for D97525: [llvm][utils] Support dereferencing llvm::Optional lldb formatter.

back out dict renames

Feb 26 2021, 7:42 AM · Restricted Project
kastiglione updated the diff for D97525: [llvm][utils] Support dereferencing llvm::Optional lldb formatter.

fix docstring

Feb 26 2021, 7:39 AM · Restricted Project
kastiglione committed rG3a677b29a3b3: [lldb] Add deref support to libc++ unique_ptr synthetic (authored by kastiglione).
[lldb] Add deref support to libc++ unique_ptr synthetic
Feb 26 2021, 7:39 AM
kastiglione closed D97524: [lldb] Add deref support to libc++ unique_ptr synthetic.
Feb 26 2021, 7:39 AM · Restricted Project
kastiglione added a comment to D97525: [llvm][utils] Support dereferencing llvm::Optional lldb formatter.

@teemperor I switched dict to internal_dict because more code uses internal_dict, and because variables named dict shadow the dict constructor. The dict constructor isn't used, but I think it's better to avoid shadowing it.

Feb 26 2021, 7:37 AM · Restricted Project

Feb 25 2021

kastiglione updated the summary of D97524: [lldb] Add deref support to libc++ unique_ptr synthetic.
Feb 25 2021, 9:45 PM · Restricted Project
kastiglione requested review of D97525: [llvm][utils] Support dereferencing llvm::Optional lldb formatter.
Feb 25 2021, 8:22 PM · Restricted Project
kastiglione added a comment to D97524: [lldb] Add deref support to libc++ unique_ptr synthetic.

There's pretty much nothing new here compared D97165.

Feb 25 2021, 8:12 PM · Restricted Project
kastiglione updated the summary of D97524: [lldb] Add deref support to libc++ unique_ptr synthetic.
Feb 25 2021, 8:10 PM · Restricted Project
kastiglione requested review of D97524: [lldb] Add deref support to libc++ unique_ptr synthetic.
Feb 25 2021, 8:10 PM · Restricted Project

Feb 24 2021

kastiglione added inline comments to D97239: [profile] Fix buffer overrun when parsing %c in filename string.
Feb 24 2021, 2:46 PM · Restricted Project
kastiglione accepted D97239: [profile] Fix buffer overrun when parsing %c in filename string.
Feb 24 2021, 2:45 PM · Restricted Project
kastiglione added inline comments to D97239: [profile] Fix buffer overrun when parsing %c in filename string.
Feb 24 2021, 2:27 PM · Restricted Project

Feb 23 2021

kastiglione committed rG0ac42fd26d73: [lldb] Add deref support and tests to shared_ptr synthetic (authored by kastiglione).
[lldb] Add deref support and tests to shared_ptr synthetic
Feb 23 2021, 9:04 AM
kastiglione closed D97165: [lldb] Add deref support and tests to shared_ptr synthetic.
Feb 23 2021, 9:04 AM · Restricted Project
kastiglione updated the diff for D97165: [lldb] Add deref support and tests to shared_ptr synthetic.

check ptr_sp before use

Feb 23 2021, 9:01 AM · Restricted Project

Feb 22 2021

kastiglione accepted D97235: [lldb] Reinstate support for LLDB_VERSION_STRING.

thanks

Feb 22 2021, 3:58 PM · Restricted Project
kastiglione added inline comments to D97165: [lldb] Add deref support and tests to shared_ptr synthetic.
Feb 22 2021, 1:19 PM · Restricted Project
kastiglione updated the diff for D97165: [lldb] Add deref support and tests to shared_ptr synthetic.

test for null using SBValue.unsigned

Feb 22 2021, 1:18 PM · Restricted Project
kastiglione updated the diff for D97165: [lldb] Add deref support and tests to shared_ptr synthetic.

minor fix

Feb 22 2021, 11:58 AM · Restricted Project
kastiglione updated the diff for D97165: [lldb] Add deref support and tests to shared_ptr synthetic.

Use expect_var_path and fix other issues with the tests

Feb 22 2021, 11:57 AM · Restricted Project
kastiglione added a comment to D97199: [lldb][NFC] Cleanup ValueObject construction code.

nice, deferring to Jonas to accept

Feb 22 2021, 10:55 AM · Restricted Project
kastiglione added inline comments to D97165: [lldb] Add deref support and tests to shared_ptr synthetic.
Feb 22 2021, 8:38 AM · Restricted Project

Feb 21 2021

kastiglione updated the summary of D97165: [lldb] Add deref support and tests to shared_ptr synthetic.
Feb 21 2021, 7:37 PM · Restricted Project
kastiglione added inline comments to D97165: [lldb] Add deref support and tests to shared_ptr synthetic.
Feb 21 2021, 3:06 PM · Restricted Project
kastiglione updated the summary of D97165: [lldb] Add deref support and tests to shared_ptr synthetic.
Feb 21 2021, 3:02 PM · Restricted Project
kastiglione requested review of D97165: [lldb] Add deref support and tests to shared_ptr synthetic.
Feb 21 2021, 2:53 PM · Restricted Project

Feb 20 2021

kastiglione committed rGb0186c25c62e: [lldb] Refine ThreadPlan::ShouldAutoContinue (authored by kastiglione).
[lldb] Refine ThreadPlan::ShouldAutoContinue
Feb 20 2021, 5:26 PM
kastiglione closed D97076: [lldb] Refine ThreadPlan::ShouldAutoContinue.
Feb 20 2021, 5:25 PM · Restricted Project

Feb 19 2021

kastiglione added a comment to D97076: [lldb] Refine ThreadPlan::ShouldAutoContinue.

Good call on calling ShouldAutoContinue before Pop.

Feb 19 2021, 4:49 PM · Restricted Project
kastiglione committed rG9d3b9e5799f6: [lldb] Rename {stop,run}_vote to report_{stop,run}_vote (authored by kastiglione).
[lldb] Rename {stop,run}_vote to report_{stop,run}_vote
Feb 19 2021, 1:05 PM
kastiglione closed D96917: [lldb] Rename {stop,run}_vote to report_{stop,run}_vote (NFC).
Feb 19 2021, 1:05 PM · Restricted Project
kastiglione updated the summary of D97076: [lldb] Refine ThreadPlan::ShouldAutoContinue.
Feb 19 2021, 12:20 PM · Restricted Project
kastiglione added inline comments to D97076: [lldb] Refine ThreadPlan::ShouldAutoContinue.
Feb 19 2021, 12:18 PM · Restricted Project
kastiglione requested review of D97076: [lldb] Refine ThreadPlan::ShouldAutoContinue.
Feb 19 2021, 12:09 PM · Restricted Project

Feb 17 2021

kastiglione retitled D96917: [lldb] Rename {stop,run}_vote to report_{stop,run}_vote (NFC) from [lldb] Rename {stop,run}_vote to report_{stop,run}_vote to [lldb] Rename {stop,run}_vote to report_{stop,run}_vote (NFC).
Feb 17 2021, 6:12 PM · Restricted Project
kastiglione requested review of D96917: [lldb] Rename {stop,run}_vote to report_{stop,run}_vote (NFC).
Feb 17 2021, 4:33 PM · Restricted Project
kastiglione requested review of D96916: [lldb] Fix PushPlan to set subplan to private.
Feb 17 2021, 4:30 PM · Restricted Project