This is an archive of the discontinued LLVM Phabricator instance.

[lldb/win] Fix TestIRMemoryMapWindows.test when running tests in git bash
ClosedPublic

Authored by thakis on Sep 15 2021, 8:43 AM.

Details

Summary

lit.util.which('link') picks up the wrong link.exe in git bash, leading
to this error:

# command stderr:
/usr/bin/link: extra operand '/LIBPATH:C:\\Program Files (x86)\\Windows Kits\\10\\lib\\10.0.17763.0\\ucrt\\x64'
Try '/usr/bin/link --help' for more information.

Instead, assume that link.exe is next to cl.exe.

Diff Detail

Event Timeline

thakis created this revision.Sep 15 2021, 8:43 AM
thakis requested review of this revision.Sep 15 2021, 8:43 AM
thakis edited the summary of this revision. (Show Details)
thakis edited the summary of this revision. (Show Details)
thakis added a project: Restricted Project.Sep 15 2021, 9:17 AM
labath accepted this revision.Sep 15 2021, 11:47 PM
This revision is now accepted and ready to land.Sep 15 2021, 11:47 PM