This is an archive of the discontinued LLVM Phabricator instance.

[lld] COFF: Fix bug involving archives defining a symbol multiple times.
ClosedPublic

Authored by pcc on Jul 6 2015, 6:36 PM.

Details

Summary

Previously we were unnecessarily loading lazy symbols if they appeared in an
archive multiple times, as can happen with comdat symbols. This change fixes
the bug by only loading symbols from archives at load time if the original
symbol was undefined.

Diff Detail

Event Timeline

pcc updated this revision to Diff 29141.Jul 6 2015, 6:36 PM
pcc retitled this revision from to [lld] COFF: Fix bug involving archives defining a symbol multiple times..
pcc updated this object.
pcc added a reviewer: ruiu.
pcc added a subscriber: llvm-commits.
ruiu accepted this revision.Jul 6 2015, 6:55 PM
ruiu edited edge metadata.

LGTM

This revision is now accepted and ready to land.Jul 6 2015, 6:55 PM
This revision was automatically updated to reflect the committed changes.