Page MenuHomePhabricator

[LNT] Fixed fieldchanges grouping to a regression
ClosedPublic

Authored by kpdev42 on Sep 3 2021, 2:31 AM.

Details

Summary

Note active_indicators is not a list of regression indicators. It is a list of fieldchanges actually.
After that fix all new fieldchanges will be grouped mostly in the same regression as expected.
It prevents creating of thousand new regressions and ageing them out immediately to keep regressions count under 50.

Diff Detail

Repository
rLNT LNT

Event Timeline

kpdev42 created this revision.Sep 3 2021, 2:31 AM
kpdev42 requested review of this revision.Sep 3 2021, 2:31 AM
thopre added inline comments.Sep 3 2021, 2:47 AM
lnt/server/db/fieldchange.py
269

Why is this change correct / needed?

slydiman added inline comments.
lnt/server/db/fieldchange.py
269

It seems 2 months ago it was a bug fix for missing session.flush() in line 175.
Now it is just a performance optimization.
Note the method new_regression() allows the fieldchange id (requires additional query to DB) or the fieldchange object itself (faster).

thopre accepted this revision.Sep 3 2021, 3:28 AM

LGTM with the description update

lnt/server/db/fieldchange.py
269

Ah I see. Would you mind mentioning it in the patch description?

This revision is now accepted and ready to land.Sep 3 2021, 3:28 AM

@slydiman Could you please commit this patch?

This revision was automatically updated to reflect the committed changes.
thopre added a comment.Sep 9 2021, 3:33 AM

@slydiman Could you please commit this patch?

I've landed it for you