This is an archive of the discontinued LLVM Phabricator instance.

Differential D108531

[DebugInfo] Use EndLabel for AsmStreamer
AbandonedPublic

Authored by kyulee on Aug 22 2021, 7:27 PM.

Details

Reviewers
None
Summary

This extends https://reviews.llvm.org/D108261 to apply AsmStreamer.

Depends on D108261.

Diff Detail

Event Timeline

kyulee created this revision.Aug 22 2021, 7:27 PM
Herald added a subscriber: hiraditya. · View Herald TranscriptAug 22 2021, 7:27 PM
kyulee requested review of this revision.Aug 22 2021, 7:27 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 22 2021, 7:27 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B120725: Diff 368022.Aug 22 2021, 8:14 PM
kyulee abandoned this revision.Nov 14 2021, 7:46 PM

Revision Contents

PathSize
llvm/
lib/
MC/
15 lines
test/
DebugInfo/
XCOFF/
8 lines
8 lines
8 lines

Diff 368022

llvm/lib/MC/MCAsmStreamer.cpp

Show First 20 Lines • Show All 2,410 Lines • ▼ Show 20 Linesvoid MCAsmStreamer::emitDwarfLineEndEntry(MCSection *Section,
// we currently use the .text end label as any section end. This will not // we currently use the .text end label as any section end. This will not
// impact the debugability as we will jump to the caller of the last function // impact the debugability as we will jump to the caller of the last function
// in the section before we come into the .text end address. // in the section before we come into the .text end address.
assert(!MAI->usesDwarfFileAndLocDirectives() && assert(!MAI->usesDwarfFileAndLocDirectives() &&
".loc should not be generated together with raw data!"); ".loc should not be generated together with raw data!");
MCContext &Ctx = getContext(); MCContext &Ctx = getContext();
// FIXME: use section end symbol as end of the Section. We need to consider // When EndLabel is null (from AsmParser), conservatively Text section end
// the explicit sections and -ffunction-sections when we try to generate or // symbol as EndLabel.
// find section end symbol for the Section. if (!EndLabel) {
MCSection *TextSection = Ctx.getObjectFileInfo()->getTextSection(); MCSection *TextSection = Ctx.getObjectFileInfo()->getTextSection();
assert(TextSection->hasEnded() && ".text section is not end!"); assert(TextSection->hasEnded() && ".text section is not end!");
MCSymbol *SectionEnd = TextSection->getEndSymbol(Ctx); EndLabel = TextSection->getEndSymbol(Ctx);
}
const MCAsmInfo *AsmInfo = Ctx.getAsmInfo(); const MCAsmInfo *AsmInfo = Ctx.getAsmInfo();
emitDwarfAdvanceLineAddr(INT64_MAX, LastLabel, SectionEnd, emitDwarfAdvanceLineAddr(INT64_MAX, LastLabel, EndLabel,
AsmInfo->getCodePointerSize()); AsmInfo->getCodePointerSize());
} }
// Generate DWARF line sections for assembly mode without .loc/.file // Generate DWARF line sections for assembly mode without .loc/.file
void MCAsmStreamer::emitDwarfAdvanceLineAddr(int64_t LineDelta, void MCAsmStreamer::emitDwarfAdvanceLineAddr(int64_t LineDelta,
const MCSymbol *LastLabel, const MCSymbol *LastLabel,
const MCSymbol *Label, const MCSymbol *Label,
unsigned PointerSize) { unsigned PointerSize) {
▲ Show 20 Lines • Show All 59 Lines • Show Last 20 Lines

llvm/test/DebugInfo/XCOFF/empty.ll

Show First 20 Lines • Show All 219 Lines • ▼ Show 20 Lines
; ASM32-NEXT: .byte 10 ; ASM32-NEXT: .byte 10
; ASM32-NEXT: .byte 0 # Set address to L..tmp2 ; ASM32-NEXT: .byte 0 # Set address to L..tmp2
; ASM32-NEXT: .byte 5 ; ASM32-NEXT: .byte 5
; ASM32-NEXT: .byte 2 ; ASM32-NEXT: .byte 2
; ASM32-NEXT: .vbyte 4, L..tmp2 ; ASM32-NEXT: .vbyte 4, L..tmp2
; ASM32-NEXT: .byte 3 # Advance line 1 ; ASM32-NEXT: .byte 3 # Advance line 1
; ASM32-NEXT: .byte 1 ; ASM32-NEXT: .byte 1
; ASM32-NEXT: .byte 1 ; ASM32-NEXT: .byte 1
; ASM32-NEXT: .byte 0 # Set address to L..sec_end0 ; ASM32-NEXT: .byte 0 # Set address to L..func_end0
; ASM32-NEXT: .byte 5 ; ASM32-NEXT: .byte 5
; ASM32-NEXT: .byte 2 ; ASM32-NEXT: .byte 2
; ASM32-NEXT: .vbyte 4, L..sec_end0 ; ASM32-NEXT: .vbyte 4, L..func_end0
; ASM32-NEXT: .byte 0 # End sequence ; ASM32-NEXT: .byte 0 # End sequence
; ASM32-NEXT: .byte 1 ; ASM32-NEXT: .byte 1
; ASM32-NEXT: .byte 1 ; ASM32-NEXT: .byte 1
; ASM32-NEXT: L..debug_line_end0: ; ASM32-NEXT: L..debug_line_end0:
; ASM64: .csect .text[PR],2 ; ASM64: .csect .text[PR],2
; ASM64-NEXT: .file "1.c" ; ASM64-NEXT: .file "1.c"
; ASM64-NEXT: .globl main[DS] # -- Begin function main ; ASM64-NEXT: .globl main[DS] # -- Begin function main
▲ Show 20 Lines • Show All 181 Lines • ▼ Show 20 Lines
; ASM64-NEXT: .byte 10 ; ASM64-NEXT: .byte 10
; ASM64-NEXT: .byte 0 # Set address to L..tmp2 ; ASM64-NEXT: .byte 0 # Set address to L..tmp2
; ASM64-NEXT: .byte 9 ; ASM64-NEXT: .byte 9
; ASM64-NEXT: .byte 2 ; ASM64-NEXT: .byte 2
; ASM64-NEXT: .vbyte 8, L..tmp2 ; ASM64-NEXT: .vbyte 8, L..tmp2
; ASM64-NEXT: .byte 3 # Advance line 1 ; ASM64-NEXT: .byte 3 # Advance line 1
; ASM64-NEXT: .byte 1 ; ASM64-NEXT: .byte 1
; ASM64-NEXT: .byte 1 ; ASM64-NEXT: .byte 1
; ASM64-NEXT: .byte 0 # Set address to L..sec_end0 ; ASM64-NEXT: .byte 0 # Set address to L..func_end0
; ASM64-NEXT: .byte 9 ; ASM64-NEXT: .byte 9
; ASM64-NEXT: .byte 2 ; ASM64-NEXT: .byte 2
; ASM64-NEXT: .vbyte 8, L..sec_end0 ; ASM64-NEXT: .vbyte 8, L..func_end0
; ASM64-NEXT: .byte 0 # End sequence ; ASM64-NEXT: .byte 0 # End sequence
; ASM64-NEXT: .byte 1 ; ASM64-NEXT: .byte 1
; ASM64-NEXT: .byte 1 ; ASM64-NEXT: .byte 1
; ASM64-NEXT: L..debug_line_end0: ; ASM64-NEXT: L..debug_line_end0:

llvm/test/DebugInfo/XCOFF/explicit-section.ll

Show First 20 Lines • Show All 290 Lines • ▼ Show 20 Lines
; CHECK-NEXT: .byte 10 ; CHECK-NEXT: .byte 10
; CHECK-NEXT: .byte 0 # Set address to L..tmp1 ; CHECK-NEXT: .byte 0 # Set address to L..tmp1
; CHECK-NEXT: .byte 5 ; CHECK-NEXT: .byte 5
; CHECK-NEXT: .byte 2 ; CHECK-NEXT: .byte 2
; CHECK-NEXT: .vbyte 4, L..tmp1 ; CHECK-NEXT: .vbyte 4, L..tmp1
; CHECK-NEXT: .byte 3 # Advance line 0 ; CHECK-NEXT: .byte 3 # Advance line 0
; CHECK-NEXT: .byte 0 ; CHECK-NEXT: .byte 0
; CHECK-NEXT: .byte 1 ; CHECK-NEXT: .byte 1
; CHECK-NEXT: .byte 0 # Set address to L..sec_end0 ; CHECK-NEXT: .byte 0 # Set address to L..func_end0
; CHECK-NEXT: .byte 5 ; CHECK-NEXT: .byte 5
; CHECK-NEXT: .byte 2 ; CHECK-NEXT: .byte 2
; CHECK-NEXT: .vbyte 4, L..sec_end0 ; CHECK-NEXT: .vbyte 4, L..func_end0
; CHECK-NEXT: .byte 0 # End sequence ; CHECK-NEXT: .byte 0 # End sequence
; CHECK-NEXT: .byte 1 ; CHECK-NEXT: .byte 1
; CHECK-NEXT: .byte 1 ; CHECK-NEXT: .byte 1
; CHECK-NEXT: .byte 0 # Set address to L..tmp3 ; CHECK-NEXT: .byte 0 # Set address to L..tmp3
; CHECK-NEXT: .byte 5 ; CHECK-NEXT: .byte 5
; CHECK-NEXT: .byte 2 ; CHECK-NEXT: .byte 2
; CHECK-NEXT: .vbyte 4, L..tmp3 ; CHECK-NEXT: .vbyte 4, L..tmp3
; CHECK-NEXT: .byte 19 # Start sequence ; CHECK-NEXT: .byte 19 # Start sequence
Show All 12 Lines
; CHECK-NEXT: .byte 6 ; CHECK-NEXT: .byte 6
; CHECK-NEXT: .byte 0 # Set address to L..tmp6 ; CHECK-NEXT: .byte 0 # Set address to L..tmp6
; CHECK-NEXT: .byte 5 ; CHECK-NEXT: .byte 5
; CHECK-NEXT: .byte 2 ; CHECK-NEXT: .byte 2
; CHECK-NEXT: .vbyte 4, L..tmp6 ; CHECK-NEXT: .vbyte 4, L..tmp6
; CHECK-NEXT: .byte 3 # Advance line 0 ; CHECK-NEXT: .byte 3 # Advance line 0
; CHECK-NEXT: .byte 0 ; CHECK-NEXT: .byte 0
; CHECK-NEXT: .byte 1 ; CHECK-NEXT: .byte 1
; CHECK-NEXT: .byte 0 # Set address to L..sec_end0 ; CHECK-NEXT: .byte 0 # Set address to L..func_end1
; CHECK-NEXT: .byte 5 ; CHECK-NEXT: .byte 5
; CHECK-NEXT: .byte 2 ; CHECK-NEXT: .byte 2
; CHECK-NEXT: .vbyte 4, L..sec_end0 ; CHECK-NEXT: .vbyte 4, L..func_end1
; CHECK-NEXT: .byte 0 # End sequence ; CHECK-NEXT: .byte 0 # End sequence
; CHECK-NEXT: .byte 1 ; CHECK-NEXT: .byte 1
; CHECK-NEXT: .byte 1 ; CHECK-NEXT: .byte 1
; CHECK-NEXT: L..debug_line_end0: ; CHECK-NEXT: L..debug_line_end0:

llvm/test/DebugInfo/XCOFF/function-sections.ll

Show First 20 Lines • Show All 277 Lines • ▼ Show 20 Lines
; CHECK-NEXT: .byte 10 ; CHECK-NEXT: .byte 10
; CHECK-NEXT: .byte 0 # Set address to L..tmp1 ; CHECK-NEXT: .byte 0 # Set address to L..tmp1
; CHECK-NEXT: .byte 5 ; CHECK-NEXT: .byte 5
; CHECK-NEXT: .byte 2 ; CHECK-NEXT: .byte 2
; CHECK-NEXT: .vbyte 4, L..tmp1 ; CHECK-NEXT: .vbyte 4, L..tmp1
; CHECK-NEXT: .byte 3 # Advance line 1 ; CHECK-NEXT: .byte 3 # Advance line 1
; CHECK-NEXT: .byte 1 ; CHECK-NEXT: .byte 1
; CHECK-NEXT: .byte 1 ; CHECK-NEXT: .byte 1
; CHECK-NEXT: .byte 0 # Set address to L..sec_end0 ; CHECK-NEXT: .byte 0 # Set address to L..func_end0
; CHECK-NEXT: .byte 5 ; CHECK-NEXT: .byte 5
; CHECK-NEXT: .byte 2 ; CHECK-NEXT: .byte 2
; CHECK-NEXT: .vbyte 4, L..sec_end0 ; CHECK-NEXT: .vbyte 4, L..func_end0
; CHECK-NEXT: .byte 0 # End sequence ; CHECK-NEXT: .byte 0 # End sequence
; CHECK-NEXT: .byte 1 ; CHECK-NEXT: .byte 1
; CHECK-NEXT: .byte 1 ; CHECK-NEXT: .byte 1
; CHECK-NEXT: .byte 0 # Set address to L..tmp3 ; CHECK-NEXT: .byte 0 # Set address to L..tmp3
; CHECK-NEXT: .byte 5 ; CHECK-NEXT: .byte 5
; CHECK-NEXT: .byte 2 ; CHECK-NEXT: .byte 2
; CHECK-NEXT: .vbyte 4, L..tmp3 ; CHECK-NEXT: .vbyte 4, L..tmp3
; CHECK-NEXT: .byte 24 # Start sequence ; CHECK-NEXT: .byte 24 # Start sequence
; CHECK-NEXT: .byte 5 ; CHECK-NEXT: .byte 5
; CHECK-NEXT: .byte 3 ; CHECK-NEXT: .byte 3
; CHECK-NEXT: .byte 10 ; CHECK-NEXT: .byte 10
; CHECK-NEXT: .byte 0 # Set address to L..tmp4 ; CHECK-NEXT: .byte 0 # Set address to L..tmp4
; CHECK-NEXT: .byte 5 ; CHECK-NEXT: .byte 5
; CHECK-NEXT: .byte 2 ; CHECK-NEXT: .byte 2
; CHECK-NEXT: .vbyte 4, L..tmp4 ; CHECK-NEXT: .vbyte 4, L..tmp4
; CHECK-NEXT: .byte 3 # Advance line 1 ; CHECK-NEXT: .byte 3 # Advance line 1
; CHECK-NEXT: .byte 1 ; CHECK-NEXT: .byte 1
; CHECK-NEXT: .byte 1 ; CHECK-NEXT: .byte 1
; CHECK-NEXT: .byte 0 # Set address to L..sec_end0 ; CHECK-NEXT: .byte 0 # Set address to L..func_end1
; CHECK-NEXT: .byte 5 ; CHECK-NEXT: .byte 5
; CHECK-NEXT: .byte 2 ; CHECK-NEXT: .byte 2
; CHECK-NEXT: .vbyte 4, L..sec_end0 ; CHECK-NEXT: .vbyte 4, L..func_end1
; CHECK-NEXT: .byte 0 # End sequence ; CHECK-NEXT: .byte 0 # End sequence
; CHECK-NEXT: .byte 1 ; CHECK-NEXT: .byte 1
; CHECK-NEXT: .byte 1 ; CHECK-NEXT: .byte 1
; CHECK-NEXT: L..debug_line_end0: ; CHECK-NEXT: L..debug_line_end0: