Page MenuHomePhabricator

kyulee (Kyungwoo Lee)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 22 2019, 1:52 PM (65 w, 5 d)

Recent Activity

Tue, Nov 10

kyulee updated the diff for D76570: [AArch64] Homogeneous Prolog and Epilog for Size Optimization.

Reabse

Tue, Nov 10, 5:39 PM · Restricted Project
kyulee updated the diff for D76570: [AArch64] Homogeneous Prolog and Epilog for Size Optimization.

I would appreciate if anyone can review this.

Tue, Nov 10, 5:32 PM · Restricted Project

Oct 23 2020

kyulee added a comment to D76570: [AArch64] Homogeneous Prolog and Epilog for Size Optimization.

@efriedma Could you have a chance to take a look this again?

Oct 23 2020, 2:12 PM · Restricted Project
kyulee updated the diff for D76570: [AArch64] Homogeneous Prolog and Epilog for Size Optimization.

Rebase

Oct 23 2020, 2:09 PM · Restricted Project

Oct 5 2020

kyulee updated the diff for D76570: [AArch64] Homogeneous Prolog and Epilog for Size Optimization.

This rewrites the helper functions:

  • One SP Adjustment to reduce micro-opts for the better perf.
  • Align Linux/Darwin implementation in the same way . X29/X30 is stored at the call-site and that stack space is skipped in the prolog helper.
  • Add some comments and expand the enabling check.
Oct 5 2020, 10:56 AM · Restricted Project

Oct 1 2020

kyulee added a comment to D76570: [AArch64] Homogeneous Prolog and Epilog for Size Optimization.

@efriedma Unlike other work that uses a helper call to runtime library, this work synthesizes outlined functions with a custom-calling convention. This is handy and flexible to extend this logic for other patterns or purposes like instrumentation, etc inside the helper within the compiler.

Oct 1 2020, 9:21 AM · Restricted Project

Sep 24 2020

kyulee added a comment to D87953: [xray] Function coverage groups.

I think it looks good to me. @MaskRay Any further feedback on this?

Sep 24 2020, 9:47 AM · Restricted Project, Restricted Project

Sep 20 2020

kyulee added inline comments to D87953: [xray] Function coverage groups.
Sep 20 2020, 11:14 AM · Restricted Project, Restricted Project

Aug 18 2020

kyulee updated the diff for D85586: Force Remove Attribute.

Rebase and add more tests.

Aug 18 2020, 2:47 PM · Restricted Project

Aug 14 2020

kyulee updated the diff for D85586: Force Remove Attribute.

Rebase.

Aug 14 2020, 7:53 AM · Restricted Project

Aug 11 2020

kyulee added a comment to D85793: [NFC] Factor out hasForceAttributes.

@plotfi Can you commit this for me? Thanks in advance!

Aug 11 2020, 3:51 PM · Restricted Project
kyulee retitled D85586: Force Remove Attribute from Force Function Attributes to Force Remove Attribute.
Aug 11 2020, 3:50 PM · Restricted Project
kyulee updated the diff for D85586: Force Remove Attribute.
  • Preserve the original flag -force-attribute
  • Factor out hasForceAttributes into D85793
Aug 11 2020, 3:48 PM · Restricted Project
kyulee added reviewers for D85793: [NFC] Factor out hasForceAttributes: plotfi, lanza, jmolloy, chandlerc.
Aug 11 2020, 3:46 PM · Restricted Project
kyulee requested review of D85793: [NFC] Factor out hasForceAttributes.
Aug 11 2020, 3:34 PM · Restricted Project
kyulee added inline comments to D85586: Force Remove Attribute.
Aug 11 2020, 11:13 AM · Restricted Project
kyulee updated the diff for D85586: Force Remove Attribute.

Fix typos from the feedback.

Aug 11 2020, 11:04 AM · Restricted Project

Aug 10 2020

kyulee added a comment to D85586: Force Remove Attribute.

Kindly ping.. This patch is convenient to chase down an issue by adding as well as removing an attribute of the function.

Aug 10 2020, 5:55 PM · Restricted Project
kyulee added a reviewer for D85586: Force Remove Attribute: lanza.
Aug 10 2020, 5:53 PM · Restricted Project

Aug 8 2020

kyulee updated the diff for D85586: Force Remove Attribute.

Fix case style for ParseFunctionAndAttr

Aug 8 2020, 3:28 PM · Restricted Project
kyulee updated the summary of D85586: Force Remove Attribute.
Aug 8 2020, 1:04 PM · Restricted Project
kyulee added reviewers for D85586: Force Remove Attribute: chandlerc, plotfi.
Aug 8 2020, 1:03 PM · Restricted Project
kyulee requested review of D85586: Force Remove Attribute.
Aug 8 2020, 12:59 PM · Restricted Project

Jul 16 2020

kyulee updated the diff for D76570: [AArch64] Homogeneous Prolog and Epilog for Size Optimization.

Fix for Outlined Epilog for a Tail-Call

Jul 16 2020, 1:19 AM · Restricted Project

Jul 15 2020

kyulee added inline comments to D83923: [MachineOutliner][AArch64] WA for cases where AArch64 Outliner needs to do more than one stack fixup..
Jul 15 2020, 6:48 PM · Restricted Project

Jul 14 2020

kyulee added a comment to D83464: [MachineOutliner][AArch64] Fix for noreturn functions.

@plotfi I hit this in an internal workload (-Oz -flto=thin), but it won't surprise if the same issue is in llvm-test-suite.

Jul 14 2020, 10:20 PM · Restricted Project

Jul 9 2020

kyulee added a reviewer for D83464: [MachineOutliner][AArch64] Fix for noreturn functions: plotfi.
Jul 9 2020, 9:09 PM · Restricted Project
kyulee updated the diff for D76570: [AArch64] Homogeneous Prolog and Epilog for Size Optimization.

rebase

Jul 9 2020, 9:08 PM · Restricted Project
kyulee updated the diff for D76570: [AArch64] Homogeneous Prolog and Epilog for Size Optimization.

Rebase after D83456

Jul 9 2020, 12:32 PM · Restricted Project
kyulee added reviewers for D83464: [MachineOutliner][AArch64] Fix for noreturn functions: paquette, tellenbach.
Jul 9 2020, 1:23 AM · Restricted Project
Herald added a project to D83464: [MachineOutliner][AArch64] Fix for noreturn functions: Restricted Project.
Jul 9 2020, 1:19 AM · Restricted Project
kyulee added inline comments to D76570: [AArch64] Homogeneous Prolog and Epilog for Size Optimization.
Jul 9 2020, 12:41 AM · Restricted Project
kyulee updated the diff for D76570: [AArch64] Homogeneous Prolog and Epilog for Size Optimization.

Fix for merge

Jul 9 2020, 12:39 AM · Restricted Project
kyulee updated the diff for D76570: [AArch64] Homogeneous Prolog and Epilog for Size Optimization.

Refactor getArgumentPopSize() to D83456
Add comment on producePairRegisters()

Jul 9 2020, 12:18 AM · Restricted Project
kyulee added reviewers for D83456: [NFC][AArch64] Refactor getArgumentPopSize: plotfi, dmgreen.
Jul 9 2020, 12:10 AM · Restricted Project
Herald added a project to D83456: [NFC][AArch64] Refactor getArgumentPopSize: Restricted Project.
Jul 9 2020, 12:08 AM · Restricted Project

Jul 7 2020

kyulee updated the diff for D76570: [AArch64] Homogeneous Prolog and Epilog for Size Optimization.

Updating for Linux support.

Jul 7 2020, 11:28 PM · Restricted Project

Mar 30 2020

kyulee added inline comments to D76570: [AArch64] Homogeneous Prolog and Epilog for Size Optimization.
Mar 30 2020, 10:49 AM · Restricted Project

Mar 22 2020

kyulee added reviewers for D76570: [AArch64] Homogeneous Prolog and Epilog for Size Optimization: dmgreen, gberry, t.p.northover.
Mar 22 2020, 11:45 AM · Restricted Project
kyulee created D76570: [AArch64] Homogeneous Prolog and Epilog for Size Optimization.
Mar 22 2020, 11:45 AM · Restricted Project

Aug 22 2019

kyulee created D66619: AArch64: Consistent Use of hasZeroCycleZeroingFPWorkaround.
Aug 22 2019, 2:15 PM · Restricted Project