This is an archive of the discontinued LLVM Phabricator instance.

Disabling of "redefine_extname" pragma for C++ code
ClosedPublic

Authored by andreybokhanko on Jun 29 2015, 8:13 AM.

Diff Detail

Event Timeline

andreybokhanko retitled this revision from to Disabling of "redefine_extname" pragma for C++ code.
andreybokhanko updated this object.
andreybokhanko edited the test plan for this revision. (Show Details)
andreybokhanko added a subscriber: Unknown Object (MLST).
rsmith edited edge metadata.Jul 8 2015, 2:55 PM

Just a couple of minor things, otherwise this looks good to me.

lib/Sema/SemaDecl.cpp
5534–5535

Drop the else here.

test/CodeGen/redefine_extname.c
29

This expected-warning does nothing, because you don't have a -verify RUN: line. This part of the test should be in test/Sema/something.

test/CodeGenCXX/redefine_extname.cpp
34

Likewise.

andreybokhanko edited edge metadata.

Fix Richard Smith's notes:

  1. "else" removed form isDeclExternC
  2. Two new Sema tests added: test/Sema/redefine_extname.c, test/SemaCXX/redefine_extname.cpp
andreybokhanko marked 3 inline comments as done.Jul 9 2015, 5:27 AM

All Richard Smith's notes are fixed.

This revision was automatically updated to reflect the committed changes.