[Bitcode][Asm] Read metadata value from operand bundles in and out

[necipfazil]

Summary

This revision does not contain any changes but how the expected changes
should be tested.

Metadata operand bundle value is garbage when LLVM IR is compiled to
bitcode, then disassembled back to LLVM IR, like the tests do in this
revision. Fixing the issue should have the tests pass.

[necipfazil]

Please mark the following bug report resolved when this is fixed: https://bugs.llvm.org/show_bug.cgi?id=51264

[morehouse]

Thanks for the tests. I guess we can't submit this patch until we have a fix.

Could you add a TODO in the new code (maybe https://reviews.llvm.org/D107038) that refers to the bug?

[necipfazil]

In D107039#2914224, @morehouse wrote:

Could you add a TODO in the new code (maybe https://reviews.llvm.org/D107038) that refers to the bug?

Done.

llvm/test/Bitcode/2021-07-22-Metadata-Operand-Bundles.ll

+; This test ensures that we get a metadata operand bundle value in and out.
+; RUN: llvm-as < %s | llvm-dis | FileCheck %s
+
+declare void @callee()
+
+; CHECK-LABEL: call_with_operand_bundle(
+define void @call_with_operand_bundle() {
+  ; CHECK: call void @op_bundle_callee() [ "op_type"(metadata !"metadata_string") ]
+  call void @callee() [ "op_type"(metadata !"metadata_string") ]
+
+  ret void
+}

llvm/test/Bitcode/compatibility.ll

  entry:
   %l = load i32, i32* %ptr
   %x = add i32 42, 1
   call void @op_bundle_callee_1(i32 10, i32 %x) [ "foo"(i32 42, i64 100, i32 %x), "foo"(i32 42, float  0.000000e+00, i32 %l) ]
 ; CHECK: call void @op_bundle_callee_1(i32 10, i32 %x) [ "foo"(i32 42, i64 100, i32 %x), "foo"(i32 42, float  0.000000e+00, i32 %l) ]
   ret void
 }
 
+define void @call_with_operand_bundle5(i32* %ptr) {
+; CHECK-LABEL: call_with_operand_bundle5(
+ entry:
+  call void @op_bundle_callee_0() [ "foo"(metadata !"metadata_string") ]
+; CHECK: call void @op_bundle_callee_0() [ "foo"(metadata !"metadata_string") ]
+  ret void
+}
+
 ; Invoke versions of the above tests:
 
 
 define void @invoke_with_operand_bundle0(i32* %ptr) personality i8 3 {
 ; CHECK-LABEL: @invoke_with_operand_bundle0(
  entry:
   %l = load i32, i32* %ptr
   %x = add i32 42, 1

 
 exception:
   %cleanup = landingpad i8 cleanup
   br label %normal
 normal:
   ret void
 }
 
+define void @invoke_with_operand_bundle5(i32* %ptr) personality i8 3 {
+; CHECK-LABEL: @invoke_with_operand_bundle5(
+ entry:
+  invoke void @op_bundle_callee_0() [ "foo"(metadata !"metadata_string") ] to label %normal unwind label %exception
+; CHECK: invoke void @op_bundle_callee_0() [ "foo"(metadata !"metadata_string") ]
+
+exception:
+  %cleanup = landingpad i8 cleanup
+  br label %normal
+normal:
+  ret void
+}
+
 declare void @vaargs_func(...)
 define void @invoke_with_operand_bundle_vaarg(i32* %ptr) personality i8 3 {
 ; CHECK-LABEL: @invoke_with_operand_bundle_vaarg(
  entry:
   %l = load i32, i32* %ptr
   %x = add i32 42, 1
   invoke void (...) @vaargs_func(i32 10, i32 %x) [ "foo"(i32 42, i64 100, i32 %x), "foo"(i32 42, float  0.000000e+00, i32 %l) ]
         to label %normal unwind label %exception

llvm/test/Bitcode/operand-bundles.ll

  entry:
   %l = load i32, i32* %ptr
   %x = add i32 42, 1
   call void @callee1(i32 10, i32 %x) [ "foo"(i32 42, i64 100, i32 %x), "foo"(i32 42, float  0.000000e+00, i32 %l) ]
 ; CHECK: call void @callee1(i32 10, i32 %x) [ "foo"(i32 42, i64 100, i32 %x), "foo"(i32 42, float  0.000000e+00, i32 %l) ]
   ret void
 }
 
+define void @f5(i32* %ptr) {
+; CHECK-LABEL: @f5(
+ entry:
+  call void @callee0() [ "foo"(metadata !"metadata_string") ]
+; CHECK: call void @callee0() [ "foo"(metadata !"metadata_string") ]
+  ret void
+}
+
 ; Invoke versions of the above tests:
 
 
 define void @g0(i32* %ptr) personality i8 3 {
 ; CHECK-LABEL: @g0(
  entry:
   %l = load i32, i32* %ptr
   %x = add i32 42, 1

 ; CHECK: invoke void @callee1(i32 10, i32 %x) [ "foo"(i32 42, i64 100, i32 %x), "foo"(i32 42, float  0.000000e+00, i32 %l) ]
 
 exception:
   %cleanup = landingpad i8 cleanup
   br label %normal
 normal:
   ret void
 }
+
+define void @g5(i32* %ptr) personality i8 3 {
+; CHECK-LABEL: @g5(
+ entry:
+  invoke void @callee0() [ "foo"(metadata !"metadata_string") ] to label %normal unwind label %exception
+; CHECK: invoke void @callee0() [ "foo"(metadata !"metadata_string") ]
+
+exception:
+  %cleanup = landingpad i8 cleanup
+  br label %normal
+normal:
+  ret void
+}