This is an archive of the discontinued LLVM Phabricator instance.

[Sparc] Make soft-float emit an error.
ClosedPublic

Authored by jyknight on Jun 15 2015, 12:53 PM.

Details

Summary

LLVM does not and has not ever supported a soft-float ABI mode on
Sparc, so don't pretend that it does.

Also switch the default from "soft-float" -- which was actually
hard-float because soft-float is unimplemented -- to hard-float.

Diff Detail

Event Timeline

jyknight updated this revision to Diff 27707.Jun 15 2015, 12:53 PM
jyknight retitled this revision from to [Sparc] Make soft-float emit an error..
jyknight updated this object.
jyknight edited the test plan for this revision. (Show Details)
jyknight added a reviewer: echristo.
jyknight added a subscriber: Unknown Object (MLST).
echristo edited edge metadata.Jun 15 2015, 12:56 PM

I thought I'd removed that.

Some inline comments on the patch. LGTM after fixed.

Thanks!

-eric

lib/Driver/Tools.cpp
1323–1327

Move this comment down to the if(SoftFloatABI) below?

1329–1331

This function appears empty now?

jyknight updated this revision to Diff 27711.Jun 15 2015, 1:31 PM
jyknight edited edge metadata.

Update per comments.

lib/Driver/Tools.cpp
1323–1327

Done.

1329–1331

It is. I assume by that comment you mean that you would prefer it removed.

echristo accepted this revision.Jun 15 2015, 1:32 PM
echristo edited edge metadata.

Yep. Precisely.

Thanks! LGTM.

-eric

This revision is now accepted and ready to land.Jun 15 2015, 1:32 PM
This revision was automatically updated to reflect the committed changes.