This is an archive of the discontinued LLVM Phabricator instance.

[Utils][vim] Add missing highlights for fast-math flags
ClosedPublic

Authored by frasercrmck on Jun 18 2021, 8:40 AM.

Details

Summary

This patch adds the afn, contract, and reassoc fast-math flags.

It also fixes up fneg's order in the alphabetized list.

Diff Detail

Event Timeline

frasercrmck created this revision.Jun 18 2021, 8:40 AM
frasercrmck requested review of this revision.Jun 18 2021, 8:40 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 18 2021, 8:40 AM
craig.topper added inline comments.
llvm/utils/vim/syntax/llvm.vim
27–28

Is this file following 80 columns?

frasercrmck edited the summary of this revision. (Show Details)Jun 21 2021, 1:57 AM
frasercrmck marked an inline comment as done.
  • reflow to 80 cols
frasercrmck added inline comments.Jun 21 2021, 2:00 AM
llvm/utils/vim/syntax/llvm.vim
27–28

Not entirely as there's a particularly long regex later on in the file, but I was perhaps being a bit lazy in order to have a clearer diff. Reformatting to 80 columns seems like the best thing to do.

MaskRay accepted this revision.Jun 21 2021, 12:04 PM

Looks great!

This revision is now accepted and ready to land.Jun 21 2021, 12:04 PM
craig.topper accepted this revision.Jun 21 2021, 12:13 PM

LGTM

llvm/utils/vim/syntax/llvm.vim
27–28

Not at all your fault, but fneg is out of alphabetical order if you want to fix it before you commit.

  • fix alphabetization(?) of fneg
frasercrmck edited the summary of this revision. (Show Details)Jun 22 2021, 1:09 AM
This revision was landed with ongoing or failed builds.Jun 22 2021, 1:47 AM
This revision was automatically updated to reflect the committed changes.