This is an archive of the discontinued LLVM Phabricator instance.

[TestGdbRemoteRegisterState] Do not flip ARM *psr register in the test
ClosedPublic

Authored by sivachandra on Jun 2 2015, 5:00 PM.

Details

Summary

Not all of that register is readable/writable in user mode. This means
that even if the inferior is stopped, parts of the register could be
changing. So, do not flip this register to check if its value can be
restored.

Diff Detail

Event Timeline

sivachandra updated this revision to Diff 27019.Jun 2 2015, 5:00 PM
sivachandra retitled this revision from to [TestGdbRemoteRegisterState] Do not flip ARM *psr register in the test.
sivachandra updated this object.
sivachandra edited the test plan for this revision. (Show Details)
sivachandra added reviewers: chaoren, tberghammer.
sivachandra added a subscriber: Unknown Object (MLST).
tberghammer accepted this revision.Jun 4 2015, 12:32 PM
tberghammer edited edge metadata.

Looks good (why we haven't hit this issue before?)

This revision is now accepted and ready to land.Jun 4 2015, 12:32 PM
chaoren edited edge metadata.Jun 4 2015, 12:51 PM

Only fails on older devices, I think.

Yes, it fails only on older Android API levels (which run older kernels). There also, it is flaky, not really 100% reproducible.

sivachandra closed this revision.Jun 4 2015, 3:08 PM