This is an archive of the discontinued LLVM Phabricator instance.

[ARM] Adjust -march checking
ClosedPublic

Authored by john.brawn on May 29 2015, 4:23 AM.

Details

Summary

getCanonicalArchName can return an empty string for an architecture that is well-formed but meaningless. Use parseArch to determine if it's actually valid or not.

Diff Detail

Event Timeline

john.brawn updated this revision to Diff 26774.May 29 2015, 4:23 AM
john.brawn retitled this revision from to [ARM] Adjust -march checking.
john.brawn updated this object.
john.brawn edited the test plan for this revision. (Show Details)
john.brawn added a reviewer: rengolin.
john.brawn set the repository for this revision to rL LLVM.
john.brawn added a subscriber: Unknown Object (MLST).
john.brawn edited subscribers, added: Unknown Object (MLST); removed: Unknown Object (MLST).May 29 2015, 4:37 AM
rengolin accepted this revision.May 29 2015, 4:49 AM
rengolin edited edge metadata.

Good catch, thanks! LGTM.

This revision is now accepted and ready to land.May 29 2015, 4:49 AM
This revision was automatically updated to reflect the committed changes.