This is an archive of the discontinued LLVM Phabricator instance.

[lld-macho] Have toString() emit full path to archive files
ClosedPublic

Authored by int3 on Apr 12 2021, 6:22 PM.

Details

Reviewers
oontvoo
Group Reviewers
Restricted Project
Commits
rG3142fc3b5bba: [lld-macho] Have toString() emit full path to archive files
Summary

It doesn't make sense to take just the base filename for archives when we emit
the full path for object files. (LLD-ELF emits the full path too.)

This will also make it easier to write a proper test for D100147: [lld-macho] Re-root absolute input file paths if -syslibroot is specified.

Diff Detail

Event Timeline

int3 created this revision.Apr 12 2021, 6:22 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 12 2021, 6:22 PM
int3 requested review of this revision.Apr 12 2021, 6:22 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 12 2021, 6:22 PM
oontvoo accepted this revision.Apr 12 2021, 6:30 PM
oontvoo added a subscriber: oontvoo.
oontvoo added inline comments.
lld/test/MachO/why-load.s
31

perhaps '+'? ( .* could technically be empty)

This revision is now accepted and ready to land.Apr 12 2021, 6:30 PM
int3 marked an inline comment as done.Apr 12 2021, 7:49 PM
This revision was landed with ongoing or failed builds.Apr 13 2021, 7:44 AM
This revision was automatically updated to reflect the committed changes.