Page MenuHomePhabricator

oontvoo (Vy Nguyen)
Animal

Projects

User does not belong to any projects.

User Details

User Since
Apr 11 2019, 1:09 PM (76 w, 14 h)

Recent Activity

Yesterday

oontvoo updated the diff for D85254: [llvm-exegesis] Add option to check the hardware support for a given feature before benchmarking..

Reduce wait time to 5ms. (not really meaningful - we just use this as a way to prevent unrolling)

Thu, Sep 24, 8:21 AM · Restricted Project

Wed, Sep 23

oontvoo updated the diff for D85254: [llvm-exegesis] Add option to check the hardware support for a given feature before benchmarking..

reduce wait time

Wed, Sep 23, 8:46 PM · Restricted Project

Mon, Sep 21

oontvoo updated the diff for D85927: Enable LSAN for Android.

Updated a few tests to work on Android.

Mon, Sep 21, 2:44 PM · Restricted Project

Wed, Sep 16

oontvoo added a comment to D87754: [Lsan] Use fp registers to search for pointers.

Maybe this is a prove that not all registers fetched.
How exactly this fails?

Wed, Sep 16, 10:19 PM · Restricted Project
oontvoo added a comment to D87754: [Lsan] Use fp registers to search for pointers.

FYI @eugenis @oontvoo
Maybe we need this for Android as well

Wed, Sep 16, 7:51 PM · Restricted Project
oontvoo updated the diff for D85254: [llvm-exegesis] Add option to check the hardware support for a given feature before benchmarking..

Updated comment

Wed, Sep 16, 1:27 PM · Restricted Project

Tue, Sep 15

oontvoo updated the diff for D85254: [llvm-exegesis] Add option to check the hardware support for a given feature before benchmarking..

Removed the check-support flag and always performs the check.

Tue, Sep 15, 11:54 AM · Restricted Project

Tue, Sep 1

oontvoo updated the summary of D85927: Enable LSAN for Android.
Tue, Sep 1, 9:07 PM · Restricted Project
oontvoo updated the diff for D85927: Enable LSAN for Android.

updated diff: skipped lsan/asan tests on pre-S images

Tue, Sep 1, 9:04 PM · Restricted Project

Thu, Aug 27

oontvoo updated the diff for D85927: Enable LSAN for Android.

Avoid accessing TLS variables for android when the thread-properties API is not present.

Thu, Aug 27, 6:44 PM · Restricted Project

Wed, Aug 26

oontvoo updated the diff for D85254: [llvm-exegesis] Add option to check the hardware support for a given feature before benchmarking..

Use a more portable way to prevent loop unrolling

Wed, Aug 26, 10:22 AM · Restricted Project

Aug 21 2020

oontvoo updated the diff for D85044: Add __atomic_is_lock_free to compiler-rt.

[WIP] mov stuff to target-specific dirs

Aug 21 2020, 11:00 AM · Restricted Project, Restricted Project

Aug 19 2020

oontvoo added inline comments to D85254: [llvm-exegesis] Add option to check the hardware support for a given feature before benchmarking..
Aug 19 2020, 11:52 AM · Restricted Project
oontvoo updated the diff for D85254: [llvm-exegesis] Add option to check the hardware support for a given feature before benchmarking..

Updated diff

Aug 19 2020, 11:52 AM · Restricted Project

Aug 18 2020

oontvoo updated the diff for D85927: Enable LSAN for Android.

upated diff

Aug 18 2020, 6:09 PM · Restricted Project
oontvoo updated the diff for D85044: Add __atomic_is_lock_free to compiler-rt.

Simple test

Aug 18 2020, 3:06 PM · Restricted Project, Restricted Project

Aug 14 2020

oontvoo added a comment to D85927: Enable LSAN for Android.

This change does not enable standalone LSan. It probably should, as a test vehicle if nothing else. See COMPILER_RT_HAS_LSAN.

Aug 14 2020, 9:07 PM · Restricted Project
oontvoo updated the diff for D85927: Enable LSAN for Android.

updated diff

Aug 14 2020, 9:07 PM · Restricted Project
oontvoo updated the diff for D85927: Enable LSAN for Android.

updated

Aug 14 2020, 9:36 AM · Restricted Project

Aug 13 2020

oontvoo updated the diff for D85927: Enable LSAN for Android.

Dont run leakcheck for android if the thread-properties API is not present

Aug 13 2020, 7:03 PM · Restricted Project
oontvoo updated the diff for D85927: Enable LSAN for Android.

Updated diff

Aug 13 2020, 6:33 PM · Restricted Project
oontvoo added a comment to D85927: Enable LSAN for Android.

FYI https://reviews.llvm.org/D85930 moves standalone LSan on Android/aarch64 to the 64-bit allocator, I don't know if you care about this.
LSan-in-ASan is already there.

Aug 13 2020, 6:32 PM · Restricted Project
oontvoo added a comment to D85044: Add __atomic_is_lock_free to compiler-rt.
In D85044#2216023, @jfb wrote:

Can you please add tests for this?

Aug 13 2020, 3:28 PM · Restricted Project, Restricted Project
oontvoo updated the diff for D85044: Add __atomic_is_lock_free to compiler-rt.

Updated diff

Aug 13 2020, 3:28 PM · Restricted Project, Restricted Project
oontvoo added inline comments to D85927: Enable LSAN for Android.
Aug 13 2020, 2:58 PM · Restricted Project
oontvoo updated the diff for D85927: Enable LSAN for Android.

Updated diff

Aug 13 2020, 2:57 PM · Restricted Project
oontvoo updated subscribers of D85927: Enable LSAN for Android.
Aug 13 2020, 1:17 PM · Restricted Project
oontvoo added a comment to D85843: Add "status" to the list of absl libraries..

(With LGTM from sbenza)

Aug 13 2020, 1:09 PM · Restricted Project
oontvoo committed rG114c9fa0e46f: Add "status" to the list of absl libraries. (authored by oontvoo).
Add "status" to the list of absl libraries.
Aug 13 2020, 1:09 PM
oontvoo closed D85843: Add "status" to the list of absl libraries..
Aug 13 2020, 1:08 PM · Restricted Project
oontvoo requested review of D85927: Enable LSAN for Android.
Aug 13 2020, 12:53 PM · Restricted Project
oontvoo added a comment to D85044: Add __atomic_is_lock_free to compiler-rt.
In D85044#2213896, @jfb wrote:

Does this x86 change actually match what the runtime does in the same file?

Aug 13 2020, 9:05 AM · Restricted Project, Restricted Project

Aug 12 2020

oontvoo updated the diff for D85044: Add __atomic_is_lock_free to compiler-rt.

Updated diff

Aug 12 2020, 6:16 PM · Restricted Project, Restricted Project
oontvoo updated the diff for D85044: Add __atomic_is_lock_free to compiler-rt.
  • Remove the checking of non-power-of-2 sizes from is_lock_free for now (because the atomic_* ops don't handle them yet)
  • Rename function to _c and add pragma redefine
Aug 12 2020, 12:46 PM · Restricted Project, Restricted Project
oontvoo requested review of D85843: Add "status" to the list of absl libraries..
Aug 12 2020, 9:25 AM · Restricted Project

Aug 5 2020

oontvoo updated the diff for D85254: [llvm-exegesis] Add option to check the hardware support for a given feature before benchmarking..

Fixed clangtidy warnings

Aug 5 2020, 10:30 AM · Restricted Project

Aug 4 2020

oontvoo requested review of D85254: [llvm-exegesis] Add option to check the hardware support for a given feature before benchmarking..
Aug 4 2020, 3:36 PM · Restricted Project
oontvoo updated the diff for D85044: Add __atomic_is_lock_free to compiler-rt.

Removed use of GNU case range extension
(Triggered a bunch of clang-tidys)

Aug 4 2020, 11:29 AM · Restricted Project, Restricted Project
oontvoo updated the diff for D85044: Add __atomic_is_lock_free to compiler-rt.

updated

Aug 4 2020, 9:15 AM · Restricted Project, Restricted Project
oontvoo retitled D85044: Add __atomic_is_lock_free to compiler-rt from __atomic_is_lock_free to Add __atomic_is_lock_free to compiler-rt.
Aug 4 2020, 9:13 AM · Restricted Project, Restricted Project

Aug 3 2020

oontvoo published D85044: Add __atomic_is_lock_free to compiler-rt for review.
Aug 3 2020, 7:59 PM · Restricted Project, Restricted Project

Jul 27 2020

oontvoo closed D77422: [llvm-exegesis] Add benchmark mode that uses LBR for more precise measurements..

Relanded.
https://reviews.llvm.org/rGee7caa75939afb75547c00744c5df4d04d45e517

Jul 27 2020, 9:42 AM · Restricted Project
oontvoo committed rGee7caa75939a: Reland [llvm-exegesis] Add benchmark latency option on X86 that uses LBR for… (authored by oontvoo).
Reland [llvm-exegesis] Add benchmark latency option on X86 that uses LBR for…
Jul 27 2020, 9:38 AM
oontvoo committed rG48c948abeb7d: [llvm-exegesis] Check perf_branch_entry for field cycles (authored by oontvoo).
[llvm-exegesis] Check perf_branch_entry for field cycles
Jul 27 2020, 8:32 AM
oontvoo closed D84076: [llvm-exegesis] Unset HAVE_LIBPFM if the kernel is too old..
Jul 27 2020, 8:32 AM · Restricted Project
oontvoo closed D84200: Disable trivial weak_ptr test on ARM because it is not expected to work..
Jul 27 2020, 8:04 AM · Restricted Project

Jul 24 2020

oontvoo added a comment to D84200: Disable trivial weak_ptr test on ARM because it is not expected to work..

Would anyone mind Accepting this so I could clear this revision off my pending queue? Thanks!
(It's already committed so ... )

Jul 24 2020, 8:04 PM · Restricted Project
D84200: Disable trivial weak_ptr test on ARM because it is not expected to work. now requires review to proceed.
Jul 24 2020, 8:03 PM · Restricted Project
D84200: Disable trivial weak_ptr test on ARM because it is not expected to work. now requires review to proceed.

(Closing this ... assuming issue has been resolved)

Jul 24 2020, 8:03 PM · Restricted Project
oontvoo updated the diff for D84076: [llvm-exegesis] Unset HAVE_LIBPFM if the kernel is too old..

'cycle' -> 'cycles'

Jul 24 2020, 9:36 AM · Restricted Project
oontvoo updated the diff for D84076: [llvm-exegesis] Unset HAVE_LIBPFM if the kernel is too old..

Updated diff

Jul 24 2020, 8:58 AM · Restricted Project

Jul 23 2020

oontvoo updated the diff for D84076: [llvm-exegesis] Unset HAVE_LIBPFM if the kernel is too old..

CheckStructHasMember didn't work (because cycles is a bit field) so updated it to just compile a small program that accesses .cycles.

Jul 23 2020, 2:35 PM · Restricted Project
oontvoo added a comment to D84076: [llvm-exegesis] Unset HAVE_LIBPFM if the kernel is too old..

Did you forget to include a patch that uses LIBPFM_HAS_FIELD_CYCLES?

Jul 23 2020, 8:35 AM · Restricted Project

Jul 22 2020

oontvoo updated the diff for D77422: [llvm-exegesis] Add benchmark mode that uses LBR for more precise measurements..

Check for existence of cycles before enabling LBR mode.

Jul 22 2020, 8:47 PM · Restricted Project
oontvoo updated the diff for D84076: [llvm-exegesis] Unset HAVE_LIBPFM if the kernel is too old..

typos

Jul 22 2020, 8:20 PM · Restricted Project
oontvoo added a comment to D84076: [llvm-exegesis] Unset HAVE_LIBPFM if the kernel is too old..

You shouldn't be checking the running kernel but the version of the kernel headers. Think of build hosts building LLVM for an entirely different system altogether.

To add to that, you shouldn't hardcode version, but instead check that the problematic field is present or not.
And, i'm not sure this is a good idea. If the kernel is too old, i'd suggest only disabling the functionality
that wants that new field, not the entire libpfm

Jul 22 2020, 8:19 PM · Restricted Project
oontvoo updated the diff for D84076: [llvm-exegesis] Unset HAVE_LIBPFM if the kernel is too old..

Use Cmake's CheckStructHasMember to check for cycles field.

Jul 22 2020, 8:18 PM · Restricted Project

Jul 21 2020

oontvoo added a comment to D84200: Disable trivial weak_ptr test on ARM because it is not expected to work..

My point is that someone compiling for ARM will define _LIBCPP_ABI_ENABLE_SHARED_PTR_TRIVIAL_ABI thinking they are getting trivial weak_ptr and shared_ptr passed in registers, but they won't (and silently so). That deception is what I think should be flagged explicitly through an error of some sort. Do you agree?

Jul 21 2020, 9:18 AM · Restricted Project
oontvoo accepted D84200: Disable trivial weak_ptr test on ARM because it is not expected to work..

In that case, shouldn't it be an error to try to make weak_ptr trivial on ARM? The current state of things appears to be that one will say "make weak_ptr trivial", and the library will silently fail to honour that request.

Jul 21 2020, 7:27 AM · Restricted Project

Jul 20 2020

oontvoo committed rGf5e49bd9defd: Disable trivial weak_ptr test on ARM because it is not expected to work. (authored by oontvoo).
Disable trivial weak_ptr test on ARM because it is not expected to work.
Jul 20 2020, 9:18 PM
oontvoo closed D84200: Disable trivial weak_ptr test on ARM because it is not expected to work..
Jul 20 2020, 9:18 PM · Restricted Project
oontvoo added a comment to D82490: [libcxx] Put clang::trivial_abi on std::unique_ptr.

PP.S: weak_ptr test failed on ARM32. Fixed in https://reviews.llvm.org/D84200

Jul 20 2020, 9:16 PM · Restricted Project
Herald added a reviewer for D84200: Disable trivial weak_ptr test on ARM because it is not expected to work.: Restricted Project.
Jul 20 2020, 9:16 PM · Restricted Project
oontvoo committed rGbe2267ba34e5: [libcxx] Skip tests on GCC (authored by oontvoo).
[libcxx] Skip tests on GCC
Jul 20 2020, 9:59 AM
oontvoo closed D84183: [libcxx] Skip tests on GCC.
Jul 20 2020, 9:59 AM · Restricted Project
oontvoo added a comment to D82490: [libcxx] Put clang::trivial_abi on std::unique_ptr.

P.S: This broke GCC build bot. Fixed forward in https://reviews.llvm.org/D84183

Jul 20 2020, 9:56 AM · Restricted Project
oontvoo updated the summary of D84183: [libcxx] Skip tests on GCC.
Jul 20 2020, 9:55 AM · Restricted Project
Herald added a reviewer for D84183: [libcxx] Skip tests on GCC: Restricted Project.
Jul 20 2020, 9:53 AM · Restricted Project
oontvoo closed D82490: [libcxx] Put clang::trivial_abi on std::unique_ptr.
Jul 20 2020, 9:01 AM · Restricted Project
oontvoo committed rG76887bc4c102: Reland [libcxx]Put clang::trivial_abi on smart pointers (authored by oontvoo).
Reland [libcxx]Put clang::trivial_abi on smart pointers
Jul 20 2020, 8:56 AM

Jul 17 2020

Herald added a project to D84076: [llvm-exegesis] Unset HAVE_LIBPFM if the kernel is too old.: Restricted Project.
Jul 17 2020, 4:10 PM · Restricted Project
oontvoo reopened D77422: [llvm-exegesis] Add benchmark mode that uses LBR for more precise measurements..
Jul 17 2020, 3:54 PM · Restricted Project

Jul 16 2020

oontvoo added a comment to D82490: [libcxx] Put clang::trivial_abi on std::unique_ptr.

! In D82490#2155964, @ldionne wrote:
-DLIBCXX_ABI_UNSTABLE=ON?

Jul 16 2020, 11:07 AM · Restricted Project
oontvoo closed D77422: [llvm-exegesis] Add benchmark mode that uses LBR for more precise measurements..
Jul 16 2020, 9:19 AM · Restricted Project
oontvoo committed rG1360e140cc7b: [llvm-exegesis] Add benchmark latency option on X86 that uses LBR for more… (authored by oontvoo).
[llvm-exegesis] Add benchmark latency option on X86 that uses LBR for more…
Jul 16 2020, 9:14 AM

Jul 15 2020

oontvoo added a comment to D82490: [libcxx] Put clang::trivial_abi on std::unique_ptr.

Thanks, everyone, for your input (and patience)!
I'm planning on committing this at the beginning of next week. If anyone has some concern or additional testing they'd like to see happen, please let me know.
(Have run the check-cxx with -DLIBCXX_ABI_UNSTABLE=true)

Jul 15 2020, 3:28 PM · Restricted Project

Jul 14 2020

oontvoo updated the diff for D82490: [libcxx] Put clang::trivial_abi on std::unique_ptr.

Added UNSUPPORTED comments on tests.

Jul 14 2020, 8:32 AM · Restricted Project
oontvoo added a comment to D82490: [libcxx] Put clang::trivial_abi on std::unique_ptr.

We'll need to add // UNSUPPORTED: clang-4, clang-5, clang-6, clang-7, clang-8, clang-9, clang-10 on the tests with a short comment explaining there was a segfault.

Jul 14 2020, 8:09 AM · Restricted Project

Jul 10 2020

oontvoo committed rG17ea41e47256: Summary: [clang] Provide a way for WhileStmt to report the location of its… (authored by oontvoo).
Summary: [clang] Provide a way for WhileStmt to report the location of its…
Jul 10 2020, 6:31 PM
oontvoo closed D83529: Summary: [clang] Provide a way for WhileStmt to report the location of its LParen and RParen..
Jul 10 2020, 6:31 PM · Restricted Project
oontvoo updated the diff for D83529: Summary: [clang] Provide a way for WhileStmt to report the location of its LParen and RParen..

rebase

Jul 10 2020, 2:30 PM · Restricted Project
oontvoo added a comment to D83529: Summary: [clang] Provide a way for WhileStmt to report the location of its LParen and RParen..

No objection from me, but I am not a reviewer. I am just accepting this to cancel my comment on the missing serialization.

Jul 10 2020, 1:56 PM · Restricted Project
oontvoo updated the diff for D83529: Summary: [clang] Provide a way for WhileStmt to report the location of its LParen and RParen..

Added unit test and the missing serialisation code

Jul 10 2020, 12:02 PM · Restricted Project

Jul 9 2020

oontvoo added a reviewer for D83529: Summary: [clang] Provide a way for WhileStmt to report the location of its LParen and RParen.: gribozavr2.
Jul 9 2020, 8:23 PM · Restricted Project
Herald added a project to D83529: Summary: [clang] Provide a way for WhileStmt to report the location of its LParen and RParen.: Restricted Project.
Jul 9 2020, 8:21 PM · Restricted Project
oontvoo updated the diff for D77422: [llvm-exegesis] Add benchmark mode that uses LBR for more precise measurements..

Fixed warning [-Wmissing-field-initializers] in code

Jul 9 2020, 2:40 PM · Restricted Project
oontvoo updated the diff for D77422: [llvm-exegesis] Add benchmark mode that uses LBR for more precise measurements..

Removed empty line

Jul 9 2020, 1:46 PM · Restricted Project

Jul 8 2020

oontvoo updated the diff for D77422: [llvm-exegesis] Add benchmark mode that uses LBR for more precise measurements..

Return error for empty function

Jul 8 2020, 9:27 AM · Restricted Project

Jul 7 2020

oontvoo added a comment to D82490: [libcxx] Put clang::trivial_abi on std::unique_ptr.

Sorry for the sloppy testing. I initially ran these tests with google internal checkout+build systems because it was faster and just patched the tests over here once they passed (hence missing the typo in the code here). The fact that we had previously tested this change with a large set of internal code made me incorrectly assume it was safe. I hadn't realised assertion was turnt off.

Anyway, I think the "Fix" here would be in clang. It crashed while trying to determine whether the copy and move ctors were deleted in clang::Sema::checkIllFormedTrivialABIStruct. (Sent D83263 )

I'll let you know once that is resolved

Thanks, I'll be waiting for you to ping this again!

Jul 7 2020, 3:24 PM · Restricted Project
oontvoo closed D83263: Clang crashed while checking for deletion of copy and move ctors.
Jul 7 2020, 12:28 PM · Restricted Project
oontvoo committed rGa707da4728de: Clang crashed while checking for deletion of copy and move ctors (authored by oontvoo).
Clang crashed while checking for deletion of copy and move ctors
Jul 7 2020, 11:41 AM
oontvoo added reviewers for D83263: Clang crashed while checking for deletion of copy and move ctors: jyknight, rsmith.
Jul 7 2020, 10:28 AM · Restricted Project
oontvoo updated the diff for D77422: [llvm-exegesis] Add benchmark mode that uses LBR for more precise measurements..

updated diff

Jul 7 2020, 10:17 AM · Restricted Project
oontvoo updated the diff for D83263: Clang crashed while checking for deletion of copy and move ctors.

one more test

Jul 7 2020, 8:30 AM · Restricted Project
oontvoo updated the diff for D83263: Clang crashed while checking for deletion of copy and move ctors.

lint

Jul 7 2020, 8:20 AM · Restricted Project
oontvoo updated the diff for D83263: Clang crashed while checking for deletion of copy and move ctors.

prevent diagnostics for dependent types

Jul 7 2020, 8:18 AM · Restricted Project

Jul 6 2020

oontvoo updated the diff for D83263: Clang crashed while checking for deletion of copy and move ctors.

updated diff

Jul 6 2020, 8:55 PM · Restricted Project
oontvoo updated the diff for D83263: Clang crashed while checking for deletion of copy and move ctors.

updated diff

Jul 6 2020, 8:48 PM · Restricted Project
oontvoo updated the diff for D83263: Clang crashed while checking for deletion of copy and move ctors.

Add more tests

Jul 6 2020, 8:24 PM · Restricted Project
oontvoo updated the diff for D83263: Clang crashed while checking for deletion of copy and move ctors.

Dont skip checking even for templated type

Jul 6 2020, 7:02 PM · Restricted Project