Page MenuHomePhabricator

int3 (Jez Ng)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 22 2020, 2:12 PM (28 w, 6 d)

Recent Activity

Today

int3 added a comment to D85786: [lld-macho] Emit load command LC_BUILD_VERSION.

Should I expend the effort to generalize via patterns in order to quietly absorb future load-command expansions?

Tue, Aug 11, 2:43 PM · Restricted Project
int3 updated the diff for D85404: [lld-macho] Handle TAPI and regular re-exports uniformly.

update

Tue, Aug 11, 9:48 AM · Restricted Project

Yesterday

int3 updated the diff for D85081: [lld-macho] Support dynamic linking of thread-locals.

rename

Mon, Aug 10, 7:17 PM · Restricted Project
int3 committed rGa379f2c251d0: [lld-macho] Handle command-line option -sectcreate SEG SECT FILE (authored by gkm).
[lld-macho] Handle command-line option -sectcreate SEG SECT FILE
Mon, Aug 10, 6:48 PM
int3 committed rG49fb1c2e9018: [lld-macho] improve handling of -platform_version (authored by gkm).
[lld-macho] improve handling of -platform_version
Mon, Aug 10, 6:48 PM
int3 closed D81413: [lld-macho] improve handling of -platform_version.
Mon, Aug 10, 6:48 PM · Restricted Project, lld
int3 closed D85501: [lld-macho] Handle command-line option -sectcreate SEG SECT FILE.
Mon, Aug 10, 6:47 PM · Restricted Project
int3 requested review of D85701: [lld-macho] Support -rpath.
Mon, Aug 10, 6:43 PM · Restricted Project
int3 added inline comments to D85255: [lld-macho] Generate ObjC symbols from .tbd files.
Mon, Aug 10, 2:34 PM · Restricted Project
int3 added inline comments to D85550: [lld-macho] Implement -force_load.
Mon, Aug 10, 12:25 PM · Restricted Project
int3 updated the diff for D85550: [lld-macho] Implement -force_load.

cascade

Mon, Aug 10, 12:25 PM · Restricted Project
int3 accepted D81413: [lld-macho] improve handling of -platform_version.

lgtm!

Mon, Aug 10, 9:58 AM · Restricted Project, lld

Sun, Aug 9

int3 added inline comments to D81413: [lld-macho] improve handling of -platform_version.
Sun, Aug 9, 8:01 AM · Restricted Project, lld

Fri, Aug 7

int3 requested review of D85550: [lld-macho] Implement -force_load.
Fri, Aug 7, 12:54 PM · Restricted Project
int3 added inline comments to D85501: [lld-macho] Handle command-line option -sectcreate SEG SECT FILE.
Fri, Aug 7, 12:51 PM · Restricted Project
int3 added a reviewer for D85501: [lld-macho] Handle command-line option -sectcreate SEG SECT FILE: Restricted Project.
Fri, Aug 7, 12:18 PM · Restricted Project
int3 added inline comments to D85501: [lld-macho] Handle command-line option -sectcreate SEG SECT FILE.
Fri, Aug 7, 12:16 PM · Restricted Project
int3 accepted D85501: [lld-macho] Handle command-line option -sectcreate SEG SECT FILE.

lgtm modulo those changes

Fri, Aug 7, 12:03 PM · Restricted Project
int3 committed rG25367dfefb7b: [lld-macho] Add .tbd support for frameworks (authored by int3).
[lld-macho] Add .tbd support for frameworks
Fri, Aug 7, 11:05 AM
int3 committed rGca85e3733816: [lld-macho] Support static linking of thread-locals (authored by int3).
[lld-macho] Support static linking of thread-locals
Fri, Aug 7, 11:05 AM
int3 committed rG4e43f1804817: [lld-macho] Ensure .tbss sections are also considered as ZeroFilled (authored by int3).
[lld-macho] Ensure .tbss sections are also considered as ZeroFilled
Fri, Aug 7, 11:05 AM
int3 closed D85153: [lld-macho] Add .tbd support for frameworks.
Fri, Aug 7, 11:05 AM · Restricted Project
int3 closed D85080: [lld-macho] Support static linking of thread-locals.
Fri, Aug 7, 11:05 AM · Restricted Project
int3 closed D85079: [lld-macho] Ensure .tbss sections are also considered as ZeroFilled.
Fri, Aug 7, 11:05 AM · Restricted Project
int3 added a comment to D85467: [lld-macho] Support larger dylib symbol ordinals in bindings.

we could produce 15 dylibs from the same source file and just have the 16th be different (to confirm the binding), right?

Fri, Aug 7, 10:13 AM · Restricted Project
int3 added inline comments to D85081: [lld-macho] Support dynamic linking of thread-locals.
Fri, Aug 7, 10:10 AM · Restricted Project
int3 added inline comments to D85501: [lld-macho] Handle command-line option -sectcreate SEG SECT FILE.
Fri, Aug 7, 9:54 AM · Restricted Project

Thu, Aug 6

int3 added inline comments to D85080: [lld-macho] Support static linking of thread-locals.
Thu, Aug 6, 7:17 PM · Restricted Project
int3 added inline comments to D85081: [lld-macho] Support dynamic linking of thread-locals.
Thu, Aug 6, 1:18 PM · Restricted Project
int3 added inline comments to D85081: [lld-macho] Support dynamic linking of thread-locals.
Thu, Aug 6, 1:16 PM · Restricted Project
int3 requested review of D85467: [lld-macho] Support larger dylib symbol ordinals in bindings.
Thu, Aug 6, 12:33 PM · Restricted Project
int3 added inline comments to D85404: [lld-macho] Handle TAPI and regular re-exports uniformly.
Thu, Aug 6, 10:09 AM · Restricted Project
int3 requested review of D85404: [lld-macho] Handle TAPI and regular re-exports uniformly.
Thu, Aug 6, 12:12 AM · Restricted Project
int3 requested review of D85403: [lld-macho] Add error handling for malformed TBD files.
Thu, Aug 6, 12:12 AM · Restricted Project
int3 requested review of D85402: [lld-macho] Avoid unnecessary shared_ptr in DylibFile ctor.
Thu, Aug 6, 12:12 AM · Restricted Project

Wed, Aug 5

int3 added inline comments to D85153: [lld-macho] Add .tbd support for frameworks.
Wed, Aug 5, 11:15 PM · Restricted Project
int3 added inline comments to D85080: [lld-macho] Support static linking of thread-locals.
Wed, Aug 5, 11:15 PM · Restricted Project
int3 updated the diff for D85153: [lld-macho] Add .tbd support for frameworks.

remove comment

Wed, Aug 5, 11:14 PM · Restricted Project
int3 updated the diff for D85080: [lld-macho] Support static linking of thread-locals.

update

Wed, Aug 5, 10:49 PM · Restricted Project
int3 updated the diff for D85153: [lld-macho] Add .tbd support for frameworks.

rename

Wed, Aug 5, 9:51 AM · Restricted Project
int3 updated subscribers of D85255: [lld-macho] Generate ObjC symbols from .tbd files.
Wed, Aug 5, 9:29 AM · Restricted Project
int3 added inline comments to D85153: [lld-macho] Add .tbd support for frameworks.
Wed, Aug 5, 9:25 AM · Restricted Project

Tue, Aug 4

int3 requested review of D85255: [lld-macho] Generate ObjC symbols from .tbd files.
Tue, Aug 4, 3:54 PM · Restricted Project
int3 accepted D82252: MachO: support `-syslibroot`.

lgtm modulo those two questions. Thanks!

Tue, Aug 4, 10:04 AM · Restricted Project, Restricted Project, lld

Mon, Aug 3

int3 updated the diff for D85080: [lld-macho] Support static linking of thread-locals.

getSymbolVA() -> resolveSymbolVA()

Mon, Aug 3, 2:51 PM · Restricted Project
int3 added a reviewer for D85153: [lld-macho] Add .tbd support for frameworks: Restricted Project.
Mon, Aug 3, 2:04 PM · Restricted Project
int3 updated the diff for D85153: [lld-macho] Add .tbd support for frameworks.

update

Mon, Aug 3, 2:04 PM · Restricted Project
int3 updated the summary of D85153: [lld-macho] Add .tbd support for frameworks.
Mon, Aug 3, 1:24 PM · Restricted Project
int3 updated the summary of D85153: [lld-macho] Add .tbd support for frameworks.
Mon, Aug 3, 1:24 PM · Restricted Project
int3 requested review of D85153: [lld-macho] Add .tbd support for frameworks.
Mon, Aug 3, 1:23 PM · Restricted Project
int3 added a comment to D82252: MachO: support `-syslibroot`.

search-paths.test needs to be updated too

Mon, Aug 3, 11:29 AM · Restricted Project, Restricted Project, lld
int3 added inline comments to D85080: [lld-macho] Support static linking of thread-locals.
Mon, Aug 3, 10:26 AM · Restricted Project
int3 added inline comments to D85079: [lld-macho] Ensure .tbss sections are also considered as ZeroFilled.
Mon, Aug 3, 10:12 AM · Restricted Project
int3 added inline comments to D82252: MachO: support `-syslibroot`.
Mon, Aug 3, 8:57 AM · Restricted Project, Restricted Project, lld

Sat, Aug 1

int3 retitled D85081: [lld-macho] Support dynamic linking of thread-locals from [lld-macho] Support dynamic linking against thread-locals to [lld-macho] Support dynamic linking of thread-locals.
Sat, Aug 1, 6:14 PM · Restricted Project
int3 retitled D85080: [lld-macho] Support static linking of thread-locals from [lld-macho] Support static linking against thread-locals to [lld-macho] Support static linking of thread-locals.
Sat, Aug 1, 6:13 PM · Restricted Project
int3 requested review of D85081: [lld-macho] Support dynamic linking of thread-locals.
Sat, Aug 1, 3:26 PM · Restricted Project
int3 requested review of D85080: [lld-macho] Support static linking of thread-locals.
Sat, Aug 1, 3:26 PM · Restricted Project
int3 requested review of D85079: [lld-macho] Ensure .tbss sections are also considered as ZeroFilled.
Sat, Aug 1, 3:21 PM · Restricted Project
int3 added a comment to D82252: MachO: support `-syslibroot`.

Oh yeah, don't forget to remove the HelpHidden tag from syslibroot's definition in Options.td

Sat, Aug 1, 1:53 PM · Restricted Project, Restricted Project, lld

Thu, Jul 30

int3 added inline comments to D84714: [lld-macho] Implement -headerpad.
Thu, Jul 30, 2:40 PM · Restricted Project
int3 committed rGc89e46e767e2: [lld-macho] Add comment for literal argument (authored by int3).
[lld-macho] Add comment for literal argument
Thu, Jul 30, 2:40 PM
int3 committed rG98210796e108: [lld-macho] Make __LINKEDIT sections contiguous (authored by int3).
[lld-macho] Make __LINKEDIT sections contiguous
Thu, Jul 30, 2:31 PM
int3 committed rG22e6648a1834: [lld-macho] Implement -headerpad (authored by int3).
[lld-macho] Implement -headerpad
Thu, Jul 30, 2:30 PM
int3 committed rG3587de228198: [lld-macho] Support __dso_handle for C++ (authored by int3).
[lld-macho] Support __dso_handle for C++
Thu, Jul 30, 2:30 PM
int3 closed D84718: [lld-macho] Make __LINKEDIT sections contiguous.
Thu, Jul 30, 2:30 PM · Restricted Project
int3 closed D84714: [lld-macho] Implement -headerpad.
Thu, Jul 30, 2:30 PM · Restricted Project
int3 closed D83603: [lld-macho] Support __dso_handle for C++.
Thu, Jul 30, 2:30 PM · Restricted Project
int3 updated the diff for D83603: [lld-macho] Support __dso_handle for C++.

make duplicate definition an error

Thu, Jul 30, 1:57 PM · Restricted Project
int3 added inline comments to D83603: [lld-macho] Support __dso_handle for C++.
Thu, Jul 30, 12:13 PM · Restricted Project
int3 added inline comments to D83603: [lld-macho] Support __dso_handle for C++.
Thu, Jul 30, 10:52 AM · Restricted Project

Tue, Jul 28

int3 added a comment to D84486: [lld-macho] Support -filelist.

Thanks for the heads up. Just pushed a5b89c2853 which should hopefully fix things; will monitor the buildbots.

Tue, Jul 28, 11:06 AM · Restricted Project
int3 committed rGa5b89c285329: [lld-macho] Fix no-filelist test on Windows (authored by int3).
[lld-macho] Fix no-filelist test on Windows
Tue, Jul 28, 11:05 AM
int3 added a comment to D84714: [lld-macho] Implement -headerpad.

Also, would you be fine with the emulation of ld64's alignment behavior being punted to a future diff? I think it's pretty orthogonal in terms of the code changes required.

Tue, Jul 28, 10:13 AM · Restricted Project
int3 committed rGd32e32500f92: [lld-macho] Fix segment filesize calculation (authored by int3).
[lld-macho] Fix segment filesize calculation
Tue, Jul 28, 10:02 AM
int3 committed rG4853a86022fe: [lld-macho] Support -filelist (authored by int3).
[lld-macho] Support -filelist
Tue, Jul 28, 10:02 AM
int3 closed D84574: [lld-macho] Fix segment filesize calculation.
Tue, Jul 28, 10:02 AM · Restricted Project
int3 closed D84486: [lld-macho] Support -filelist.
Tue, Jul 28, 10:02 AM · Restricted Project
int3 added a comment to D84714: [lld-macho] Implement -headerpad.

Happy to emulate that behavior, but I'd like to check my understanding of the performance implications. Is it just a matter of saving one page? I guess it'd be significant if the first or last page in __TEXT was hot code and benefits from being in the L1 TLB, but I'm not sure how often that is the case.

Tue, Jul 28, 9:55 AM · Restricted Project

Mon, Jul 27

int3 updated the summary of D84714: [lld-macho] Implement -headerpad.
Mon, Jul 27, 7:51 PM · Restricted Project
int3 added inline comments to D84574: [lld-macho] Fix segment filesize calculation.
Mon, Jul 27, 6:17 PM · Restricted Project
int3 updated the diff for D84574: [lld-macho] Fix segment filesize calculation.

use assert

Mon, Jul 27, 6:17 PM · Restricted Project
Herald added a project to D84718: [lld-macho] Make __LINKEDIT sections contiguous: Restricted Project.
Mon, Jul 27, 6:11 PM · Restricted Project
Herald added a project to D84714: [lld-macho] Implement -headerpad: Restricted Project.
Mon, Jul 27, 4:44 PM · Restricted Project

Sun, Jul 26

int3 committed rG9282d04e041c: [lld-macho] Support lookup of dylibs in frameworks (authored by int3).
[lld-macho] Support lookup of dylibs in frameworks
Sun, Jul 26, 12:47 PM
int3 closed D83925: [lld-macho] Support lookup of dylibs in frameworks.
Sun, Jul 26, 12:47 PM · Restricted Project
int3 updated the diff for D83925: [lld-macho] Support lookup of dylibs in frameworks.

require shell for test since we use ln

Sun, Jul 26, 9:16 AM · Restricted Project

Fri, Jul 24

int3 updated the summary of D84574: [lld-macho] Fix segment filesize calculation.
Fri, Jul 24, 7:41 PM · Restricted Project
int3 added a comment to D84574: [lld-macho] Fix segment filesize calculation.

Thanks @pcc!

Fri, Jul 24, 7:41 PM · Restricted Project
int3 updated the diff for D84574: [lld-macho] Fix segment filesize calculation.

add test for total file size

Fri, Jul 24, 7:40 PM · Restricted Project
Herald added a project to D84574: [lld-macho] Fix segment filesize calculation: Restricted Project.
Fri, Jul 24, 6:22 PM · Restricted Project
int3 committed rG06a0dd2467d5: [lld-macho] Ignore -dependency_info and its argument (authored by int3).
[lld-macho] Ignore -dependency_info and its argument
Fri, Jul 24, 4:16 PM
int3 committed rG31d58858425f: [lld-macho] Partial support for weak definitions (authored by int3).
[lld-macho] Partial support for weak definitions
Fri, Jul 24, 4:16 PM
int3 closed D84485: [lld-macho] Ignore -dependency_info and its argument.
Fri, Jul 24, 4:16 PM · Restricted Project
int3 closed D83532: [lld-macho] Partial support for weak definitions.
Fri, Jul 24, 4:16 PM · Restricted Project
int3 updated the diff for D83532: [lld-macho] Partial support for weak definitions.

add comment

Fri, Jul 24, 3:11 PM · Restricted Project
int3 added inline comments to D84486: [lld-macho] Support -filelist.
Fri, Jul 24, 12:37 PM · Restricted Project

Thu, Jul 23

int3 added a comment to D83603: [lld-macho] Support __dso_handle for C++.

Bump. Could this get a stamp?

Thu, Jul 23, 10:01 PM · Restricted Project
Herald added a project to D84486: [lld-macho] Support -filelist: Restricted Project.
Thu, Jul 23, 9:21 PM · Restricted Project
Herald added a project to D84485: [lld-macho] Ignore -dependency_info and its argument: Restricted Project.
Thu, Jul 23, 9:18 PM · Restricted Project