- User Since
- Jan 22 2020, 2:12 PM (51 w, 3 d)
Since we're only running the ObjCContractPass via the one pass manager in codegen, there's actually no real need to add the --[no-]lto-legacy-pass-manager flags in this diff. But it probably doesn't hurt to leave it in, along with the test, just to make sure that any future migrations to the non-legacy PM don't break behavior
run pass right before codegen via a config hook
Wed, Jan 13
add passes at the end of the pipeline
Tue, Jan 12
Since we emit diagnostics for undefineds in Writer::scanRelocations()
Sat, Jan 9
Fri, Jan 8
rebase with stacked diff
update bss.s test
Wed, Dec 23
Thanks! Will do that in the future.
Tue, Dec 22
Mon, Dec 21
looks pretty good!
Sun, Dec 20
reorganize order files at bottom of test
Sat, Dec 19
Fri, Dec 18
put back TODO
Dec 17 2020
Should we have a test?
Dec 16 2020
unbreak debug build
Nit: Commit title seems to indicate that we are adding support for paired relocs in this diff, but it seems like this diff is just paving the way for adding that support. Might be worth rephrasing... could also tag with [nfc] to make it explicit.
made quite a few changes, so please have another look :)
use enum for weakref state
make non-weakness take priority
Re bind opcodes: I found http://www.m4b.io/reverse/engineering/mach/binaries/2015/03/29/mach-binaries.html to be a good resource when I was starting out. Particularly the "Mach Import Bind FSA" section.
Dec 15 2020
Simple is good :)
verify that we only re-export top-level frameworks
And yup, the snapshot arguments look similar to our --reproduce
There's a comment in ld64 that says
Dec 14 2020
@thakis I'm unable to properly test PR48511 as the CoreGraphics on my local system seems to have a slightly different set of symbols (despite it being version 10.15.7 too). However, the binary is now trying to import the symbol from CoreGraphics rather than ApplicationServices, so I think this diff is on the right track.