Page MenuHomePhabricator

int3 (Jez Ng)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 22 2020, 2:12 PM (51 w, 3 d)

Recent Activity

Yesterday

int3 added a comment to D94547: [lld-macho] Run ObjCContractPass during LTO.

Since we're only running the ObjCContractPass via the one pass manager in codegen, there's actually no real need to add the --[no-]lto-legacy-pass-manager flags in this diff. But it probably doesn't hurt to leave it in, along with the test, just to make sure that any future migrations to the non-legacy PM don't break behavior

Fri, Jan 15, 10:08 AM · Restricted Project
int3 updated the diff for D94547: [lld-macho] Run ObjCContractPass during LTO.

update

Fri, Jan 15, 10:05 AM · Restricted Project
int3 updated the diff for D94547: [lld-macho] Run ObjCContractPass during LTO.

run pass right before codegen via a config hook

Fri, Jan 15, 10:03 AM · Restricted Project
int3 added inline comments to D94547: [lld-macho] Run ObjCContractPass during LTO.
Fri, Jan 15, 9:11 AM · Restricted Project
int3 added inline comments to D94547: [lld-macho] Run ObjCContractPass during LTO.
Fri, Jan 15, 9:07 AM · Restricted Project

Wed, Jan 13

int3 updated the diff for D94547: [lld-macho] Run ObjCContractPass during LTO.

add passes at the end of the pipeline

Wed, Jan 13, 8:31 AM · Restricted Project

Tue, Jan 12

int3 requested review of D94547: [lld-macho] Run ObjCContractPass during LTO.
Tue, Jan 12, 12:45 PM · Restricted Project
int3 requested review of D94545: [lld-macho][easy] Create group for LLD-specific CLI flags.
Tue, Jan 12, 12:40 PM · Restricted Project
int3 updated the diff for D94316: [lld-macho] Associate each Symbol with an InputFile.

use cast<>

Tue, Jan 12, 11:42 AM · Restricted Project
int3 added a comment to D94371: [lld/mac] Implement -u flag.

Since we emit diagnostics for undefineds in Writer::scanRelocations()

Tue, Jan 12, 11:37 AM

Sat, Jan 9

int3 committed rGe98b441a09fa: [lld-macho] Remove unnecessary llvm:: namespace prefixes (authored by int3).
[lld-macho] Remove unnecessary llvm:: namespace prefixes
Sat, Jan 9, 9:45 AM

Fri, Jan 8

int3 committed rGdaaaed6bb890: [lld-macho] Fix TLV data initialization (authored by int3).
[lld-macho] Fix TLV data initialization
Fri, Jan 8, 3:48 PM
int3 closed D94329: [lld-macho] Fix TLV data initialization.
Fri, Jan 8, 3:48 PM · Restricted Project
int3 updated the diff for D94342: [lld-macho] Basic support for linkage and visibility attributes in LTO.

rebase with stacked diff

Fri, Jan 8, 2:29 PM · Restricted Project
int3 added inline comments to D94329: [lld-macho] Fix TLV data initialization.
Fri, Jan 8, 2:26 PM · Restricted Project
int3 updated the diff for D94329: [lld-macho] Fix TLV data initialization.

rephrase

Fri, Jan 8, 2:26 PM · Restricted Project
int3 requested review of D94342: [lld-macho] Basic support for linkage and visibility attributes in LTO.
Fri, Jan 8, 2:16 PM · Restricted Project
int3 updated the diff for D94329: [lld-macho] Fix TLV data initialization.

update bss.s test

Fri, Jan 8, 12:39 PM · Restricted Project
int3 added inline comments to D94329: [lld-macho] Fix TLV data initialization.
Fri, Jan 8, 12:28 PM · Restricted Project
int3 added inline comments to D94329: [lld-macho] Fix TLV data initialization.
Fri, Jan 8, 12:07 PM · Restricted Project
int3 updated the summary of D94329: [lld-macho] Fix TLV data initialization.
Fri, Jan 8, 12:05 PM · Restricted Project
int3 requested review of D94329: [lld-macho] Fix TLV data initialization.
Fri, Jan 8, 12:04 PM · Restricted Project
int3 updated the diff for D94316: [lld-macho] Associate each Symbol with an InputFile.

minor update

Fri, Jan 8, 10:22 AM · Restricted Project
int3 requested review of D94316: [lld-macho] Associate each Symbol with an InputFile.
Fri, Jan 8, 9:01 AM · Restricted Project

Wed, Dec 23

int3 committed rG9d1140e18e6f: [lld-macho] Simulator & DriverKit executables should always be PIE (authored by int3).
[lld-macho] Simulator & DriverKit executables should always be PIE
Wed, Dec 23, 8:24 AM
int3 closed D93741: [lld-macho] Simulator & DriverKit executables should always be PIE.
Wed, Dec 23, 8:24 AM · Restricted Project
int3 added a comment to D93741: [lld-macho] Simulator & DriverKit executables should always be PIE.

Thanks! Will do that in the future.

Wed, Dec 23, 8:24 AM · Restricted Project

Tue, Dec 22

int3 updated the diff for D93741: [lld-macho] Simulator & DriverKit executables should always be PIE.

fix test

Tue, Dec 22, 9:38 PM · Restricted Project
int3 updated the diff for D93741: [lld-macho] Simulator & DriverKit executables should always be PIE.

update

Tue, Dec 22, 8:56 PM · Restricted Project
int3 requested review of D93741: [lld-macho] Simulator & DriverKit executables should always be PIE.
Tue, Dec 22, 8:02 PM · Restricted Project
int3 accepted D93491: [lld/mac] Add --version flag.
Tue, Dec 22, 6:37 PM · Restricted Project

Mon, Dec 21

int3 accepted D93609: [lld/mac] Implement support for private extern symbols.

nice work!

Mon, Dec 21, 4:50 PM · Restricted Project
int3 committed rG0f8224c2104b: [lld-macho][nfc] Remove %T from headerpad.s (authored by int3).
[lld-macho][nfc] Remove %T from headerpad.s
Mon, Dec 21, 11:44 AM
int3 committed rGa817594de926: [lld-macho][nfc] Clean up tests (authored by int3).
[lld-macho][nfc] Clean up tests
Mon, Dec 21, 11:44 AM
int3 closed D93605: [lld-macho][nfc] Remove %T from headerpad.s.
Mon, Dec 21, 11:44 AM · Restricted Project
int3 closed D93604: [lld-macho][nfc] Clean up tests.
Mon, Dec 21, 11:44 AM · Restricted Project
int3 added a comment to D93609: [lld/mac] Implement support for private extern symbols.

looks pretty good!

Mon, Dec 21, 11:13 AM · Restricted Project

Sun, Dec 20

int3 updated the summary of D93604: [lld-macho][nfc] Clean up tests.
Sun, Dec 20, 3:31 PM · Restricted Project
int3 added a reviewer for D93605: [lld-macho][nfc] Remove %T from headerpad.s: gkm.
Sun, Dec 20, 3:30 PM · Restricted Project
int3 requested review of D93605: [lld-macho][nfc] Remove %T from headerpad.s.
Sun, Dec 20, 3:29 PM · Restricted Project
int3 requested review of D93604: [lld-macho][nfc] Clean up tests.
Sun, Dec 20, 3:29 PM · Restricted Project
int3 committed rG64e475720020: [lld-macho] Have order files support filtering by archive member paths (authored by int3).
[lld-macho] Have order files support filtering by archive member paths
Sun, Dec 20, 10:50 AM
int3 committed rGe2863357de77: [lld-macho][nfc] Use split-file in order file test (authored by int3).
[lld-macho][nfc] Use split-file in order file test
Sun, Dec 20, 10:50 AM
int3 committed rG5f9896d3b23c: [lld-macho] Support Obj-C symbols in order files (authored by int3).
[lld-macho] Support Obj-C symbols in order files
Sun, Dec 20, 10:50 AM
int3 closed D93569: [lld-macho] Have order files support filtering by archive member paths.
Sun, Dec 20, 10:50 AM · Restricted Project
int3 closed D93567: [lld-macho] Support Obj-C symbols in order files.
Sun, Dec 20, 10:49 AM · Restricted Project
int3 closed D93566: [lld-macho][nfc] Use split-file in order file test.
Sun, Dec 20, 10:49 AM · Restricted Project
int3 updated the diff for D93569: [lld-macho] Have order files support filtering by archive member paths.

rebase

Sun, Dec 20, 10:47 AM · Restricted Project
int3 updated the diff for D93567: [lld-macho] Support Obj-C symbols in order files.

rebase

Sun, Dec 20, 10:47 AM · Restricted Project
int3 updated the diff for D93566: [lld-macho][nfc] Use split-file in order file test.

reorganize order files at bottom of test

Sun, Dec 20, 10:47 AM · Restricted Project

Sat, Dec 19

int3 accepted D93267: [lld-macho] Handle overflow beyond the 127 common encodings limit.

lgtm

Sat, Dec 19, 12:14 PM · Restricted Project

Fri, Dec 18

int3 added inline comments to D93569: [lld-macho] Have order files support filtering by archive member paths.
Fri, Dec 18, 4:03 PM · Restricted Project
int3 added inline comments to D93567: [lld-macho] Support Obj-C symbols in order files.
Fri, Dec 18, 4:01 PM · Restricted Project
int3 updated the diff for D93567: [lld-macho] Support Obj-C symbols in order files.

line wrapping

Fri, Dec 18, 3:54 PM · Restricted Project
int3 updated the diff for D93569: [lld-macho] Have order files support filtering by archive member paths.

put back TODO

Fri, Dec 18, 3:50 PM · Restricted Project
int3 requested review of D93569: [lld-macho] Have order files support filtering by archive member paths.
Fri, Dec 18, 3:48 PM · Restricted Project
int3 requested review of D93567: [lld-macho] Support Obj-C symbols in order files.
Fri, Dec 18, 3:45 PM · Restricted Project
int3 requested review of D93566: [lld-macho][nfc] Use split-file in order file test.
Fri, Dec 18, 3:43 PM · Restricted Project
int3 added inline comments to D93267: [lld-macho] Handle overflow beyond the 127 common encodings limit.
Fri, Dec 18, 6:29 AM · Restricted Project

Dec 17 2020

int3 added a comment to D93265: [llvm-objdump-macho] print per-second-level-page encodings for option --unwind-info.

Should we have a test?

Dec 17 2020, 2:20 PM · Restricted Project
int3 added inline comments to D93491: [lld/mac] Add --version flag.
Dec 17 2020, 2:00 PM · Restricted Project
int3 added inline comments to D93263: [lld-macho] Implement option: -undefined TREATMENT.
Dec 17 2020, 11:58 AM · Restricted Project
int3 committed rG4c8276cdc120: [lld-macho] Use LC_LOAD_WEAK_DYLIB for dylibs with only weakrefs (authored by int3).
[lld-macho] Use LC_LOAD_WEAK_DYLIB for dylibs with only weakrefs
Dec 17 2020, 5:50 AM
int3 closed D93435: [lld-macho] Use LC_LOAD_WEAK_DYLIB for dylibs with only weakrefs.
Dec 17 2020, 5:49 AM · Restricted Project
int3 committed rG811444d7a173: [lld-macho] Add support for weak references (authored by int3).
[lld-macho] Add support for weak references
Dec 17 2020, 5:49 AM
int3 closed D93369: [lld-macho] Add support for weak references.
Dec 17 2020, 5:49 AM · Restricted Project

Dec 16 2020

int3 added inline comments to D93267: [lld-macho] Handle overflow beyond the 127 common encodings limit.
Dec 16 2020, 7:19 PM · Restricted Project
int3 added inline comments to D90614: [lld-macho][nfc] Refactor to accommodate paired relocs.
Dec 16 2020, 6:46 PM · Restricted Project
int3 updated the diff for D93369: [lld-macho] Add support for weak references.

unbreak debug build

Dec 16 2020, 6:29 PM · Restricted Project
int3 accepted D90614: [lld-macho][nfc] Refactor to accommodate paired relocs.

Nit: Commit title seems to indicate that we are adding support for paired relocs in this diff, but it seems like this diff is just paving the way for adding that support. Might be worth rephrasing... could also tag with [nfc] to make it explicit.

Dec 16 2020, 6:07 PM · Restricted Project
int3 requested review of D93369: [lld-macho] Add support for weak references.

made quite a few changes, so please have another look :)

Dec 16 2020, 5:22 PM · Restricted Project
int3 added inline comments to D93369: [lld-macho] Add support for weak references.
Dec 16 2020, 5:21 PM · Restricted Project
int3 requested review of D93435: [lld-macho] Use LC_LOAD_WEAK_DYLIB for dylibs with only weakrefs.
Dec 16 2020, 5:20 PM · Restricted Project
int3 updated the diff for D93369: [lld-macho] Add support for weak references.

use enum for weakref state

Dec 16 2020, 5:19 PM · Restricted Project
int3 added inline comments to D93263: [lld-macho] Implement option: -undefined TREATMENT.
Dec 16 2020, 10:25 AM · Restricted Project
int3 planned changes to D93369: [lld-macho] Add support for weak references.
Dec 16 2020, 10:16 AM · Restricted Project
int3 updated the diff for D93369: [lld-macho] Add support for weak references.

make non-weakness take priority

Dec 16 2020, 8:19 AM · Restricted Project
int3 added a comment to D93369: [lld-macho] Add support for weak references.

Re bind opcodes: I found http://www.m4b.io/reverse/engineering/mach/binaries/2015/03/29/mach-binaries.html to be a good resource when I was starting out. Particularly the "Mach Import Bind FSA" section.

Dec 16 2020, 7:55 AM · Restricted Project
int3 added inline comments to D93369: [lld-macho] Add support for weak references.
Dec 16 2020, 7:36 AM · Restricted Project
int3 accepted D93263: [lld-macho] Implement option: -undefined TREATMENT.

lgtm

Dec 16 2020, 7:16 AM · Restricted Project

Dec 15 2020

int3 requested review of D93369: [lld-macho] Add support for weak references.
Dec 15 2020, 9:36 PM · Restricted Project
int3 accepted D93338: [mac/lld] simplify code using PackedVersion instead of VersionTuple.

Simple is good :)

Dec 15 2020, 1:39 PM · Restricted Project
int3 accepted D93332: [mac/lld] fill in current and compatibility version for LC_LOAD_(WEAK_)DYLIB.

lgtm

Dec 15 2020, 1:38 PM · Restricted Project
int3 committed rG3aa8e071dd1a: [lld-macho] Add implicit dylib support for frameworks (authored by int3).
[lld-macho] Add implicit dylib support for frameworks
Dec 15 2020, 1:00 PM
int3 committed rG8a5e06882336: [lld-macho] Support -sub_umbrella (authored by int3).
[lld-macho] Support -sub_umbrella
Dec 15 2020, 1:00 PM
int3 committed rG318451990944: [lld-macho] Don't emit rebase opcodes for relocs in TLV sections (authored by int3).
[lld-macho] Don't emit rebase opcodes for relocs in TLV sections
Dec 15 2020, 1:00 PM
int3 committed rG544148ae702a: [lld-macho] -weak_{library,framework} should always take priority (authored by int3).
[lld-macho] -weak_{library,framework} should always take priority
Dec 15 2020, 1:00 PM
int3 closed D93277: [lld-macho] Add implicit dylib support for frameworks.
Dec 15 2020, 1:00 PM · Restricted Project
int3 closed D93276: [lld-macho] Support -sub_umbrella.
Dec 15 2020, 1:00 PM · Restricted Project
int3 closed D93257: [lld-macho] Don't emit rebase opcodes for relocs in TLV sections.
Dec 15 2020, 1:00 PM · Restricted Project
int3 closed D93255: [lld-macho] -weak_{library,framework} should always take priority.
Dec 15 2020, 1:00 PM · Restricted Project
int3 updated the summary of D93277: [lld-macho] Add implicit dylib support for frameworks.
Dec 15 2020, 12:38 PM · Restricted Project
int3 accepted D93318: [lld/mac] Set ordinal on dynamic undefined symbols in symbol table.

lgtm

Dec 15 2020, 11:10 AM · Restricted Project
int3 updated the diff for D93277: [lld-macho] Add implicit dylib support for frameworks.

verify that we only re-export top-level frameworks

Dec 15 2020, 10:06 AM · Restricted Project
int3 added inline comments to D93277: [lld-macho] Add implicit dylib support for frameworks.
Dec 15 2020, 9:26 AM · Restricted Project
int3 added a comment to D93276: [lld-macho] Support -sub_umbrella.

And yup, the snapshot arguments look similar to our --reproduce

Dec 15 2020, 9:26 AM · Restricted Project
int3 added a comment to D93276: [lld-macho] Support -sub_umbrella.

There's a comment in ld64 that says

Dec 15 2020, 9:25 AM · Restricted Project

Dec 14 2020

int3 added inline comments to D93263: [lld-macho] Implement option: -undefined TREATMENT.
Dec 14 2020, 10:17 PM · Restricted Project
int3 updated subscribers of D93277: [lld-macho] Add implicit dylib support for frameworks.

@thakis I'm unable to properly test PR48511 as the CoreGraphics on my local system seems to have a slightly different set of symbols (despite it being version 10.15.7 too). However, the binary is now trying to import the symbol from CoreGraphics rather than ApplicationServices, so I think this diff is on the right track.

Dec 14 2020, 10:02 PM · Restricted Project
int3 requested review of D93277: [lld-macho] Add implicit dylib support for frameworks.
Dec 14 2020, 10:00 PM · Restricted Project