Page MenuHomePhabricator

[AMDGPU] IsFlatScratch/Global -> FlatScratch/Global
ClosedPublic

Authored by sebastian-ne on Thu, Apr 8, 7:16 AM.

Details

Summary

Remove 'Is' from IsFlatScratch/Global. NFC

Should I do the same for is_flat_scratch/global?

Diff Detail

Event Timeline

sebastian-ne created this revision.Thu, Apr 8, 7:16 AM
sebastian-ne requested review of this revision.Thu, Apr 8, 7:16 AM
Herald added a project: Restricted Project. · View Herald TranscriptThu, Apr 8, 7:16 AM
foad added a comment.Thu, Apr 8, 7:47 AM

Should I do the same for is_flat_scratch/global?

I don't think it matters, since it is only used in FLATInstructions.td.

foad accepted this revision.Thu, Apr 8, 7:49 AM

Seems fine to me. There is not much consistency in the naming of the SIInstrFlags flags.

This revision is now accepted and ready to land.Thu, Apr 8, 7:49 AM
foad added a subscriber: rampitec.

... but adding @rampitec for awareness.

This revision was automatically updated to reflect the committed changes.