This is an archive of the discontinued LLVM Phabricator instance.

[Support/ELF] Add missing DF_1_XXX bits
ClosedPublic

Authored by davide on May 23 2015, 3:22 PM.

Details

Summary

ELFDumper can't correctly decode DF_FLAGS_1.

e.g.

llvm-readobj -dynamic-table:
0x000000006FFFFFFB unknown

GNU readelf --dynamic:
0x000000006ffffffb (FLAGS_1) Flags: NODUMP

This is the first of two patches to add support for decoding (which is needed by lld tests for "-z" option).
It adds the missing DF_1_XXX bits to Support/Elf. The next patch (which builds on top of this one) will take care of the llvm-readobj missing bits.

Diff Detail

Repository
rL LLVM

Event Timeline

davide updated this revision to Diff 26371.May 23 2015, 3:22 PM
davide retitled this revision from to [Support/ELF] Add missing DF_1_XXX bits.
davide updated this object.
davide edited the test plan for this revision. (Show Details)
davide added a reviewer: echristo.
davide set the repository for this revision to rL LLVM.
davide added a subscriber: Unknown Object (MLST).
echristo accepted this revision.May 23 2015, 3:56 PM
echristo edited edge metadata.

LGTM thanks!

-eric

This revision is now accepted and ready to land.May 23 2015, 3:56 PM
This revision was automatically updated to reflect the committed changes.