This is an archive of the discontinued LLVM Phabricator instance.

Differential D9939

Change final case of Driver::getToolChain to if/else/else/... NFC
ClosedPublic

Authored by dougk on May 22 2015, 8:22 AM.

Details

Reviewers
echristo
Commits
rG9f5e70e3b7a9: Change final case of Driver::getToolChain to "if/else/else/else..."
rC238225: Change final case of Driver::getToolChain to "if/else/else/else..."
rL238225: Change final case of Driver::getToolChain to "if/else/else/else..."

Diff Detail

Event Timeline

dougk updated this revision to Diff 26326.May 22 2015, 8:22 AM
dougk retitled this revision from to Change final case of Driver::getToolChain to if/else/else/... NFC.
dougk updated this object.
dougk edited the test plan for this revision. (Show Details)
dougk added a reviewer: echristo.
dougk added a subscriber: Unknown Object (MLST).
Herald added a subscriber: ted. · View Herald TranscriptMay 22 2015, 8:22 AM
dougk added a subscriber: Unknown Object (MLST).May 22 2015, 8:23 AM
Closed by commit rL238225: Change final case of Driver::getToolChain to "if/else/else/else..." (authored by dougk). · Explain WhyMay 26 2015, 11:05 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lib/
Driver/
28 lines

Diff 26326

lib/Driver/Driver.cpp

Show First 20 Lines • Show All 2,019 Lines • ▼ Show 20 Lines if (AT != llvm::Triple::UnknownArch && AT != Target.getArch())
Target.setArch(AT); Target.setArch(AT);
} }
return Target; return Target;
} }
const ToolChain &Driver::getToolChain(const ArgList &Args, const ToolChain &Driver::getToolChain(const ArgList &Args,
StringRef DarwinArchName) const { StringRef DarwinArchName) const {
llvm::Triple Target = computeTargetTriple(DefaultTargetTriple, Args, llvm::Triple Target =
DarwinArchName); computeTargetTriple(DefaultTargetTriple, Args, DarwinArchName);
ToolChain *&TC = ToolChains[Target.str()]; ToolChain *&TC = ToolChains[Target.str()];
if (!TC) { if (!TC) {
switch (Target.getOS()) { switch (Target.getOS()) {
case llvm::Triple::CloudABI: case llvm::Triple::CloudABI:
TC = new toolchains::CloudABI(*this, Target, Args); TC = new toolchains::CloudABI(*this, Target, Args);
break; break;
case llvm::Triple::Darwin: case llvm::Triple::Darwin:
▲ Show 20 Lines • Show All 54 Lines • ▼ Show 20 Lines case llvm::Triple::Win32:
break; break;
case llvm::Triple::MSVC: case llvm::Triple::MSVC:
case llvm::Triple::UnknownEnvironment: case llvm::Triple::UnknownEnvironment:
TC = new toolchains::MSVCToolChain(*this, Target, Args); TC = new toolchains::MSVCToolChain(*this, Target, Args);
break; break;
} }
break; break;
default: default:
// TCE is an OSless target
if (Target.getArchName() == "tce") { if (Target.getArchName() == "tce") {
// TCE is an OSless target
TC = new toolchains::TCEToolChain(*this, Target, Args); TC = new toolchains::TCEToolChain(*this, Target, Args);
break; } else if (Target.getArch() == llvm::Triple::hexagon) {
}
// If Hexagon is configured as an OSless target // If Hexagon is configured as an OSless target
if (Target.getArch() == llvm::Triple::hexagon) {
TC = new toolchains::Hexagon_TC(*this, Target, Args); TC = new toolchains::Hexagon_TC(*this, Target, Args);
break; } else if (Target.getArch() == llvm::Triple::xcore) {
}
if (Target.getArch() == llvm::Triple::xcore) {
TC = new toolchains::XCore(*this, Target, Args); TC = new toolchains::XCore(*this, Target, Args);
break; } else if (Target.isOSBinFormatELF()) {
}
if (Target.isOSBinFormatELF()) {
TC = new toolchains::Generic_ELF(*this, Target, Args); TC = new toolchains::Generic_ELF(*this, Target, Args);
break; } else if (Target.isOSBinFormatMachO()) {
}
if (Target.isOSBinFormatMachO()) {
TC = new toolchains::MachO(*this, Target, Args); TC = new toolchains::MachO(*this, Target, Args);
break; } else {
}
TC = new toolchains::Generic_GCC(*this, Target, Args); TC = new toolchains::Generic_GCC(*this, Target, Args);
}
break; break;
} }
} }
return *TC; return *TC;
} }
bool Driver::ShouldUseClangCompiler(const JobAction &JA) const { bool Driver::ShouldUseClangCompiler(const JobAction &JA) const {
// Check if user requested no clang, or clang doesn't understand this type (we // Check if user requested no clang, or clang doesn't understand this type (we
▲ Show 20 Lines • Show All 69 Lines • Show Last 20 Lines