Fix BreakpointLocationCollection::ShouldStop to handle breakpoint removal

[tberghammer]

Summary

Fix BreakpointLocationCollection::ShouldStop to handle breakpoint removal

ShouldStop will call the callback of the breakpoint what removes the breakpoint in some case (e.g.: dynamic loader entry breakpoint). This behaviour caused segfault or missing of stop in some case with the previous implementation.

[clayborg]

Looks good.

source/Breakpoint/BreakpointLocationCollection.cpp

BreakpointLocationCollection::GetByIndex (size_t i) const
 
     return stop_sp;
 }
 
 bool
 BreakpointLocationCollection::ShouldStop (StoppointCallbackContext *context)
 {
     bool shouldStop = false;
-    const size_t count = GetSize();
-    for (size_t i = 0; i < count; i++) 
+    size_t i = 0;
+    size_t prev_size = GetSize();
+    while (i < prev_size)
     {
+        // ShouldStop can remove the breakpoint from the list
         if (GetByIndex(i)->ShouldStop(context))
             shouldStop = true;
+
+        if (prev_size == GetSize())
+            i++;
+        prev_size = GetSize();
     }
     return shouldStop;
 }
 
 bool 
 BreakpointLocationCollection::ValidForThisThread (Thread *thread)
 {
     collection::iterator pos,