Page MenuHomePhabricator

[libcxx] [test] Fix the last_write_time test to work on windows
AbandonedPublic

Authored by mstorsjo on Mar 15 2021, 10:49 AM.

Details

Reviewers
None
Group Reviewers
Restricted Project

Diff Detail

Event Timeline

mstorsjo requested review of this revision.Mar 15 2021, 10:49 AM
mstorsjo created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptMar 15 2021, 10:49 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript

In this one, a lot of the issues revolve around the test itself using the ´stat()` function (which exists but is crippled and doesn't do the right thing regarding symlinks) - would it be better to simply reimplement a "proper" checker of last write time here, i.e. include a stripped down version of the stat/last_write_time from the libc++ implementation itself?

mstorsjo abandoned this revision.May 12 2021, 12:35 PM

Superseded by D101731.