Page MenuHomePhabricator

XFAIL'd some flakey tests on Darwin
Needs RevisionPublic

Authored by vharron on May 17 2015, 8:19 AM.

Details

Reviewers
clayborg

Diff Detail

Event Timeline

vharron updated this revision to Diff 25927.May 17 2015, 8:19 AM
vharron retitled this revision from to XFAIL'd some flakey tests on Darwin.
vharron updated this object.
vharron edited the test plan for this revision. (Show Details)
vharron added a reviewer: clayborg.
vharron added a subscriber: Unknown Object (MLST).
clayborg requested changes to this revision.May 18 2015, 9:51 AM
clayborg edited edge metadata.

All of these are actually serious and we need to find a way to fix them. It seems bad to just say "they fail sometimes so lets expected fail them".

This revision now requires changes to proceed.May 18 2015, 9:51 AM

All of these are actually serious and we need to find a way to fix them. It seems bad to just say "they fail sometimes so lets expected fail them".

I agree. The intention is not to ignore them but to get the build server green so we can see if any new issues pop up. If we submit this patch, I recommend you open a ticket or find some way of tracking these urgent issues on your side.

The lldb build servers were recently demoted to "experimental" so llvm developers don't even get emails when they go red. I'm trying to get them stable so we can get out of experimental and they get notified when they break the build.

What do you think?