This is an archive of the discontinued LLVM Phabricator instance.

Differential D9752

Reflow long lines of LLVMBuild.txt files
ClosedPublic

Authored by dougk on May 13 2015, 9:18 AM.

Details

Reviewers
jroelofs
Commits
rG9d08232e28f6: Reflow long lines of some LLVMBuild files
rL237367: Reflow long lines of some LLVMBuild files
Summary

The standard Python configparser library supports this, per the documentation:
"In config parsers, values can span multiple lines as long as they are indented more than the key that holds them."
ref. https://docs.python.org/3/library/configparser.html

Diff Detail

Event Timeline

dougk updated this revision to Diff 25698.May 13 2015, 9:18 AM
dougk retitled this revision from to Reflow long lines of LLVMBuild.txt files.
dougk updated this object.
dougk edited the test plan for this revision. (Show Details)
dougk added a subscriber: Unknown Object (MLST).
jroelofs added a subscriber: jroelofs.May 13 2015, 9:44 AM
jroelofs added inline comments.
lib/Target/LLVMBuild.txt
19

Can this particular one be done as one backend per line? That would help OOT backends with merge conflicts going forward.

dougk updated this revision to Diff 25703.May 13 2015, 10:01 AM
dougk edited the test plan for this revision. (Show Details)

Each subdir of Target one a line by itself.

dougk added a comment.May 14 2015, 7:27 AM

Old Python libraries (going back to 2.4.4, possibly older) can parse this line-breaks correctly.

lib/Target/LLVMBuild.txt
19

good idea!

jroelofs accepted this revision.May 14 2015, 8:30 AM
jroelofs added a reviewer: jroelofs.

I just noticed they're all alphabetized... maybe it makes sense to do all three in the one-per-line style? We're not hurting for line-count in these files.

Either way, LGTM.

This revision is now accepted and ready to land.May 14 2015, 8:30 AM
dougk added a comment.May 14 2015, 8:41 AM

tools/LLVMBuild was not quite alphabetized. I'll check this in as-is, and if the builders are happy, go and re-touch all the things.

Closed by commit rL237367: Reflow long lines of some LLVMBuild files (authored by dougk). · Explain WhyMay 14 2015, 8:42 AM
This revision was automatically updated to reflect the committed changes.
dougk mentioned this in rL239632: Wrap some long lines in LLVMBuild files. NFC.Jun 12 2015, 11:49 AM

Revision Contents

PathSize
lib/
4 lines
Target/
3 lines
tools/
5 lines

Diff 25698

lib/LLVMBuild.txt

Show All 10 Lines
; ;
; For more information on the LLVMBuild system, please see: ; For more information on the LLVMBuild system, please see:
; ;
; http://llvm.org/docs/LLVMBuild.html ; http://llvm.org/docs/LLVMBuild.html
; ;
;===------------------------------------------------------------------------===; ;===------------------------------------------------------------------------===;
[common] [common]
subdirectories = Analysis AsmParser Bitcode CodeGen DebugInfo ExecutionEngine LineEditor Linker IR IRReader LTO MC Object Option Passes ProfileData Support TableGen Target Transforms subdirectories = Analysis AsmParser Bitcode CodeGen DebugInfo ExecutionEngine
LineEditor Linker IR IRReader LTO MC Object Option Passes ProfileData Support
TableGen Target Transforms
[component_0] [component_0]
type = Group type = Group
name = Libraries name = Libraries
parent = $ROOT parent = $ROOT

lib/Target/LLVMBuild.txt

Show All 10 Lines
; ;
; For more information on the LLVMBuild system, please see: ; For more information on the LLVMBuild system, please see:
; ;
; http://llvm.org/docs/LLVMBuild.html ; http://llvm.org/docs/LLVMBuild.html
; ;
;===------------------------------------------------------------------------===; ;===------------------------------------------------------------------------===;
[common] [common]
subdirectories = ARM AArch64 BPF CppBackend Hexagon MSP430 NVPTX Mips PowerPC R600 Sparc SystemZ X86 XCore subdirectories = ARM AArch64 BPF CppBackend Hexagon MSP430 NVPTX Mips PowerPC
jroelofsUnsubmitted
Not Done
ReplyInline Actions

Can this particular one be done as one backend per line? That would help OOT backends with merge conflicts going forward.

jroelofs: Can this particular one be done as one backend per line? That would help OOT backends with…
dougkAuthorUnsubmitted
Not Done
ReplyInline Actions

good idea!

dougk: good idea!
R600 Sparc SystemZ X86 XCore
; This is a special group whose required libraries are extended (by llvm-build) ; This is a special group whose required libraries are extended (by llvm-build)
; with the best execution engine (the native JIT, if available, or the ; with the best execution engine (the native JIT, if available, or the
; interpreter). ; interpreter).
[component_0] [component_0]
type = LibraryGroup type = LibraryGroup
name = Engine name = Engine
parent = Libraries parent = Libraries
Show All 29 Lines

tools/LLVMBuild.txt

Show All 10 Lines
; ;
; For more information on the LLVMBuild system, please see: ; For more information on the LLVMBuild system, please see:
; ;
; http://llvm.org/docs/LLVMBuild.html ; http://llvm.org/docs/LLVMBuild.html
; ;
;===------------------------------------------------------------------------===; ;===------------------------------------------------------------------------===;
[common] [common]
subdirectories = bugpoint llc lli llvm-ar llvm-as llvm-bcanalyzer llvm-cov llvm-diff llvm-dis llvm-dwarfdump llvm-extract llvm-jitlistener llvm-link llvm-lto llvm-mc llvm-nm llvm-objdump llvm-pdbdump llvm-profdata llvm-rtdyld llvm-size macho-dump opt llvm-mcmarkup verify-uselistorder dsymutil subdirectories = bugpoint llc lli llvm-ar llvm-as llvm-bcanalyzer llvm-cov
llvm-diff llvm-dis llvm-dwarfdump llvm-extract llvm-jitlistener llvm-link
llvm-lto llvm-mc llvm-nm llvm-objdump llvm-pdbdump llvm-profdata llvm-rtdyld
llvm-size macho-dump opt llvm-mcmarkup verify-uselistorder dsymutil
[component_0] [component_0]
type = Group type = Group
name = Tools name = Tools
parent = $ROOT parent = $ROOT