This is an archive of the discontinued LLVM Phabricator instance.

Reflow long lines of LLVMBuild.txt files
ClosedPublic

Authored by dougk on May 13 2015, 9:18 AM.

Details

Summary

The standard Python configparser library supports this, per the documentation:
"In config parsers, values can span multiple lines as long as they are indented more than the key that holds them."
ref. https://docs.python.org/3/library/configparser.html

Diff Detail

Event Timeline

dougk updated this revision to Diff 25698.May 13 2015, 9:18 AM
dougk retitled this revision from to Reflow long lines of LLVMBuild.txt files.
dougk updated this object.
dougk edited the test plan for this revision. (Show Details)
dougk added a subscriber: Unknown Object (MLST).
jroelofs added inline comments.
lib/Target/LLVMBuild.txt
19

Can this particular one be done as one backend per line? That would help OOT backends with merge conflicts going forward.

dougk updated this revision to Diff 25703.May 13 2015, 10:01 AM
dougk edited the test plan for this revision. (Show Details)

Each subdir of Target one a line by itself.

dougk added a comment.May 14 2015, 7:27 AM

Old Python libraries (going back to 2.4.4, possibly older) can parse this line-breaks correctly.

lib/Target/LLVMBuild.txt
19

good idea!

jroelofs accepted this revision.May 14 2015, 8:30 AM
jroelofs added a reviewer: jroelofs.

I just noticed they're all alphabetized... maybe it makes sense to do all three in the one-per-line style? We're not hurting for line-count in these files.

Either way, LGTM.

This revision is now accepted and ready to land.May 14 2015, 8:30 AM
dougk added a comment.May 14 2015, 8:41 AM

tools/LLVMBuild was not quite alphabetized. I'll check this in as-is, and if the builders are happy, go and re-touch all the things.

This revision was automatically updated to reflect the committed changes.