Page MenuHomePhabricator

Add 'size' field to module load event.
AbandonedPublic

Authored by ChuckR on May 12 2015, 1:51 PM.

Details

Reviewers
abidh
ki.stfu
Summary

Simply adds the size field to this event.

Diff Detail

Event Timeline

ChuckR updated this revision to Diff 25613.May 12 2015, 1:51 PM
ChuckR retitled this revision from to Add 'size' field to module load event..
ChuckR updated this object.
ChuckR edited the test plan for this revision. (Show Details)
ChuckR added reviewers: ki.stfu, abidh.
ChuckR added subscribers: paulmaybee, Unknown Object (MLST).
ki.stfu requested changes to this revision.May 12 2015, 9:27 PM
ki.stfu edited edge metadata.

Update MIExtensions.txt please

test/tools/lldb-mi/TestMiLibraryLoaded.py
32

it may cause false negative on systems where full path to lldb dir contains bad symbols that should be escaped (" or \ etc). I had the same issue in MiSyntaxTestCase.

tools/lldb-mi/MICmnLLDBDebuggerHandleEvents.cpp
725

GetByteSize returns uint32_t/uint64_t therefore you should use PRIu32/64 here

This revision now requires changes to proceed.May 12 2015, 9:27 PM
abidh edited edge metadata.May 13 2015, 1:46 AM

I wonder what you plan to do with the section size.

ChuckR abandoned this revision.Jul 29 2015, 12:05 PM
ChuckR added inline comments.
test/tools/lldb-mi/TestMiLibraryLoaded.py
32

Any suggestions for checking the size then? I could make a second test that only checks for the size field?

ki.stfu added inline comments.Jul 29 2015, 10:14 PM
test/tools/lldb-mi/TestMiLibraryLoaded.py
32

I think u can use an analogue of AddSlashes:

>>> def add_slashes(x): return x.replace("\\", "\\\\").replace("\"", "\\\"").replace("\'", "\\\'")
... 
>>> print "C:\\foo\\bar\\baz\"\'ext"
C:\foo\bar\baz"'ext
>>> print add_slashes("C:\\foo\\bar\\baz\"\'ext")
C:\\foo\\bar\\baz\"\'ext